New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment
link

Issue 911254: ScrollTimeline: upstream Chrome tests to WPT

Reported by smcgruer@chromium.org, Dec 3 Project Member

Issue description

There are ScrollTimeline specs in the following location that could (and should) be ported to WPT:

fast/animation/scroll-animations/

There is an existing scroll-animations location that can be reused.
 

Comment 1 by bugdroid1@chromium.org, Dec 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5177caf7aa96abb2e09036890c5a2ebdaa5081a6

commit 5177caf7aa96abb2e09036890c5a2ebdaa5081a6
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Tue Dec 04 20:06:56 2018

[ScrollTimeline] Begin upstreaming tests to WPT

This CL uploads some basic construction tests for ScrollTimeline. Since
the Chrome implementation still requires timeRange, it is left in for
now (but documented!).

Spec: https://wicg.github.io/scroll-animations

Bug:  911254 
Change-Id: Ia7da845eddcd27ea6e7d3fbaf3a008cbdf6d149a
Reviewed-on: https://chromium-review.googlesource.com/c/1354222
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613666}
[add] https://crrev.com/5177caf7aa96abb2e09036890c5a2ebdaa5081a6/third_party/blink/web_tests/external/wpt/scroll-animations/constructor-expected.txt
[add] https://crrev.com/5177caf7aa96abb2e09036890c5a2ebdaa5081a6/third_party/blink/web_tests/external/wpt/scroll-animations/constructor-no-document.html
[add] https://crrev.com/5177caf7aa96abb2e09036890c5a2ebdaa5081a6/third_party/blink/web_tests/external/wpt/scroll-animations/constructor.html
[modify] https://crrev.com/5177caf7aa96abb2e09036890c5a2ebdaa5081a6/third_party/blink/web_tests/fast/animation/scroll-animations/scrolltimeline-creation.html
[delete] https://crrev.com/cd71654bbf1ff01d5ab5277dc586e66ec992a0c1/third_party/blink/web_tests/fast/animation/scroll-animations/scrolltimeline-parsing-scroll-offsets.html

Comment 2 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c002e31f1305eaaf3bc7e3a93e69c8bd4860d25f

commit c002e31f1305eaaf3bc7e3a93e69c8bd4860d25f
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Thu Dec 06 20:09:40 2018

[ScrollTimeline] Remove duplicate test

scrolltimeline-creation-no-document.html was replaced with
external/wpt/scroll-animations/constructor-no-document.html, but the
original file was not removed.

Bug:  911254 
Change-Id: Ie61f47137feaab61112d73c0514c6595b9c264d6
Reviewed-on: https://chromium-review.googlesource.com/c/1365080
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614469}
[delete] https://crrev.com/3a89a4cc3dd70aabb694637dadc61e1be44d8d28/third_party/blink/web_tests/fast/animation/scroll-animations/scrolltimeline-creation-no-document.html

Comment 3 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42baeb7ae71e916dc19433ce698de5c02d5fa169

commit 42baeb7ae71e916dc19433ce698de5c02d5fa169
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Fri Dec 07 00:59:26 2018

[ScrollTimeline] Upstream based currentTime tests to WPT

This CL starts to upstream the currentTime tests to WPT. To split this
up, we start with just the 'basic' tests - basic functionality,
adjusting for time range, and start/end scroll offsets. The writing mode
and NaN tests will follow in later patches.

There are a few mostly non-behavioral changes to the tests in this CL:

  * Some comments were edited for clarity.
  * For tests with more than one assert_equals(), descriptions were
    added to the asserts. This is to help locate failing assert_equal
    lines, as jsharness does not print out the line number of a failure.
  * In a few places we had more than one assert_equals for the same
    scenario (e.g. multiple cases where scroll was after the
    startScrollOffset point). These have been deduplicated.

Bug:  911254 
Change-Id: I783fcf7f43cda876defa9c36db9a0e7dff4e82c7
Reviewed-on: https://chromium-review.googlesource.com/c/1366297
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614510}
[add] https://crrev.com/42baeb7ae71e916dc19433ce698de5c02d5fa169/third_party/blink/web_tests/external/wpt/scroll-animations/current-time.html
[add] https://crrev.com/42baeb7ae71e916dc19433ce698de5c02d5fa169/third_party/blink/web_tests/external/wpt/scroll-animations/resources/scrolltimeline-utils.js
[modify] https://crrev.com/42baeb7ae71e916dc19433ce698de5c02d5fa169/third_party/blink/web_tests/fast/animation/scroll-animations/scrolltimeline-currenttime.html

Comment 4 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aaccd137c09929f543b993907bfc2f42f45dd27

commit 4aaccd137c09929f543b993907bfc2f42f45dd27
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Mon Dec 10 15:38:23 2018

[ScrollTimeline] Upstream writing-mode currentTime tests to WPT

This CL upstreams the writing-mode related currentTime tests to WPT.
There are a few mostly non-behavioral changes to the tests in this CL:

  * Some comments were edited for clarity.
  * For tests with more than one assert_equals(), descriptions were
    added to the asserts. This is to help locate failing assert_equal
    lines, as jsharness does not print out the line number of a failure.
  * In a few places we had more than one assert_equals for the same
    scenario (e.g. multiple cases where scroll was after the
    startScrollOffset point). These have been deduplicated.

Bug:  911254 

Change-Id: I5e814acea281e2587164de634da9a5415b53de2c
Reviewed-on: https://chromium-review.googlesource.com/c/1366263
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615126}
[add] https://crrev.com/4aaccd137c09929f543b993907bfc2f42f45dd27/third_party/blink/web_tests/external/wpt/scroll-animations/current-time-writing-modes.html
[modify] https://crrev.com/4aaccd137c09929f543b993907bfc2f42f45dd27/third_party/blink/web_tests/external/wpt/scroll-animations/current-time.html
[delete] https://crrev.com/cd01dfdfc73cd2f927ad177c48a77f1c07c760aa/third_party/blink/web_tests/fast/animation/scroll-animations/scrolltimeline-currenttime.html

Comment 5 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2033984b17631d84ea4befb0fad905a965897655

commit 2033984b17631d84ea4befb0fad905a965897655
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Mon Dec 10 16:22:28 2018

[ScrollTimeline] Upstream NaN currentTime tests to WPT

This CL upstreams the NaN related currentTime tests to WPT. There are no
behavioral changes.

Bug:  911254 
Change-Id: Ide27accae72cc55654890754ac404c7827889d09
Reviewed-on: https://chromium-review.googlesource.com/c/1366264
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615137}
[rename] https://crrev.com/2033984b17631d84ea4befb0fad905a965897655/third_party/blink/web_tests/external/wpt/scroll-animations/current-time-nan.html

Comment 6 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9e7a3e8b9070ac89cfc487175c8b8d4d1824fb2

commit e9e7a3e8b9070ac89cfc487175c8b8d4d1824fb2
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Mon Dec 10 20:22:50 2018

[ScrollTimeline] Upstream root scroller currentTime test to WPT

This CL upstreams the root scroller currentTime test to WPT. The quirks
mode test is left in fast/animation/scroll-animations as it is just a
crash test for running in quirks mode, which is Chrome-specific and not
upstreamable.

There are no behavioral changes.

Bug:  911254 
Change-Id: Ia8270f11ede8746cbdecf7ba57aeca60eee6fb78
Reviewed-on: https://chromium-review.googlesource.com/c/1366367
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615225}
[rename] https://crrev.com/e9e7a3e8b9070ac89cfc487175c8b8d4d1824fb2/third_party/blink/web_tests/external/wpt/scroll-animations/current-time-root-scroller.html

Comment 7 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a82bda8239b3580a20c48efe5909052ea4fee215

commit a82bda8239b3580a20c48efe5909052ea4fee215
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Tue Dec 11 15:48:39 2018

[ScrollTimeline] Add README.md to fast/animation/scroll-animations

This CL adds a README.md to the fast/animations/scroll-animations
directory, explaining when that directory should be used vs
external/wpt/scroll-animations (aka, rarely).

Bug:  911254 
Change-Id: Id24ee770dcbe070b1f89ffe925edbacbba4a673c

TBR=yigu@chromium.org

Change-Id: Id24ee770dcbe070b1f89ffe925edbacbba4a673c
Reviewed-on: https://chromium-review.googlesource.com/c/1367825
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615535}
[add] https://crrev.com/a82bda8239b3580a20c48efe5909052ea4fee215/third_party/blink/web_tests/fast/animation/scroll-animations/README.md

Comment 8 by smcgruer@chromium.org, Dec 11

Status: Fixed (was: Started)

Sign in to add a comment