New issue
Advanced search Search tips

Issue 911237 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 7
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Enable Web Audio autoplay policy on trunk

Project Member Reported by mlamouri@chromium.org, Dec 3

Issue description

It's enabled on Stable M71 via finch (soft launch), we need to have it on trunk in M72.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5

commit 2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Dec 05 01:39:01 2018

Autoplay: enable Web Audio changes by default on trunk.

This is also setting owners and expiry milestone for the associated
chrome://flags.

Bug:  911237 
Change-Id: I7156b2178eef0dfeb89a7de0279c32f0f2fd2107
Reviewed-on: https://chromium-review.googlesource.com/c/1355333
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613800}
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/chrome/browser/flag-metadata.json
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/content/browser/media/webaudio/audio_context_manager_browsertest.cc
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/media/base/media_switches.cc
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/renderer/modules/webaudio/audio_context.cc
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/http/tests/media/autoplay/resources/webaudio-iframe-no-gesture.html
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/http/tests/media/autoplay/webaudio-autoplay-iframe-no-gesture.html
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/http/tests/security/media-element-audio-source-node-cross-origin-allowed-expected.txt
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/http/tests/security/media-element-audio-source-node-cross-origin-expected.txt
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/http/tests/security/media-element-audio-source-node-cross-origin-with-credentials-expected.txt
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/http/tests/security/media-element-audio-source-node-redirect-expected.txt
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/http/tests/security/media-element-audio-source-node-same-origin-expected.txt
[delete] https://crrev.com/6f60ad1891f4c1eb4d1c9877f9f8fb9b98362d61/third_party/blink/web_tests/http/tests/webaudio/autoplay-crossorigin-expected.txt
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/http/tests/webaudio/autoplay-crossorigin.html
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/http/tests/webaudio/resources/autoplay-crossorigin-iframe.html
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/webaudio/AudioParam/audioparam-nominal-range-expected.txt
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/webaudio/internals/audiocontext-lock-threading-race-expected.txt
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/webaudio/internals/mediaelementaudiosourcenode-gc-expected.txt
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/webaudio/internals/mediaelementaudiosourcenode-wrapper-expected.txt
[modify] https://crrev.com/2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5/third_party/blink/web_tests/webaudio/unit-tests/audit-expected.txt

Labels: Merge-Request-72
Requesting merge to 72 as it has merged to Canary and everything seems fine.
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 7

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 7

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46f44a358409ac6ff1dae17bd6405b083634c2c6

commit 46f44a358409ac6ff1dae17bd6405b083634c2c6
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Fri Dec 07 18:24:42 2018

Autoplay: enable Web Audio changes by default on trunk.

This is also setting owners and expiry milestone for the associated
chrome://flags.

Bug:  911237 
Change-Id: I7156b2178eef0dfeb89a7de0279c32f0f2fd2107
Reviewed-on: https://chromium-review.googlesource.com/c/1355333
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613800}(cherry picked from commit 2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5)
Reviewed-on: https://chromium-review.googlesource.com/c/1368306
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#140}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/chrome/browser/flag-metadata.json
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/content/browser/media/webaudio/audio_context_manager_browsertest.cc
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/media/base/media_switches.cc
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/renderer/modules/webaudio/audio_context.cc
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/http/tests/media/autoplay/resources/webaudio-iframe-no-gesture.html
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/http/tests/media/autoplay/webaudio-autoplay-iframe-no-gesture.html
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/http/tests/security/media-element-audio-source-node-cross-origin-allowed-expected.txt
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/http/tests/security/media-element-audio-source-node-cross-origin-expected.txt
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/http/tests/security/media-element-audio-source-node-cross-origin-with-credentials-expected.txt
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/http/tests/security/media-element-audio-source-node-redirect-expected.txt
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/http/tests/security/media-element-audio-source-node-same-origin-expected.txt
[delete] https://crrev.com/99592c8fdabd5c5a79fb853eae3e39dde9d19d84/third_party/blink/web_tests/http/tests/webaudio/autoplay-crossorigin-expected.txt
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/http/tests/webaudio/autoplay-crossorigin.html
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/http/tests/webaudio/resources/autoplay-crossorigin-iframe.html
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/webaudio/AudioParam/audioparam-nominal-range-expected.txt
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/webaudio/internals/audiocontext-lock-threading-race-expected.txt
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/webaudio/internals/mediaelementaudiosourcenode-gc-expected.txt
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/webaudio/internals/mediaelementaudiosourcenode-wrapper-expected.txt
[modify] https://crrev.com/46f44a358409ac6ff1dae17bd6405b083634c2c6/third_party/blink/web_tests/webaudio/unit-tests/audit-expected.txt

Status: Fixed (was: Started)
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/46f44a358409ac6ff1dae17bd6405b083634c2c6

Commit: 46f44a358409ac6ff1dae17bd6405b083634c2c6
Author: mlamouri@chromium.org
Commiter: mlamouri@chromium.org
Date: 2018-12-07 18:24:42 +0000 UTC

Autoplay: enable Web Audio changes by default on trunk.

This is also setting owners and expiry milestone for the associated
chrome://flags.

Bug:  911237 
Change-Id: I7156b2178eef0dfeb89a7de0279c32f0f2fd2107
Reviewed-on: https://chromium-review.googlesource.com/c/1355333
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613800}(cherry picked from commit 2bd6f5efe912ad8dbb9f9f47e9fa08ca0487d9d5)
Reviewed-on: https://chromium-review.googlesource.com/c/1368306
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#140}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment