New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 911232 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Feature



Sign in to add a comment

Introduce a flag to enable USS Bookmarks for iOS

Project Member Reported by mamir@chromium.org, Dec 3

Issue description

The flag existed for long time on other platforms.
It's only missing on iOS.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e8a1f05d53e1d23f394c7112155160ff08a1f97

commit 9e8a1f05d53e1d23f394c7112155160ff08a1f97
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Mon Dec 03 21:41:14 2018

[Sync::USS] Adding the flag to enable USS Bookmarks on iOS

Bug:  911232 
Change-Id: I4813401d73ae6281fd044882c8e61869223c0911
Reviewed-on: https://chromium-review.googlesource.com/c/1359034
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613260}
[modify] https://crrev.com/9e8a1f05d53e1d23f394c7112155160ff08a1f97/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/9e8a1f05d53e1d23f394c7112155160ff08a1f97/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/9e8a1f05d53e1d23f394c7112155160ff08a1f97/ios/chrome/browser/ios_chrome_flag_descriptions.h

Status: Fixed (was: Started)
Labels: Merge-Request-72
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 5

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bb13629dda6beefcf2bf57a97d5211bf5636b62

commit 5bb13629dda6beefcf2bf57a97d5211bf5636b62
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date: Wed Dec 05 15:18:47 2018

Merge "[Sync::USS] Adding the flag to enable USS Bookmarks ..." to M72

Bug:  911232 
Change-Id: I4813401d73ae6281fd044882c8e61869223c0911
Reviewed-on: https://chromium-review.googlesource.com/c/1359034
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613260}(cherry picked from commit 9e8a1f05d53e1d23f394c7112155160ff08a1f97)
Reviewed-on: https://chromium-review.googlesource.com/c/1363277
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#78}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/5bb13629dda6beefcf2bf57a97d5211bf5636b62/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/5bb13629dda6beefcf2bf57a97d5211bf5636b62/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/5bb13629dda6beefcf2bf57a97d5211bf5636b62/ios/chrome/browser/ios_chrome_flag_descriptions.h

Status: Verified (was: Fixed)
Issue verified 
Version: Chrome Canary 73.0.3637.0
Device: iPhone XS
iOS: 12.1

Able to see the flag on iOS
https://drive.google.com/open?id=1dAXc10ZxC1n4vVUxpOHkdhmURUpW_Ieh
Verified on M72.0.3626.15 beta
iOS: 12.1.1 iPad Pro
Flag #enable-sync-uss-bookmarks is available on about://flags.
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/5bb13629dda6beefcf2bf57a97d5211bf5636b62

Commit: 5bb13629dda6beefcf2bf57a97d5211bf5636b62
Author: mamir@chromium.org
Commiter: mamir@chromium.org
Date: 2018-12-05 15:18:47 +0000 UTC

Merge "[Sync::USS] Adding the flag to enable USS Bookmarks ..." to M72

Bug:  911232 
Change-Id: I4813401d73ae6281fd044882c8e61869223c0911
Reviewed-on: https://chromium-review.googlesource.com/c/1359034
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613260}(cherry picked from commit 9e8a1f05d53e1d23f394c7112155160ff08a1f97)
Reviewed-on: https://chromium-review.googlesource.com/c/1363277
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#78}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment