New issue
Advanced search Search tips

Issue 911217 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 904240



Sign in to add a comment

Clean up service GN template

Project Member Reported by rockot@google.com, Dec 3

Issue description

The service() target should be renamed to service_executable()

The standalone_service sublibrary of service_manager public/cpp should be renamed to service_executable.

There's a bunch of unused dependencies on it, and crud floating around in it that can be cleaned up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5079280b8b709811bb939fd3030f7c521fd0a31d

commit 5079280b8b709811bb939fd3030f7c521fd0a31d
Author: Ken Rockot <rockot@google.com>
Date: Tue Dec 04 21:12:03 2018

Clean up standalone service entry points

This gets rid of the old C-linkage entry point for standalone service
binaries, in favor of a cleaner and typesafe C++ entry point which takes
a proper ServiceRequest.

TBR=msw@chromium.org
TBR=jamescook@chromium.org

Bug:  911217 
Change-Id: Ide390764db97eaa45806fdb3ca0f3e39a408baa7
Reviewed-on: https://chromium-review.googlesource.com/c/1359475
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#613691}
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/ash/BUILD.gn
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/ash/components/quick_launch/main.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/components/services/filesystem/main.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/components/services/font/main.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/components/services/leveldb/main.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/mash/catalog_viewer/BUILD.gn
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/mash/example/views_examples/BUILD.gn
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/mash/example/window_type_launcher/BUILD.gn
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/mash/example/window_type_launcher/window_type_launcher.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/mash/session/BUILD.gn
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/mash/task_viewer/BUILD.gn
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/media/mojo/services/main.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/audio/service_main.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/background/tests/BUILD.gn
[delete] https://crrev.com/9421312f06c1296851fb7e37d0935c77ee0209ca/services/service_manager/public/c/main.h
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/public/cpp/service.gni
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/public/cpp/standalone_service/BUILD.gn
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/public/cpp/standalone_service/main.cc
[delete] https://crrev.com/9421312f06c1296851fb7e37d0935c77ee0209ca/services/service_manager/public/cpp/standalone_service/main_cpp.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/public/cpp/standalone_service/service_main.h
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/runner/host/host_test_service_main.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/tests/connect/BUILD.gn
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/tests/connect/connect_test_package.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/tests/lifecycle/BUILD.gn
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/tests/lifecycle/app.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/tests/lifecycle/app_client.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/tests/lifecycle/app_client.h
[delete] https://crrev.com/9421312f06c1296851fb7e37d0935c77ee0209ca/services/service_manager/tests/lifecycle/lifecycle_exe.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/tests/lifecycle/package.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/tests/service_manager/BUILD.gn
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/service_manager/tests/shutdown/BUILD.gn
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/video_capture/service_main.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/viz/BUILD.gn
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/ws/ime/test_ime_driver/main.cc
[modify] https://crrev.com/5079280b8b709811bb939fd3030f7c521fd0a31d/services/ws/test_ws/BUILD.gn

Summary: Clean up service GN template (was: Delete the service GN target template)
This suggestion didn't really garner any support from other developers, so I'm not going to delete it. I am going to rename it to service_executable though, because I want it to be clear that services (i.e. implementations of Service) and service executables are two distinct things and the former can exist without the latter. I concluded that this must not be clear to developers based on the number of unused service targets I've deleted.
Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea

commit 975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea
Author: Ken Rockot <rockot@google.com>
Date: Tue Dec 11 02:41:15 2018

[service-manager] service => service_executable

This cleans up service executable support in the client library and its
usage around the tree. Namely:

- The GN service() template is renamed to service_executable()
- The public/cpp/standalone_service directory is renamed to
  public/cpp/service_executable
- The code in aforementioned directory is simplified and unused switches
  deleted
- Unused dependencies on the above stuff have been removed

TBR=sky@chromium.org

Bug:  911217 
Change-Id: I08244059ef9e473df2f4a33303e3b3979efeb933
Reviewed-on: https://chromium-review.googlesource.com/c/1367087
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615396}
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/ash/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/ash/components/quick_launch/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/ash/components/quick_launch/main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/components/services/filesystem/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/components/services/filesystem/main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/components/services/font/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/components/services/font/main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/components/services/leveldb/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/components/services/leveldb/main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/mash/catalog_viewer/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/mash/catalog_viewer/main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/mash/example/views_examples/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/mash/example/views_examples/views_examples.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/mash/example/window_type_launcher/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/mash/example/window_type_launcher/window_type_launcher.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/mash/session/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/mash/session/main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/mash/task_viewer/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/mash/task_viewer/main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/media/mojo/services/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/media/mojo/services/main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/audio/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/audio/service_main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/catalog/public/tools/catalog.gni
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/resource_coordinator/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/README.md
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/background/tests/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/embedder/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/embedder/main.cc
[delete] https://crrev.com/ea1f3ca634e14da91834869c7aa4e9922a8448f0/services/service_manager/public/cpp/service.gni
[add] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/public/cpp/service_executable.gni
[rename] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/public/cpp/service_executable/BUILD.gn
[rename] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/public/cpp/service_executable/DEPS
[rename] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/public/cpp/service_executable/main.cc
[rename] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/public/cpp/service_executable/service_executable_environment.cc
[add] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/public/cpp/service_executable/service_executable_environment.h
[rename] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/public/cpp/service_executable/service_main.h
[delete] https://crrev.com/ea1f3ca634e14da91834869c7aa4e9922a8448f0/services/service_manager/public/cpp/standalone_service/standalone_service.h
[delete] https://crrev.com/ea1f3ca634e14da91834869c7aa4e9922a8448f0/services/service_manager/public/cpp/standalone_service/switches.cc
[delete] https://crrev.com/ea1f3ca634e14da91834869c7aa4e9922a8448f0/services/service_manager/public/cpp/standalone_service/switches.h
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/runner/host/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/runner/host/host_test_service_main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/runner/host/service_process_launcher.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/standalone/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/connect/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/connect/connect_test_class_app.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/connect/connect_test_exe.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/connect/connect_test_package.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/connect/connect_test_singleton_app.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/lifecycle/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/lifecycle/app.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/lifecycle/package.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/lifecycle/parent.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/service_manager/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/service_manager/embedder.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/service_manager/target.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/shutdown/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/shutdown/shutdown_client_app.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/service_manager/tests/shutdown/shutdown_service_app.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/video_capture/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/video_capture/service_main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/viz/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/viz/main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/ws/ime/test_ime_driver/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/ws/ime/test_ime_driver/main.cc
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/ws/test_ws/BUILD.gn
[modify] https://crrev.com/975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea/services/ws/test_ws/test_ws.cc

Status: Fixed (was: Started)

Comment 6 by rockot@google.com, Jan 17 (5 days ago)

Blocking: 904240

Sign in to add a comment