New issue
Advanced search Search tips

Issue 911191 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 8
Cc:
robliao@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Reenable L10nUtilTest.GetString for Android

Project Member Reported by robliao@chromium.org, Dec 3 
The last mile for L10nUtilTest.GetString is to get the resources read by the devices. This works fine in the simulator but fails on the bots.

For the subsequent change, insert in the following build rules:
//ui/base/BUILD.gn

if (is_android) {
  android_assets("ui_base_test_android_assets") {
    testonly = true

    # Use $target_gen_dir so the associated .pak.info file is available.
    sources = [
      "$target_gen_dir/ui_base_test_resources.pak",
    ]
    deps = [
      ":ui_base_test_resources_grit",
    ]
  }
}

Fix up deps in ui_base_unittests:
if (is_android) {
  deps += [ ":ui_base_test_android_assets" ]
}


And then in 
//ui/base/test/run_all_unittests.cc
#if defined(OS_ANDROID)
  result =
      base::PathService::Get(ui::DIR_RESOURCE_PAKS_ANDROID, &dir_resources);
#elif ...
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ee50004eeb7d6b0b83d983c5bb6dc705c1a7825

commit 8ee50004eeb7d6b0b83d983c5bb6dc705c1a7825
Author: Robert Liao <robliao@chromium.org>
Date: Tue Dec 04 17:54:27 2018

Reenable L10nUtilTest.GetString Except On Android and Move Required Resources into ui_base_test_resources.pak

Deferring Android because resources don't seem to get loaded properly on devices.

BUG= 911191 

Change-Id: I6a6adff76538075587d6b8844f78b05fd2e9b2c1
Reviewed-on: https://chromium-review.googlesource.com/c/1358468
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613592}
[modify] https://crrev.com/8ee50004eeb7d6b0b83d983c5bb6dc705c1a7825/chrome/test/BUILD.gn
[delete] https://crrev.com/31cab084885ef072ff89cfb83c1973a18b4d3495/chrome/test/data/resource.rc
[modify] https://crrev.com/8ee50004eeb7d6b0b83d983c5bb6dc705c1a7825/tools/gritsettings/resource_ids
[modify] https://crrev.com/8ee50004eeb7d6b0b83d983c5bb6dc705c1a7825/ui/base/BUILD.gn
[modify] https://crrev.com/8ee50004eeb7d6b0b83d983c5bb6dc705c1a7825/ui/base/l10n/l10n_util_unittest.cc
[delete] https://crrev.com/31cab084885ef072ff89cfb83c1973a18b4d3495/ui/base/test/data/resource.h
[modify] https://crrev.com/8ee50004eeb7d6b0b83d983c5bb6dc705c1a7825/ui/base/test/run_all_unittests.cc
[add] https://crrev.com/8ee50004eeb7d6b0b83d983c5bb6dc705c1a7825/ui/base/test/ui_base_test_resources.grd
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06c3596b92fa03cdf17eed7278c475a958126217

commit 06c3596b92fa03cdf17eed7278c475a958126217
Author: Robert Liao <robliao@chromium.org>
Date: Sat Dec 08 01:00:41 2018

Reenable ui_base_unittests L10nUtilTest.GetString on Android

BUG= 911191 

Change-Id: Ic641b53cbed17f191adb503aa28f2ce07f48b9f2
Reviewed-on: https://chromium-review.googlesource.com/c/1368305
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614892}
[modify] https://crrev.com/06c3596b92fa03cdf17eed7278c475a958126217/ui/base/BUILD.gn
[modify] https://crrev.com/06c3596b92fa03cdf17eed7278c475a958126217/ui/base/l10n/l10n_util_unittest.cc
[modify] https://crrev.com/06c3596b92fa03cdf17eed7278c475a958126217/ui/base/test/run_all_unittests.cc

Comment 3 by robliao@chromium.org, Dec 8

Status: Fixed (was: Available)
►

Sign in to add a comment