New issue
Advanced search Search tips

Issue 911189 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 7
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Rare flakes caused by the trace importer merging the wrong _BEGIN and _END elements (Perfetto related)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 3

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of oysteine@google.com

rendering.desktop/css_animations_staggered_style_element and 1 other(s) in performance_test_suite failing on chromium.perf/Win 7 Perf

Builders failed on: 
- Win 7 Perf: 
  https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/Win%207%20Perf


 
Status: Started (was: Available)
The symptom is this:

(ERROR) 2018-12-02 18:31:18,003 page_test_results.Fail:587  Failure recorded: TraceImportError: Slice TaskScheduler RunTask end time is before its start.

    at SliceGroup.endSlice (/tracing/model/slice_group.html:189:15)

    at TraceEventImporter.processDurationEvent (/tracing/extras/importer/trace_event_importer.html:530:41)

    at TraceEventImporter.processEvent_ (/tracing/extras/importer/trace_event_importer.html:1238:16)

    at TraceEventImporter.importEvents (/tracing/extras/importer/trace_event_importer.html:1148:16)

    at importer (/tracing/importer/import.html:198:65)

    at task.subTask (/tracing/importer/import.html:145:32)

    at Task.run (/tracing/base/task.html:80:50)

    at Function.Task.RunSynchronously (/tracing/base/task.html:125:25)

    at Import.importTraces (/tracing/importer/import.html:74:17)

    at createModelFromTraceData (c:\b\s\w\ir\third_party\catapult\tracing\tracing\mre\map_single_trace_cmdline.html:38:9)
It's happening because Perfetto currently splits _COMPLETE events into separate _BEGIN and _END pairs. It looks like the trace-importer sometimes reassembles these in the wrong order, causing this rare flake. I'm working on a CL to avoid the splitting (https://chromium-review.googlesource.com/c/chromium/src/+/1354503)
Status: Fixed (was: Started)
CL landed; those particular flakes look like they're gone.

Sign in to add a comment