Issue metadata
Sign in to add a comment
|
generate_bytecode_builtins_list creates a build-dir-dependent path |
||||||||||||||||||||||
Issue descriptionGenerate build files in out/gn and out/gn2. Compare out/gn/toolchain.ninja and out/gn2/toolchain.ninja Expected: No differences. Actual: command = c$:/src/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../v8/tools/run.py ./bytecode_builtins_list_generator C$:/src/chrome/src/out/gn/gen/v8/builtins-generated/bytecodes-builtins-list.h vs command = c$:/src/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../v8/tools/run.py ./bytecode_builtins_list_generator C$:/src/chrome/src/out/gn2/gen/v8/builtins-generated/bytecodes-builtins-list.h (see "gn2" vs "gn" in last arg) See https://chromium-review.googlesource.com/1164536 for how to fix this: Instead of rebase_path("$target_gen_dir/builtins-generated/bytecodes-builtins-list.h"), Do rebase_path("$target_gen_dir/builtins-generated/bytecodes-builtins-list.h", root_build_dir),
,
Dec 3
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/48924ffa0faddfa742392a993d6a2e76fe4111e9 commit 48924ffa0faddfa742392a993d6a2e76fe4111e9 Author: Nico Weber <thakis@chromium.org> Date: Mon Dec 03 19:04:22 2018 Make generate_bytecode_builtins_list build-dir-independent. Bug: chromium:911183 Change-Id: I99552d09e68a6b99e35daf39e15ddf1ef5781baa Reviewed-on: https://chromium-review.googlesource.com/c/1358701 Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58000} [modify] https://crrev.com/48924ffa0faddfa742392a993d6a2e76fe4111e9/BUILD.gn |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by thakis@chromium.org
, Dec 3Status: Started (was: Assigned)