Remove StoragePartition::GetURLRequestContext calls on ChromeOS |
||||
Issue descriptionhttps://chromium-review.googlesource.com/c/chromium/src/+/1355136 added a DCHECK if StoragePartition:GetURLRequestContext is called when the network service is enabled. It does have a few places where it allows it while they're being converted. In patchset 9: https://chromium-review.googlesource.com/c/chromium/src/+/1355136/9, I tried enabling this on ChromeOS but it failed a few tests. See https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_mojo_chromeos/300, specifically: ActiveDirectoryLoginAutocompleteTest.LoginSuccess ActiveDirectoryLoginTest.PasswordChange_LoginSuccess ActiveDirectoryLoginTest.LoginSuccess ActiveDirectoryLoginTest.LoginErrors ActiveDirectoryLoginTest.PasswordChange_ReopenClearErrors OobeTest.Accelerator ActiveDirectoryLoginAutocompleteTest.TestAutocomplete LoginUITest.LoginUIVisible ActiveDirectoryLoginTest.PasswordChange_UIErrors SamlTest.HTTPRedirectDisallowed OAuth2Test.TerminateOnBadMergeSessionAfterOnlineAuth WebviewClientCertsLoginTest.SigninFrameIntermediateAuthorityUnknown KioskUpdateTest.UsbStickUpdateAppLowerAppVersion ForceMaximizePolicyFalseTest.GeneralFirstRun AccessibilityManagerLoginTest.BrailleOnLoginScreen SamlTest.UseAutenticatedUserEmailAddress ActiveDirectoryJoinTest.TestActiveDirectoryEnrollment_DistinguishedName KioskTest.KioskEnableCancel SiteIsolationFlagHandlingTest.FlagHandlingTest/4 SamlTest.PasswordConfirmFlow KioskEnterpriseTest.PrivateStore KioskTest.LaunchAppNetworkDownConfigureNotAllowed DeviceDisablingTest.DisableWithEphemeralUsers which all appear to be because of this call: chromeos::login::SigninPartitionManager::StartSigninSession()
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29eaef4badb6f952dc6f6d6c8c5153d5981fbda2 commit 29eaef4badb6f952dc6f6d6c8c5153d5981fbda2 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Tue Dec 04 00:43:05 2018 Disable StoragePartitionImpl DCHECK's on ChromeOS Bug: 911173 Change-Id: I8ecef4636e421c0e698af3d5f1796fca78cb269a Reviewed-on: https://chromium-review.googlesource.com/c/1359330 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#613355} [modify] https://crrev.com/29eaef4badb6f952dc6f6d6c8c5153d5981fbda2/content/browser/storage_partition_impl.cc
,
Dec 11
,
Dec 11
Assigning to rmcelrath@ as he's already started on this.
,
Jan 15
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jam@chromium.org
, Dec 3Blocking: 827532 837753