New issue
Advanced search Search tips

Issue 911172 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 916262
Owner: ----
Closed: Dec 20
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318



Sign in to add a comment

Remove chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc's usage of ProfileOAuth2TokenService

Project Member Reported by blundell@chromium.org, Dec 3

Issue description

It's just used to check that GetPendingRequests() isn't empty. Where WaitForAccessTokenRequest* is already used, we can just remove the check entirely, as WaitForAccessTokenRequest* waits for an access token request internally and thus implicitly checks that an access token request occurs. Where it's just used to verify that there's an access token request outstanding, we can replace the usage with a call to WaitForAccessTokenRequest*.

We can rename IsRequestActive() to IsNetworkRequestActive() and make sure that it's only used when we're verifying that there's a network request, not to verify that there's a pending access token request.

Don't spend too much time trying to get this exactly right, as in the end this is not the fundamentals of this test code. We can always refine the changes during code review.
 
Mergedinto: 916262
Status: Duplicate (was: Available)
It is a dup, but I will copy the (awesome) description here to bug 916262.

Sign in to add a comment