New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 911141 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 4
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

AEC3: meaning of ENR is inversed in dominant nearend detector

Project Member Reported by gustaf@chromium.org, Dec 3

Issue description

The meaning of echo-to-noise ratio is inversed in the
dominant nearend detector. A high value should mean
strong echo.
 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9d54bd889898baa02a2b3920cbaf80fa3c70e598

commit 9d54bd889898baa02a2b3920cbaf80fa3c70e598
Author: Gustaf Ullberg <gustaf@webrtc.org>
Date: Mon Dec 03 15:19:00 2018

AEC3: Fix ENR threshold for WebRTC-Aec3UseLegacyNormalSuppressorTuning

Fixes the ENR threshold used in the dominant nearend detection when
the kill-switch WebRTC-Aec3UseLegacyNormalSuppressorTuning is pulled.

Bug: webrtc:8671, chromium:911141 
Change-Id: I30ee58009633b3a9e12eff692226baada624a049
Reviewed-on: https://webrtc-review.googlesource.com/c/112903
Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org>
Reviewed-by: Per Ã…hgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25880}
[modify] https://crrev.com/9d54bd889898baa02a2b3920cbaf80fa3c70e598/modules/audio_processing/aec3/echo_canceller3.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09a12f0b076153c57a899db4fecef18d8ea455aa

commit 09a12f0b076153c57a899db4fecef18d8ea455aa
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Dec 03 21:43:12 2018

Roll src/third_party/webrtc 056f9738bf7a..ec0f45be1144 (2 commits)

https://webrtc.googlesource.com/src.git/+log/056f9738bf7a..ec0f45be1144


git log 056f9738bf7a..ec0f45be1144 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 solenberg@webrtc.org Revert "Remove CodecInst pt.1"
2018-12-03 gustaf@webrtc.org AEC3: Fix ENR threshold for WebRTC-Aec3UseLegacyNormalSuppressorTuning


Created with:
  gclient setdep -r src/third_party/webrtc@ec0f45be1144

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG= chromium:911141 
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Idd7032f0791826747a1499fd8112dafb701551ef
Reviewed-on: https://chromium-review.googlesource.com/c/1358761
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613262}
[modify] https://crrev.com/09a12f0b076153c57a899db4fecef18d8ea455aa/DEPS

Labels: Merge-Request-72
Status: Fixed (was: Started)
I would like to merge this bugfix for AEC3 (WebRTC echo canceller) that just missed the cut.

CLs to merge:
https://webrtc-review.googlesource.com/c/src/+/112136
https://webrtc-review.googlesource.com/c/src/+/112903
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 4

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: M-72
A note on the CLs.
The first CL is well baked in canary since Nov 28.
The second CL is just changing a constant and is enabled/disabled by a server side switch.
Labels: -Merge-Review-72 Merge-Approved-72
Approving merge to M72 branch 3626 based on comments #4 and #6. 
Labels: -Merge-Approved-72 Merge-Merged
CLs merged as
feccc3e9362083ca83461923f71d2a3acce29bbe
a1f40d086dd181c3a6e0e7609596dd1e939bdebc


Sign in to add a comment