Share extension: crash in loadElementsFromContext |
|||
Issue description__46-[ShareViewController loadElementsFromContext]_block_invoke_2 + share_view_controller.mm:210 Last Exception Backtrace: 0 CoreFoundation 0x225ea3ea0 __exceptionPreprocess + 1 libobjc.A.dylib 0x225075a40 objc_exception_throw + 2 CoreFoundation 0x225dbcd04 -[NSOrderedSet initWithSet:copyItems:] + 3 CoreFoundation 0x225ea97b8 ___forwarding___ + 4 CoreFoundation 0x225eab45c _CF_forwarding_prep_0 + 5 share_extension 0x102979b90 __46-[ShareViewController loadElementsFromContext]_block_invoke_2 + share_view_controller.mm:210 6 libdispatch.dylib 0x2258dd6c8 _dispatch_call_block_and_release + 7 libdispatch.dylib 0x2258de484 _dispatch_client_callout + 8 libdispatch.dylib 0x22588a9b4 _dispatch_main_queue_callback_4CF$VARIANT$mp + 9 CoreFoundation 0x225e33dd0 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 10 CoreFoundation 0x225e2ec98 __CFRunLoopRun + 11 CoreFoundation 0x225e2e1cc CFRunLoopRunSpecific + 12 GraphicsServices 0x2280a5584 GSEventRunModal + 13 UIKitCore 0x253071054 UIApplicationMain + 14 libxpc.dylib 0x225b00098 _xpc_objc_main + 15 libxpc.dylib 0x225b02a30 xpc_main + 16 Foundation 0x226860db0 +[NSXPCListener serviceListener] + 17 PlugInKit 0x22ba7f498 -[PKService run] + 132 (PKService.m:100) 18 PlugInKit 0x22ba7f2c4 +[PKService main] + 192 (PKService.m:52) 19 PlugInKit 0x22ba7f848 +[PKService _defaultRun:arguments:] + 20 (PKService.m:148) 20 Foundation 0x226a486bc NSExtensionMain + 21 libdyld.dylib 0x2258eebb4 start + Thread 0 name: Thread 0 Crashed: 0 libsystem_kernel.dylib 0x0000000225a3b104 __pthread_kill + 1 libsystem_pthread.dylib 0x0000000225ab6070 pthread_kill$VARIANT$mp + 2 libsystem_c.dylib 0x0000000225992d78 abort + 3 libc++abi.dylib 0x000000022505cf78 __cxa_bad_cast + 4 libc++abi.dylib 0x000000022505d120 default_unexpected_handler() + 5 libobjc.A.dylib 0x0000000225075e48 _objc_terminate() + 6 libc++abi.dylib 0x00000002250690fc std::__terminate(void (*)()) + 7 libc++abi.dylib 0x0000000225069188 std::terminate() + 8 libdispatch.dylib 0x00000002258de498 _dispatch_client_callout + 9 libdispatch.dylib 0x000000022588a9b4 _dispatch_main_queue_callback_4CF$VARIANT$mp + 10 CoreFoundation 0x0000000225e33dd0 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 11 CoreFoundation 0x0000000225e2ec98 __CFRunLoopRun + 12 CoreFoundation 0x0000000225e2e1cc CFRunLoopRunSpecific + 13 GraphicsServices 0x00000002280a5584 GSEventRunModal + 14 UIKitCore 0x0000000253071054 UIApplicationMain + 15 libxpc.dylib 0x0000000225b00098 _xpc_objc_main + 16 libxpc.dylib 0x0000000225b02a30 xpc_main + 17 Foundation 0x0000000226860db0 +[NSXPCListener serviceListener] + 18 PlugInKit 0x000000022ba7f498 -[PKService run] + 132 (PKService.m:100) 19 PlugInKit 0x000000022ba7f2c4 +[PKService main] + 192 (PKService.m:52) 20 PlugInKit 0x000000022ba7f848 +[PKService _defaultRun:arguments:] + 20 (PKService.m:148) 21 Foundation 0x0000000226a486bc NSExtensionMain + 22 libdyld.dylib 0x00000002258eebb4 start +
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6ae6b355ea362987dd64cfb23117cae2696e0a2 commit a6ae6b355ea362987dd64cfb23117cae2696e0a2 Author: Olivier Robin <olivierrobin@chromium.org> Date: Mon Dec 03 16:48:16 2018 Fix casts in share extension. Use ObjCCast instead of static_cast. Bug: 911136 Change-Id: I48b64dac72a4fea977ff86cf9d490659f2625476 Reviewed-on: https://chromium-review.googlesource.com/c/1358448 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613122} [modify] https://crrev.com/a6ae6b355ea362987dd64cfb23117cae2696e0a2/ios/chrome/share_extension/share_view_controller.mm
,
Dec 3
Does the fix in comment 2 complete the fix?
,
Dec 4
I hope so. I could not reproduce, but this should work better anyway. I will check the crash signature when it is released. |
|||
►
Sign in to add a comment |
|||
Comment 1 by olivierrobin@chromium.org
, Dec 3Status: Assigned (was: Untriaged)