New issue
Advanced search Search tips

Issue 911100 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task



Sign in to add a comment

Add EG tests for omnibox shortcuts

Project Member Reported by stkhapugin@chromium.org, Dec 3

Issue description

subj
 
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8c044fa0126c742fbd4ffcd51be0c9105c8fab4

commit d8c044fa0126c742fbd4ffcd51be0c9105c8fab4
Author: Stepan Khapugin <stkhapugin@chromium.org>
Date: Tue Dec 04 14:39:04 2018

Adds EG test coverage for Shortcuts.

This CL introduces a few changes to test utils and to Shortcuts feature
to allow for writing EG tests:
- Initializes shortcuts VC and Coordinator later, to allow flag change
in runtime.
- Makes -focusOmniboxAndType: accept an empty string argument

It also implements EG tests for the Shortcuts feature.

Bug:  911100 
Change-Id: I9473a3570fbf1594fc94210af27a1b3c8714e4a4
Reviewed-on: https://chromium-review.googlesource.com/c/1344092
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613543}
[modify] https://crrev.com/d8c044fa0126c742fbd4ffcd51be0c9105c8fab4/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm
[modify] https://crrev.com/d8c044fa0126c742fbd4ffcd51be0c9105c8fab4/ios/chrome/browser/ui/omnibox/popup/shortcuts/BUILD.gn
[add] https://crrev.com/d8c044fa0126c742fbd4ffcd51be0c9105c8fab4/ios/chrome/browser/ui/omnibox/popup/shortcuts/shortcuts_egtest.mm
[modify] https://crrev.com/d8c044fa0126c742fbd4ffcd51be0c9105c8fab4/ios/chrome/browser/ui/omnibox/popup/shortcuts/shortcuts_mediator.mm
[modify] https://crrev.com/d8c044fa0126c742fbd4ffcd51be0c9105c8fab4/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/d8c044fa0126c742fbd4ffcd51be0c9105c8fab4/ios/chrome/test/earl_grey/chrome_earl_grey_ui.h
[modify] https://crrev.com/d8c044fa0126c742fbd4ffcd51be0c9105c8fab4/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm

Labels: Merge-Request-72
Status: Fixed (was: Assigned)
Requesting merge for these EGTests. Nothing to verify, since it's just EGTests. 
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 6

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 6

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34f56312a779c7ac6693628b90cad2b28b0ff2c8

commit 34f56312a779c7ac6693628b90cad2b28b0ff2c8
Author: Stepan Khapugin <stkhapugin@chromium.org>
Date: Thu Dec 06 14:47:37 2018

Adds EG test coverage for Shortcuts.

This CL introduces a few changes to test utils and to Shortcuts feature
to allow for writing EG tests:
- Initializes shortcuts VC and Coordinator later, to allow flag change
in runtime.
- Makes -focusOmniboxAndType: accept an empty string argument

It also implements EG tests for the Shortcuts feature.

Bug:  911100 
Change-Id: I9473a3570fbf1594fc94210af27a1b3c8714e4a4
Reviewed-on: https://chromium-review.googlesource.com/c/1344092
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613543}(cherry picked from commit d8c044fa0126c742fbd4ffcd51be0c9105c8fab4)
Reviewed-on: https://chromium-review.googlesource.com/c/1365592
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#108}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/34f56312a779c7ac6693628b90cad2b28b0ff2c8/ios/chrome/browser/ui/omnibox/popup/omnibox_popup_coordinator.mm
[modify] https://crrev.com/34f56312a779c7ac6693628b90cad2b28b0ff2c8/ios/chrome/browser/ui/omnibox/popup/shortcuts/BUILD.gn
[add] https://crrev.com/34f56312a779c7ac6693628b90cad2b28b0ff2c8/ios/chrome/browser/ui/omnibox/popup/shortcuts/shortcuts_egtest.mm
[modify] https://crrev.com/34f56312a779c7ac6693628b90cad2b28b0ff2c8/ios/chrome/browser/ui/omnibox/popup/shortcuts/shortcuts_mediator.mm
[modify] https://crrev.com/34f56312a779c7ac6693628b90cad2b28b0ff2c8/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/34f56312a779c7ac6693628b90cad2b28b0ff2c8/ios/chrome/test/earl_grey/chrome_earl_grey_ui.h
[modify] https://crrev.com/34f56312a779c7ac6693628b90cad2b28b0ff2c8/ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/34f56312a779c7ac6693628b90cad2b28b0ff2c8

Commit: 34f56312a779c7ac6693628b90cad2b28b0ff2c8
Author: stkhapugin@chromium.org
Commiter: stkhapugin@chromium.org
Date: 2018-12-06 14:47:37 +0000 UTC

Adds EG test coverage for Shortcuts.

This CL introduces a few changes to test utils and to Shortcuts feature
to allow for writing EG tests:
- Initializes shortcuts VC and Coordinator later, to allow flag change
in runtime.
- Makes -focusOmniboxAndType: accept an empty string argument

It also implements EG tests for the Shortcuts feature.

Bug:  911100 
Change-Id: I9473a3570fbf1594fc94210af27a1b3c8714e4a4
Reviewed-on: https://chromium-review.googlesource.com/c/1344092
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613543}(cherry picked from commit d8c044fa0126c742fbd4ffcd51be0c9105c8fab4)
Reviewed-on: https://chromium-review.googlesource.com/c/1365592
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#108}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment