New issue
Advanced search Search tips

Issue 911096 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 877018


Previous locations:
webrtc:10086


Sign in to add a comment

Chromium perf dashboard build links are broken

Reported by ilnik@webrtc.org, Dec 3

Issue description

The webrtc git hash links on ChromiumWebRTC/chromium-webrtc-rel-mac/browser_tests graph are broken.

See e.g. here:

https://chromeperf.appspot.com/report?sid=022666fb6a97c46bb5f10fa2cc7eda2f42a711f41bc30628ebf47fc0069afff4




 
Status: Available (was: Assigned)
Project: chromium
Moved issue webrtc:10086 to now be issue chromium:911096.
Blocking: 877018
Cc: oprypin@chromium.org
Components: Infra>Client>WebRTC
Labels: -OS-All -Breaks-Bot
Owner: ----
Status: Available (was: Assigned)
I think the link might be actually not broken. It's just saying that there haven't been any WebRTC commits between the two points (and that's legit because they are triggered on Chromium commits).

The buildbot links are certainly broken though.
Summary: Chromium perf dashboard build links are broken (was: Chromium perf dashboard source links are broken)
Let me hijack the issue to talk about links to builds then
This is the broken link that it produces:
http://build.chromium.org/p/chromium/builders/WebRTC%20Chromium%20Mac%20Tester/builds/33
So first off, this is a Buildbot link, which it shouldn't be, but it would still work if only that part said /p/chromium.webrtc/

And I think this might be the code responsible for it:
https://cs.chromium.org/search/?q=MakeHistogramSetWithDiagnostics%5C(+_GetBuildBotUrl&sq=package:chromium&type=cs

And I see, it's because previously it was getting the BUILDBOT_URL variable:
https://logs.chromium.org/logs/chromium/bb/chromium.webrtc/Mac_Tester/85873/+/recipes/steps/browser_tests/0/stdout
but now it falls back to 'chromium':
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8928151111870241744/+/steps/browser_tests/0/stdout

So, we might find a hack to set that variable back, or fix it properly.

jbudorick@, maybe you can give a hint in which direction to dig?
Cc: jbudorick@chromium.org

Sign in to add a comment