New issue
Advanced search Search tips

Issue 911095 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 899586



Sign in to add a comment

Migrate video_VideoDecodeAccelerator to Tast

Project Member Reported by keiichiw@chromium.org, Dec 3

Issue description

video_VideoDecodeAccelerator [1] is a video test which runs a binary unittest[2] on DUT.
We migrate this to a new test framework, Tast.

[1] https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/client/site_tests/video_VideoDecodeAccelerator/
[2] https://cs.chromium.org/chromium/src/media/gpu/video_decode_accelerator_unittest.cc

 
Our video team is planning to replace video_decode_accelerator_unittest with Test video player developed at Issue 879065. 
But, the development of the test video player is still at very early stage.
So, until test video player get enough functionalities, we keep using video_decode_accelerator_unittest.
Cc: deanliao@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d059ff40ac0c67da87f8d277d83e34a88be99268

commit d059ff40ac0c67da87f8d277d83e34a88be99268
Author: Keiichi Watanabe <keiichiw@chromium.org>
Date: Tue Dec 04 19:06:16 2018

tast-local-tests-cros: Add test video files for video.DecodeAccel*

Copied test video files from src/media/test/data/ at Chromium repository.

Add:
146.63 KiB test-25fps_20181203.h264
249.73 KiB test-25fps_20181203.vp8
 86.03 KiB test-25fps_20181203.vp9
 97.97 KiB test-25fps_20181203.vp9_2

Also, lines for unused files in Manifest are removed by ebuild.

BUG= chromium:911095 
TEST=tast run eve video.DecodeAccel* with CL:1358294

Change-Id: Ie565f1ac9c4c16b065905d69c42a107ac4f1f790
Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1356930
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/d059ff40ac0c67da87f8d277d83e34a88be99268/chromeos-base/tast-local-tests-cros/tast-local-tests-cros-9999.ebuild
[modify] https://crrev.com/d059ff40ac0c67da87f8d277d83e34a88be99268/chromeos-base/tast-local-tests-cros/Manifest
[modify] https://crrev.com/d059ff40ac0c67da87f8d277d83e34a88be99268/chromeos-base/tast-local-tests-cros/files/external_data.conf

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/7b8d7af495cde14b1a333223ef327fb3b37d16fa

commit 7b8d7af495cde14b1a333223ef327fb3b37d16fa
Author: Keiichi Watanabe <keiichiw@chromium.org>
Date: Tue Dec 04 22:00:06 2018

video: Add DecodeAccel(VP*|H264)* tests

Add video.DecodeAccel(VP*|H264)* tests, which are Tast version of
video_VideoDecodeAccelerator*, which run Chrome's binary test
"video_decode_accelerator_unittest".
There are 2 tests for each codec; H264, VP8, VP9, VP9.2.
md5 files came from /src/media/test/data/ at Chromium repository.

BUG= chromium:911095 
TEST=tast run eve video.DecodeAccel*
CQ-DEPEND=CL:1356930

Change-Id: I811bd8bf75a9094ad68a72a5d33008fd6dec6d5e
Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1358294

[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/data/test-25fps.vp8.frames.md5
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/decode/test_cases.go
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp8_import.go
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/data/test-25fps.h264.frames.md5
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/decode_accel_h264.go
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/decode/accel_video.go
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp9.go
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/data/test-25fps.vp9.md5
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp92_import.go
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp9_import.go
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/data/test-25fps.vp8.md5
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp8.go
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/data/test-25fps.h264.md5
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/decode_accel_h264_import.go
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/data/test-25fps.vp9_2.md5
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/data/test-25fps.vp9_2.frames.md5
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp92.go
[add] https://crrev.com/7b8d7af495cde14b1a333223ef327fb3b37d16fa/src/chromiumos/tast/local/bundles/cros/video/data/test-25fps.vp9.frames.md5

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/713594ecf09d26b21f9042e8813fbfbef281a629

commit 713594ecf09d26b21f9042e8813fbfbef281a629
Author: Keiichi Watanabe <keiichiw@chromium.org>
Date: Sat Dec 08 16:44:04 2018

video.DecodeAccel*Import: Don't run on devices where Android is unavailable

video_accelerator_unittests fails with IMPORT mode on some devices where
Android is not supported because of hardware limitations, drivers' problems
and so on. See  crbug.com/881729  for the detailed reasons.
So, we don't run the test on such devices with IMPORT mode.

BUG= chromium:911095 
TEST=fast_build.sh -C

Change-Id: Id500e741a7e26f10de474312573d897b0216c83a
Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1367076
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/713594ecf09d26b21f9042e8813fbfbef281a629/src/chromiumos/tast/local/bundles/cros/video/decode_accel_h264_import.go
[modify] https://crrev.com/713594ecf09d26b21f9042e8813fbfbef281a629/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp8_import.go
[modify] https://crrev.com/713594ecf09d26b21f9042e8813fbfbef281a629/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp92_import.go
[modify] https://crrev.com/713594ecf09d26b21f9042e8813fbfbef281a629/src/chromiumos/tast/local/bundles/cros/video/decode_accel_vp9_import.go

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/6535df87b3aa9ca4a988b336d24e522eb66af030

commit 6535df87b3aa9ca4a988b336d24e522eb66af030
Author: Alexandre Courbot <acourbot@chromium.org>
Date: Tue Dec 18 12:28:58 2018

tast-tests: video: fix style of test HTML file

The video.html file used to test videos was not correctly indented and
used some Javascript features that are against our coding guidelines
(https://google.github.io/styleguide/jsguide.html)

Fix this, while also removing the unused script_ready variable and not
forcing the video element to a fixed size.

BUG= chromium:911095 
TEST=Checked that video.PlayDecodeAccelUsedH264 was running and passing
on Hana.

Change-Id: I1086f8706e17c722c9317abd8dd7ac3668b4b052
Reviewed-on: https://chromium-review.googlesource.com/1381594
Commit-Ready: Alexandre Courbot <acourbot@chromium.org>
Tested-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Keiichi Watanabe <keiichiw@chromium.org>

[modify] https://crrev.com/6535df87b3aa9ca4a988b336d24e522eb66af030/src/chromiumos/tast/local/bundles/cros/video/data/video.html

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/6a169c20485294fdeb32472b9b103d9cbbe0d5c1

commit 6a169c20485294fdeb32472b9b103d9cbbe0d5c1
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Sat Dec 29 00:14:04 2018

video: Add functions to Mute/Unmute not to make a sound during testing

Videos in some tests has an audio. It doesn't matter whether DUT sounds or not.
It is convenient for developers that test automatically makes DUT mute during
the test.
Note that it matters that chrome processes for sound, because not only we want
to measure metrics in chrome standard video playback but also chrome video
playback behavior is changed by the existence of sound in the video.

BUG= chromium:890733 ,  chromium:911095 
TEST=tast run video.Play*

Change-Id: Ibe4895c1cfc6991beaf5672724bb8c9bf15f194c
Reviewed-on: https://chromium-review.googlesource.com/1390677
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[add] https://crrev.com/6a169c20485294fdeb32472b9b103d9cbbe0d5c1/src/chromiumos/tast/local/bundles/cros/video/lib/audio/audio.go
[modify] https://crrev.com/6a169c20485294fdeb32472b9b103d9cbbe0d5c1/src/chromiumos/tast/local/bundles/cros/video/playback/playback.go
[modify] https://crrev.com/6a169c20485294fdeb32472b9b103d9cbbe0d5c1/src/chromiumos/tast/local/bundles/cros/video/play/play.go

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8

commit c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8
Author: Alexandre Courbot <acourbot@chromium.org>
Date: Fri Jan 11 07:22:55 2019

tast-tests: video: port video_VideoSeek.* to Tast

This adds the Seek (100 seeks while playing a video) and SeekSwitch (100
seeks while playing a video with resolution changes) tests for H264, VP8
and VP9. This is basically a port of the existing video_VideoSeek.*
autotests.

BUG= chromium:911095 
TEST=tast run hana video.Seek*

Change-Id: Idcce8dfc01eb3ffb423b65e9f531e4a668fe5583
Reviewed-on: https://chromium-review.googlesource.com/1377758
Commit-Ready: Alexandre Courbot <acourbot@chromium.org>
Tested-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[add] https://crrev.com/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8/src/chromiumos/tast/local/bundles/cros/video/seek_vp8.go
[add] https://crrev.com/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8/src/chromiumos/tast/local/bundles/cros/video/seek_h264.go
[add] https://crrev.com/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8/src/chromiumos/tast/local/bundles/cros/video/seek_switch_h264.go
[add] https://crrev.com/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8/src/chromiumos/tast/local/bundles/cros/video/seek_switch_vp8.go
[add] https://crrev.com/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8/src/chromiumos/tast/local/bundles/cros/video/seek_vp9.go
[modify] https://crrev.com/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8/src/chromiumos/tast/local/bundles/cros/video/play/play.go
[add] https://crrev.com/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8/src/chromiumos/tast/local/bundles/cros/video/data/video_seek.webm.external
[add] https://crrev.com/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8/src/chromiumos/tast/local/bundles/cros/video/data/video_seek.mp4.external
[add] https://crrev.com/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8/src/chromiumos/tast/local/bundles/cros/video/data/frame_size_change.webm.external
[add] https://crrev.com/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8/src/chromiumos/tast/local/bundles/cros/video/data/shaka_720.webm.external
[modify] https://crrev.com/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8/src/chromiumos/tast/local/bundles/cros/video/data/video.html
[add] https://crrev.com/c39c4c1bf9b9d9d8571c0e9ec1de9444250221f8/src/chromiumos/tast/local/bundles/cros/video/data/switch_1080p_720p.mp4.external

Sign in to add a comment