Issue metadata
Sign in to add a comment
|
Using dynamic text, text overlaps on choosing options from voice search and import data screens |
||||||||||||||||||||||||
Issue descriptionApp Version: 72.0.3626.0 Canary iOS Version: 10.3.3, 11.4.1, 12.1.1 beta#3 Device: iPhone and iPad Prerequisite: 1. Go the device Settings>>General>>Accessibility>>Larger Text>>Drag the slider to maximum 2. Add multiple google Accounts in chrome Steps to reproduce: 1. Set the device settings as mentioned in prerequisite 2. Launch chrome and sign in to chrome 3. Go to Settings>Voice Search 4. Tap on the options having long text (ex. Bahasa Malaysia, English(United States)) 5. Go to Settings>>Sign in Account>>Sync>>Tap on any other account 6. Tap on Combine my account option Observed results: At step 4 & 6, notice that selected options text overlaps with the horizontal separator line. Expected results: Text shouldn’t overlap Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Chrome Desktop: NA Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): NA on M70 (Dynamic type is supported for above settings panel from M72) Bug reproducible on the current beta channel build (App Version, iOS Version): NA on M71 Beta (Dynamic type is supported for above settings panel from M72) Link to Video: https://drive.google.com/file/d/14-PmzP32o8x6jv-gH5MaSJ-g6E2gjjtq/view?usp=sharing
,
Dec 4
,
Dec 4
,
Dec 4
Can you specify what you mean by "form voice search" in the issue's summary?
,
Dec 4
Sorry wrong typo it is "from voice search" not "form voice search". Updated the summary.
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4194f40046b2f6f7cee5ba93b3cbd533a5631971 commit 4194f40046b2f6f7cee5ba93b3cbd533a5631971 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Dec 07 11:36:44 2018 [iOS] Fix multiline labels when selected This CL fixes the way the multilines labels are handling the accessory view. Instead of getting resized when the accessory is added to the view, they have a width taking into account the accessory view. Bug: 911088 Change-Id: I153a0939600ca89d7f27c80ab411c287c6408398 Reviewed-on: https://chromium-review.googlesource.com/c/1363192 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#614667} [modify] https://crrev.com/4194f40046b2f6f7cee5ba93b3cbd533a5631971/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item.h [modify] https://crrev.com/4194f40046b2f6f7cee5ba93b3cbd533a5631971/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item.mm [modify] https://crrev.com/4194f40046b2f6f7cee5ba93b3cbd533a5631971/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item_unittest.mm
,
Dec 7
,
Dec 8
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c4a5f31417365904c58a0e79ea62ca96da9f8b6 commit 7c4a5f31417365904c58a0e79ea62ca96da9f8b6 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Dec 10 08:48:52 2018 [iOS] Fix multiline labels when selected This CL fixes the way the multilines labels are handling the accessory view. Instead of getting resized when the accessory is added to the view, they have a width taking into account the accessory view. Bug: 911088 Change-Id: I153a0939600ca89d7f27c80ab411c287c6408398 Reviewed-on: https://chromium-review.googlesource.com/c/1363192 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614667}(cherry picked from commit 4194f40046b2f6f7cee5ba93b3cbd533a5631971) Reviewed-on: https://chromium-review.googlesource.com/c/1369924 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#176} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/7c4a5f31417365904c58a0e79ea62ca96da9f8b6/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item.h [modify] https://crrev.com/7c4a5f31417365904c58a0e79ea62ca96da9f8b6/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item.mm [modify] https://crrev.com/7c4a5f31417365904c58a0e79ea62ca96da9f8b6/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item_unittest.mm
,
Dec 11
Tested on 73.0.3637.0 Canary, iPhoneXR iOS 12.1.1 Issue still repro on voice search https://drive.google.com/file/d/1i3b05EQNNZ0twAkroY5IGx2YgVRHW5Ur/view
,
Dec 11
,
Dec 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8891b1a2d89aaabdedd9ea8c46b14f80ba2e9f36 commit 8891b1a2d89aaabdedd9ea8c46b14f80ba2e9f36 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Dec 17 13:43:31 2018 [iOS] Change VoiceSearch multiline labels This CL makes sure that the VoiceSearch multiline labels are taking into account the fact that an accessory view could be displayed at the end of the line. The line wrapping is done such as the presence of the accessory view doesn't change anything. It also moves the constant used for the width of the accessory view to a shared file. Bug: 911088 Change-Id: I845ee59b6dfa2165cce2f2e7672c1deaa7f18845 Reviewed-on: https://chromium-review.googlesource.com/c/1377439 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#617106} [modify] https://crrev.com/8891b1a2d89aaabdedd9ea8c46b14f80ba2e9f36/ios/chrome/browser/ui/settings/cells/import_data_multiline_detail_item.mm [modify] https://crrev.com/8891b1a2d89aaabdedd9ea8c46b14f80ba2e9f36/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h [modify] https://crrev.com/8891b1a2d89aaabdedd9ea8c46b14f80ba2e9f36/ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.mm [modify] https://crrev.com/8891b1a2d89aaabdedd9ea8c46b14f80ba2e9f36/ios/chrome/browser/ui/table_view/cells/table_view_detail_text_item.mm
,
Dec 17
Merge request for the new patch.
,
Dec 17
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 17
Canary verification please.
,
Dec 18
Verified in Build version:73.0.3644.0 Canary Device info: iPhone X(iOS 12.0.1), iPad Mini(iOS 11.4.1) on using dynamic text, text doesn't overlaps on choosing options from voice search and import data screens Link to video: https://drive.google.com/file/d/1AlEPVsbCYIsd41wiz1AMG44yokym-8TK/view?usp=sharing
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c4a5f31417365904c58a0e79ea62ca96da9f8b6 Commit: 7c4a5f31417365904c58a0e79ea62ca96da9f8b6 Author: gambard@chromium.org Commiter: gambard@chromium.org Date: 2018-12-10 08:48:52 +0000 UTC [iOS] Fix multiline labels when selected This CL fixes the way the multilines labels are handling the accessory view. Instead of getting resized when the accessory is added to the view, they have a width taking into account the accessory view. Bug: 911088 Change-Id: I153a0939600ca89d7f27c80ab411c287c6408398 Reviewed-on: https://chromium-review.googlesource.com/c/1363192 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614667}(cherry picked from commit 4194f40046b2f6f7cee5ba93b3cbd533a5631971) Reviewed-on: https://chromium-review.googlesource.com/c/1369924 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#176} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 3
gambard: It seems the second merge request here was merged without approval. I see you removed all the labels for the first merge request, but please wait for another approval before merging any subsequent CL. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pkl@chromium.org
, Dec 3Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)