New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment
link

Issue 911062: Regression : Media controls flicker when trying to slide volume slider through keyboard shortcut.

Reported by sav...@virtusa.com, Dec 3 Project Member

Issue description

Chrome Version : 71.0.3578.80 (Official Build) 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860} 32/64 bit
OS : Mac(10.13.6, 10.13.1, 10.14.2), Windows(7,8,10), Linux(14.04 LTS)

Test URL : https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html

What steps will reproduce the problem?
1. Launch chrome, navigate to above test URL and set video 'Width' to "250".
2. Play the video, press 'TAB' key to bring focus on volume slider and press 'Left Arrow' key from keyboard to decrease the slider. 
3. Observe.

Actual Result : Media controls flicker when trying to slide volume slider through keyboard shortcuts.

Expected Result : Media controls should not flicker when increasing/decreasing volume slider through keyboard.

This is a regression issue broken in M-71 and below is the bisect information:
Good Build : 71.0.3573.0 (Revision : 597470)
Bad Build : 71.0.3574.0 (Revision : 597692)

Change-Log URL:
https://chromium.googlesource.com/chromium/src/+log/a544ca69f57da786d866979a634aeb509c8549ca..16d3504ad4ade83588f086c8befccd3d04b73ae3

Suspect: https://chromium.googlesource.com/chromium/src/+/16d3504ad4ade83588f086c8befccd3d04b73ae3

@steimel: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Issue is reproducible in Dev #72.0.3622.0 and Canary build #72.0.3629.0

Thank you..!
 
Actual_Media.mov
9.8 MB View Download
Expected_Media.mov
4.6 MB View Download

Comment 1 by steimel@chromium.org, Dec 3

Cc: steimel@chromium.org mlamouri@chromium.org
Owner: jazzhsu@chromium.org

Comment 2 by jazzhsu@chromium.org, Dec 3

Status: Started (was: Assigned)

Comment 3 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fd190dee907661320a5bfc5963d615406fffd35

commit 3fd190dee907661320a5bfc5963d615406fffd35
Author: Jazz Xu <jazzhsu@chromium.org>
Date: Fri Dec 07 01:25:11 2018

[Media Controls] Fix controls flicker in small size

This CL fixed control layout in small video size by
adding an estimated width of time display element which
was default to 0 when its hidden.

Bug:  911062 
Change-Id: I747e465e87fd27eec1ac5ad4720fa79525443f04
Reviewed-on: https://chromium-review.googlesource.com/c/1358647
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614555}
[modify] https://crrev.com/3fd190dee907661320a5bfc5963d615406fffd35/third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc
[modify] https://crrev.com/3fd190dee907661320a5bfc5963d615406fffd35/third_party/blink/renderer/modules/media_controls/elements/media_control_remaining_time_display_element.cc
[modify] https://crrev.com/3fd190dee907661320a5bfc5963d615406fffd35/third_party/blink/renderer/modules/media_controls/elements/media_control_remaining_time_display_element.h
[modify] https://crrev.com/3fd190dee907661320a5bfc5963d615406fffd35/third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.cc
[modify] https://crrev.com/3fd190dee907661320a5bfc5963d615406fffd35/third_party/blink/renderer/modules/media_controls/elements/media_control_time_display_element.h
[add] https://crrev.com/3fd190dee907661320a5bfc5963d615406fffd35/third_party/blink/web_tests/media/controls/controls-layout-in-different-size.html

Comment 4 by jazzhsu@chromium.org, Dec 7

Status: Fixed (was: Started)

Sign in to add a comment