New issue
Advanced search Search tips

Issue 911056 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Reenable Integration tests for the Passwords Accessory

Project Member Reported by fhorschig@chromium.org, Dec 3

Issue description

The keyboard accessory integration tests for the passwords sheet (and the  autofill suggestions) were disabled due to flakiness.

The main cause of flakiness (the keyboard being unreliable and slow) has been addressed but the tests' flag annotations have to be updated and their expectations should be verified.
 
Labels: -mfill-pe mfill-ch
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a0fe0d295dd581c1d5d24b9e370f41cded4fe7e

commit 1a0fe0d295dd581c1d5d24b9e370f41cded4fe7e
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Mon Dec 03 15:41:11 2018

[Mfill Android] Reenable Password integration tests

This CL reenables the first set of integrations tests whose flakiness
should be resolved since the FakeKeyboard replaces the flaky, emulated
soft keyboard.

Bug: 911056
Change-Id: I096fb08df3b76f7c07bdd819f7c66f2eee099417
Reviewed-on: https://chromium-review.googlesource.com/c/1358433
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613094}
[modify] https://crrev.com/1a0fe0d295dd581c1d5d24b9e370f41cded4fe7e/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryIntegrationTest.java
[modify] https://crrev.com/1a0fe0d295dd581c1d5d24b9e370f41cded4fe7e/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java

Sign in to add a comment