New issue
Advanced search Search tips

Issue 911040 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Provide a way to reset the dino game high score

Project Member Reported by dullweber@chromium.org, Dec 3

Issue description

The dino game high score is stored in a synced preference, which makes it almost impossible to reset if desired.

Please provide some way of resetting the highscore from the dino page.
 
Labels: -Type-Bug OS-Android Type-Feature
Cc: -edwardjung@chromium.org eseckler@chromium.org
Owner: edwardjung@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef27d52f65163eb0c3193546039462a7e20d4d55

commit ef27d52f65163eb0c3193546039462a7e20d4d55
Author: Eric Seckler <eseckler@chromium.org>
Date: Tue Dec 04 14:45:58 2018

network error: Add infrastructure to clear easter egg high score

Adds mojo + JS infrastructure to clear the dino game high score.
UI to be added by edwardjung@ later.

Bug:  568093 , 911040
Change-Id: If9fc99a3fe3b262c4e4671b3a534b6726d6dcd3e
Reviewed-on: https://chromium-review.googlesource.com/c/1358501
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613546}
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/browser/net/net_error_tab_helper.cc
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/browser/net/net_error_tab_helper.h
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/common/network_easter_egg.mojom
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/renderer/net/net_error_helper.h
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/renderer/net/net_error_page_controller.cc
[modify] https://crrev.com/ef27d52f65163eb0c3193546039462a7e20d4d55/chrome/renderer/net/net_error_page_controller.h

Status: Started (was: Assigned)
Planned design for this:
Clicking on the high score on the game over screen flashes the score. During that time you can tap again to reset. The flashing stops out after 6 times.
reset-highscore.mov
996 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9d1d90d18d9245e67a69985537f5d67eb2f9407

commit d9d1d90d18d9245e67a69985537f5d67eb2f9407
Author: Edward Jung <edwardjung@chromium.org>
Date: Wed Dec 19 10:28:19 2018

Allow clearing of offline dino high score by clicking on it twice

Bug: 911040
Change-Id: I6378d218b603d73f6d2a06ab27e81db7ae12750d
Reviewed-on: https://chromium-review.googlesource.com/c/1380054
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Edward Jung <edwardjung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617786}
[modify] https://crrev.com/d9d1d90d18d9245e67a69985537f5d67eb2f9407/components/neterror/resources/offline.js

Cc: phanindra.mandapaka@chromium.org
Labels: TE-Verified-M73 TE-Verified-73.0.3646.0
Able to reproduce this issue on Windows 10, Mac OS 10.14.0 and Ubuntu 17.10 on the reported version 72.0.3625.0 and the issue is fixed on the latest M-73 build 73.0.3646.0.

1. Launched Chrome 
2. Opened dino game
3. Started playing and clicked on high score when game over> observed blinking and while blinking clicked on high score > observed score is rested 
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as expected.

Thanks..!
911040.mp4
561 KB View Download

Sign in to add a comment