New issue
Advanced search Search tips

Issue 911038 link

Starred by 3 users
Status: Fixed
Owner:
qnnguyen@chromium.org
Closed: Dec 13
Cc:
ajha@chromium.org
zalcorn@chromium.org
alemate@chromium.org
wzang@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessary 'Browse as Guest' option is seen in second user 'You are Signed in !' screen

Project Member Reported by mmanchala@chromium.org, Dec 3 
Chrome Version: 73.0.3628.0/11332.0.0 dev channel Kip,Reks and Daisy
OS: Chrome

Pre-Condition : Sign into one User

What steps will reproduce the problem?
(1)In Sign out screen -> Click on 'Add Person' -> Sign in screen is seen
(2)Enter Valid Email Id and Password -> click 'Next' button -> 'Please wait...' screen is seen -> now after 3-4 sec observe unnecessary 'Browse as Guest' option and on clicking nothing happens
(Please refer Video and Screenshot)

Expected:  Unnecessary 'Browse as Guest' option should not be seen
Actual: Instead  unnecessary 'Browse as Guest' option and on clicking nothing happens

This is Regression Issue as same is working fine on M-69

Note : Issue is also seen on M-70,M-71 and N-72
Actual_UnnecessaryBrowseAsGuestOption.mp4
14.8 MB View Download
Actual_UnnecessaryBrowseAsGuestOption.jpg
315 KB View Download
Expected_NoOption.jpg
314 KB View Download

Comment 1 by jdufault@chromium.org, Dec 3

Owner: qnnguyen@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by jdufault@chromium.org, Dec 3

Components: -UI>SignIn UI>Shell>StartScreen

Comment 3 by qnnguyen@chromium.org, Dec 10 

Issue 901149 has been merged into this issue.

Comment 4 by abod...@chromium.org, Dec 12

Labels: M-72
Reproduced on M72(ChromeOS:11316.18.0/72.0.3626.15) too
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea6644de938ffcd0011cdeb495aa4c45082928b4

commit ea6644de938ffcd0011cdeb495aa4c45082928b4
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Thu Dec 13 01:20:45 2018

cros: Don't show Guest button during sync consent

This change involves exposing another OOBE state to views. For now,
it is piped through login-header-bar like the other states. We can
migrate this to using display_manager.js directly in the future.

Bug:  911038 
Change-Id: I30013cf0c27b6a8691b09bdcfa0dae1709c36e2b
Reviewed-on: https://chromium-review.googlesource.com/c/1370911
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616144}
[modify] https://crrev.com/ea6644de938ffcd0011cdeb495aa4c45082928b4/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/ea6644de938ffcd0011cdeb495aa4c45082928b4/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/ea6644de938ffcd0011cdeb495aa4c45082928b4/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/ea6644de938ffcd0011cdeb495aa4c45082928b4/chrome/browser/resources/chromeos/login/screen_sync_consent.js
[modify] https://crrev.com/ea6644de938ffcd0011cdeb495aa4c45082928b4/ui/login/display_manager.js

Comment 6 by qnnguyen@chromium.org, Dec 13

Status: Fixed (was: Assigned)
This should no longer be an issue -- marking as fixed + wait for verification
►

Sign in to add a comment