https://docs.google.com/document/d/1rW9-NkJFTTHx-UlfkPrxtEVr6qqajKl1PgeucigC5y0/edit?ts=5bf2d92a# Currently the logic lives in WebURLLoaderImpl, but we are going to remove the logic. Hence we will move it to blink::FetchManager.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8febfeb0c584adda674a8bc382787f3a53e874f0 commit 8febfeb0c584adda674a8bc382787f3a53e874f0 Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Dec 11 06:49:10 2018 Use OnceClosure in SharedMemoryDataConsumerHandle Bug: 911036 Change-Id: I1096638e46760674d9c9a85522f775f767f0faa1 Reviewed-on: https://chromium-review.googlesource.com/c/1370234 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#615450} [modify] https://crrev.com/8febfeb0c584adda674a8bc382787f3a53e874f0/content/renderer/loader/shared_memory_data_consumer_handle.cc [modify] https://crrev.com/8febfeb0c584adda674a8bc382787f3a53e874f0/content/renderer/loader/shared_memory_data_consumer_handle.h [modify] https://crrev.com/8febfeb0c584adda674a8bc382787f3a53e874f0/content/renderer/loader/shared_memory_data_consumer_handle_unittest.cc [modify] https://crrev.com/8febfeb0c584adda674a8bc382787f3a53e874f0/content/renderer/loader/web_url_loader_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6e3a8ef841fb55a74f0b67edbf22cf6f2cce5cc commit b6e3a8ef841fb55a74f0b67edbf22cf6f2cce5cc Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Dec 18 08:27:25 2018 Enter ScriptState::Scope for WASM streaming Bug: 911036 Change-Id: I94352cfeada80f9f9cb9b3002d093698f1ab4e3f Reviewed-on: https://chromium-review.googlesource.com/c/1381362 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#617411} [modify] https://crrev.com/b6e3a8ef841fb55a74f0b67edbf22cf6f2cce5cc/third_party/blink/renderer/bindings/core/v8/v8_wasm_response_extensions.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90070dcbb75bf7065f86f4705438380a295f2f65 commit 90070dcbb75bf7065f86f4705438380a295f2f65 Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Dec 21 03:49:00 2018 Introduce BufferingBytesConsumer The fetch spec requires us to relieve backpressure when updating the HTTPS cache. This has been implemented in content/renderer/loader as SharedMemoryDataConsumerHandle::BackpressureMode, but this CL moves the implementation to blink/renderer/core/fetch in order to deprecate WebDataConsumerHandle. Bug: 911036 Change-Id: Ia0161a7c5f1dbd17a994c11865cf035816235bb0 Reviewed-on: https://chromium-review.googlesource.com/c/1364972 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#618449} [modify] https://crrev.com/90070dcbb75bf7065f86f4705438380a295f2f65/content/renderer/loader/shared_memory_data_consumer_handle.cc [modify] https://crrev.com/90070dcbb75bf7065f86f4705438380a295f2f65/content/renderer/loader/shared_memory_data_consumer_handle.h [modify] https://crrev.com/90070dcbb75bf7065f86f4705438380a295f2f65/content/renderer/loader/shared_memory_data_consumer_handle_unittest.cc [modify] https://crrev.com/90070dcbb75bf7065f86f4705438380a295f2f65/content/renderer/loader/web_url_loader_impl.cc [modify] https://crrev.com/90070dcbb75bf7065f86f4705438380a295f2f65/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/90070dcbb75bf7065f86f4705438380a295f2f65/third_party/blink/renderer/core/fetch/BUILD.gn [add] https://crrev.com/90070dcbb75bf7065f86f4705438380a295f2f65/third_party/blink/renderer/core/fetch/buffering_bytes_consumer.cc [add] https://crrev.com/90070dcbb75bf7065f86f4705438380a295f2f65/third_party/blink/renderer/core/fetch/buffering_bytes_consumer.h [add] https://crrev.com/90070dcbb75bf7065f86f4705438380a295f2f65/third_party/blink/renderer/core/fetch/buffering_bytes_consumer_test.cc [modify] https://crrev.com/90070dcbb75bf7065f86f4705438380a295f2f65/third_party/blink/renderer/core/fetch/fetch_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83624e506109545f02ce6ce8437bd4c0d64af34f commit 83624e506109545f02ce6ce8437bd4c0d64af34f Author: Matt Falkenhagen <falken@chromium.org> Date: Wed Jan 09 05:46:41 2019 Revert "Introduce BufferingBytesConsumer" This reverts commit 90070dcbb75bf7065f86f4705438380a295f2f65. Reason for revert: Breaks loading at least one site, see https://crbug.com/920066 Original change's description: > Introduce BufferingBytesConsumer > > The fetch spec requires us to relieve backpressure when updating the > HTTPS cache. This has been implemented in content/renderer/loader as > SharedMemoryDataConsumerHandle::BackpressureMode, but this CL moves the > implementation to blink/renderer/core/fetch in order to deprecate > WebDataConsumerHandle. > > Bug: 911036 > Change-Id: Ia0161a7c5f1dbd17a994c11865cf035816235bb0 > Reviewed-on: https://chromium-review.googlesource.com/c/1364972 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618449} TBR=yhirano@chromium.org,kouhei@chromium.org,shimazu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 911036, 920066 Change-Id: I332e52a8a75936ac8dff547bd7dd76cbcd69ca5c Reviewed-on: https://chromium-review.googlesource.com/c/1401925 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#621055} [modify] https://crrev.com/83624e506109545f02ce6ce8437bd4c0d64af34f/content/renderer/loader/shared_memory_data_consumer_handle.cc [modify] https://crrev.com/83624e506109545f02ce6ce8437bd4c0d64af34f/content/renderer/loader/shared_memory_data_consumer_handle.h [modify] https://crrev.com/83624e506109545f02ce6ce8437bd4c0d64af34f/content/renderer/loader/shared_memory_data_consumer_handle_unittest.cc [modify] https://crrev.com/83624e506109545f02ce6ce8437bd4c0d64af34f/content/renderer/loader/web_url_loader_impl.cc [modify] https://crrev.com/83624e506109545f02ce6ce8437bd4c0d64af34f/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/83624e506109545f02ce6ce8437bd4c0d64af34f/third_party/blink/renderer/core/fetch/BUILD.gn [delete] https://crrev.com/91e17c7ef3afbcab7a3caa72d2c166cfc20585de/third_party/blink/renderer/core/fetch/buffering_bytes_consumer.cc [delete] https://crrev.com/91e17c7ef3afbcab7a3caa72d2c166cfc20585de/third_party/blink/renderer/core/fetch/buffering_bytes_consumer.h [delete] https://crrev.com/91e17c7ef3afbcab7a3caa72d2c166cfc20585de/third_party/blink/renderer/core/fetch/buffering_bytes_consumer_test.cc [modify] https://crrev.com/83624e506109545f02ce6ce8437bd4c0d64af34f/third_party/blink/renderer/core/fetch/fetch_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f commit bb5d29618cb9daccfa29d376f60166cbaa2f7c5f Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Jan 11 08:04:16 2019 Reland "Introduce BufferingBytesConsumer" This is a reland of commit 83624e506109545f02ce6ce8437bd4c0d64af34f. The original change was reverted because it breaks loading some sites (see https://crbug.com/920066 ). That was caused by bad implementation in BytesConsumer::Tee, so this CL fixes the bug. Original change's description: > Introduce BufferingBytesConsumer > > The fetch spec requires us to relieve backpressure when updating the > HTTPS cache. This has been implemented in content/renderer/loader as > SharedMemoryDataConsumerHandle::BackpressureMode, but this CL moves the > implementation to blink/renderer/core/fetch in order to deprecate > WebDataConsumerHandle. > > Bug: 911036 > Change-Id: Ia0161a7c5f1dbd17a994c11865cf035816235bb0 > Reviewed-on: https://chromium-review.googlesource.com/c/1364972 > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618449} Bug: 911036 Change-Id: I912b84d5934a6f14c9295a2512a720c8464beeef Reviewed-on: https://chromium-review.googlesource.com/c/1404894 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#621944} [modify] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/content/renderer/loader/shared_memory_data_consumer_handle.cc [modify] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/content/renderer/loader/shared_memory_data_consumer_handle.h [modify] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/content/renderer/loader/shared_memory_data_consumer_handle_unittest.cc [modify] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/content/renderer/loader/web_url_loader_impl.cc [modify] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/third_party/blink/renderer/core/BUILD.gn [modify] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/third_party/blink/renderer/core/fetch/BUILD.gn [add] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/third_party/blink/renderer/core/fetch/buffering_bytes_consumer.cc [add] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/third_party/blink/renderer/core/fetch/buffering_bytes_consumer.h [add] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/third_party/blink/renderer/core/fetch/buffering_bytes_consumer_test.cc [modify] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/third_party/blink/renderer/core/fetch/bytes_consumer.cc [modify] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/third_party/blink/renderer/core/fetch/bytes_consumer_test.cc [modify] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/third_party/blink/renderer/core/fetch/bytes_consumer_test_util.cc [modify] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/third_party/blink/renderer/core/fetch/bytes_consumer_test_util.h [modify] https://crrev.com/bb5d29618cb9daccfa29d376f60166cbaa2f7c5f/third_party/blink/renderer/core/fetch/fetch_manager.cc
Comment 1 by bugdroid1@chromium.org
, Dec 11