Test PlatformAppBrowserTest.TouchpadPinchSyntheticWheelEvents is flaky on mac
Reported by
ganenk...@yandex-team.ru,
Dec 3
|
|
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 YaBrowser/18.7.1.177 Yowser/2.5 Safari/537.36 Steps to reproduce the problem: 1. Run PlatformAppBrowserTest.TouchpadPinchSyntheticWheelEvents on mac What is the expected behavior? What went wrong? Relanding of original commit fixed problem with flakiness by adding several requestAnimationFrame requests https://chromium-review.googlesource.com/c/chromium/src/+/1187345/3/chrome/test/data/extensions/platform_apps/touchpad_pinch/window.js#10 , but it was still not a guaranty that main thread and compositor thread were synchronized. WebStore page: Did this work before? N/A Chrome version: 67.0.3396.87 Channel: n/a OS Version: Flash Version:
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52cb6d4d23587e46bb1d5f702be5fc9e7c10ca12 commit 52cb6d4d23587e46bb1d5f702be5fc9e7c10ca12 Author: Konstantin Ganenko <ganenkokb@yandex-team.ru> Date: Tue Dec 04 09:29:01 2018 Fix flaky tests TouchpadPinchSyntheticWheelEvents. Previously flakiness was fixed with adding several requestAnimationFrame requests, but it is still not a guaranty that main thread and compositor thread were synchronized. Change-Id: I051abddc6ae45ffbccc068998b3f0afcd044fdb3 Bug: 911032 Reviewed-on: https://chromium-review.googlesource.com/c/1329180 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#613482} [modify] https://crrev.com/52cb6d4d23587e46bb1d5f702be5fc9e7c10ca12/chrome/browser/apps/platform_apps/app_browsertest.cc [modify] https://crrev.com/52cb6d4d23587e46bb1d5f702be5fc9e7c10ca12/chrome/test/data/extensions/platform_apps/touchpad_pinch/window.js |
|
►
Sign in to add a comment |
|
Comment 1 by phanindra.mandapaka@chromium.org
, Dec 3