Prepare Crostini and its unittest for Closure compilation |
||||
Issue description- add Closure @types to the unittest vars - make Crostini externs file a @interface - bring it up-to-date with the current implementation methods - define CrostiniImpl that @implements the extern file definition - add MockCrostini for foreground unittests
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49c3b5ddad77fcf536f081a146b842323e3e7137 commit 49c3b5ddad77fcf536f081a146b842323e3e7137 Author: Noel Gordon <noel@chromium.org> Date: Tue Dec 04 00:12:24 2018 Make Crostini externs file an @interface - change the Crostini externs file to be an @interface class - add missing methods from the current implementation - add background BUILD rules to Closure compile {Crostini} - rename the background page Crostini to CrostiniImpl and make it @implements the {Crostini} class interface - use CrostiniImpl as the implementation for Files App: it is only instantiated on the Files app background page. - use CrostiniImpl for foreground unittests for now, until a mock (test-only) implementation is available. No change in test behavior, no new tests. Tbr: lucmult@ Bug: 911024 Change-Id: I580c9701374d6d8c1842a96040625c6be719ed64 Reviewed-on: https://chromium-review.googlesource.com/c/1358319 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#613341} [modify] https://crrev.com/49c3b5ddad77fcf536f081a146b842323e3e7137/ui/file_manager/externs/background/crostini.js [modify] https://crrev.com/49c3b5ddad77fcf536f081a146b842323e3e7137/ui/file_manager/file_manager/background/js/BUILD.gn [modify] https://crrev.com/49c3b5ddad77fcf536f081a146b842323e3e7137/ui/file_manager/file_manager/background/js/background.js [modify] https://crrev.com/49c3b5ddad77fcf536f081a146b842323e3e7137/ui/file_manager/file_manager/background/js/crostini.js [modify] https://crrev.com/49c3b5ddad77fcf536f081a146b842323e3e7137/ui/file_manager/file_manager/background/js/crostini_unittest.js [modify] https://crrev.com/49c3b5ddad77fcf536f081a146b842323e3e7137/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js [modify] https://crrev.com/49c3b5ddad77fcf536f081a146b842323e3e7137/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ceeede9ece7c3a29d2f4a99dea9e9595dbfa348 commit 8ceeede9ece7c3a29d2f4a99dea9e9595dbfa348 Author: Noel Gordon <noel@chromium.org> Date: Tue Dec 04 05:00:59 2018 Add mock_crostini rule for FilesApp foreground unittests - add background BUILD rule for mock_crostini - make mock_crostini visible to foreground code - include mock code in foreground unittests.html - change background / foreground tests to use it No change in test behavior. Bug: 911024 Change-Id: I15e3b243cea5937111da66ac504e143116bcbf0d Reviewed-on: https://chromium-review.googlesource.com/c/1358321 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#613415} [modify] https://crrev.com/8ceeede9ece7c3a29d2f4a99dea9e9595dbfa348/ui/file_manager/file_manager/background/js/BUILD.gn [modify] https://crrev.com/8ceeede9ece7c3a29d2f4a99dea9e9595dbfa348/ui/file_manager/file_manager/background/js/crostini_unittest.js [add] https://crrev.com/8ceeede9ece7c3a29d2f4a99dea9e9595dbfa348/ui/file_manager/file_manager/background/js/mock_crostini.js [modify] https://crrev.com/8ceeede9ece7c3a29d2f4a99dea9e9595dbfa348/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html [modify] https://crrev.com/8ceeede9ece7c3a29d2f4a99dea9e9595dbfa348/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js [modify] https://crrev.com/8ceeede9ece7c3a29d2f4a99dea9e9595dbfa348/ui/file_manager/file_manager/foreground/js/task_controller_unittest.html [modify] https://crrev.com/8ceeede9ece7c3a29d2f4a99dea9e9595dbfa348/ui/file_manager/file_manager/foreground/js/task_controller_unittest.js
,
Dec 4
,
Dec 4
Need to add mock_crostini to the js_type_check("test_support_type_check") rule ...
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/068db4e520fd526f29fad53309e9f6465ef53b70 commit 068db4e520fd526f29fad53309e9f6465ef53b70 Author: Noel Gordon <noel@chromium.org> Date: Tue Dec 04 11:03:35 2018 Add mock_crostini to test_support_type_check rule All background BUILD.gn test mocks rules should be in this list - add mock_crostini to the list. No change in behavior, no new tests. Tbr: lucmult@ Bug: 911024 Change-Id: I624160591f11b3ca2d068edc147c99dab9de7198 Reviewed-on: https://chromium-review.googlesource.com/c/1360454 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#613504} [modify] https://crrev.com/068db4e520fd526f29fad53309e9f6465ef53b70/ui/file_manager/file_manager/background/js/BUILD.gn
,
Dec 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Dec 3