Regression: Unnecessarily extra padding is seen chrome://extensions details page even when the row has less data to show. |
|||
Issue descriptionChrome Version: 73.0.3628.0 (Official Build) c54de3efc4361902fa786ba6fd64ad7c8a0b954a-refs/branch-heads/3628@{#1} (32/64 Bit) OS: Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS). Pre-Condition: Install extension from https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm/related?hl=en What steps will reproduce the problem? 1. Launch chrome, right click on extension icon in omnibox and select 'Manage Extension' from menu. 2. On Manage extension page, observe 'Allow access to file URLs' & 'Collect errors' row. Actual Result: Unnecessarily extra padding is seen even when the row has less data to show ('Allow access to file URLs' & 'Collect errors'). Expected Result: Extra padding should not be seen when the row has less content to show. This is a regression issue, broken in M-73 series, and below is the per-revision bisect info: Good Build: 73.0.3627.0(Revision:612852) Bad Build: 73.0.3628.0(Revision:612953) You are probably looking for a change made after 612921 (known good), but no later than 612922 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/0a61eede0bed3e65fd7cc2565d0dbafb6653dffe..9b84a15c4a74165175cd4ec32ff55163ad5c44e4 Suspect: https://chromium.googlesource.com/chromium/src/+/9b84a15c4a74165175cd4ec32ff55163ad5c44e4 johntlee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly refer the screen cast from the link given below Thank You!
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a69fc89361efb6feadfbe3a423d4b49c6a97bda commit 9a69fc89361efb6feadfbe3a423d4b49c6a97bda Author: John Lee <johntlee@chromium.org> Date: Tue Dec 04 01:17:05 2018 WebUI: Remove min-height for all extensions-toggle-row Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=911008#c1 Bug: 911008 Change-Id: I26748c195fa18cb30dc98a7bb14a1e231337261f Reviewed-on: https://chromium-review.googlesource.com/c/1358702 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#613371} [modify] https://crrev.com/9a69fc89361efb6feadfbe3a423d4b49c6a97bda/chrome/browser/resources/md_extensions/detail_view.html
,
Dec 5
Update: Retested the above issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS) OS using latest Canary #73.0.3631.0 and issue is fixed. Now, extra padding is not seen on chrome://extensions details page even when the row has less data to show. Kindly refer the attached screen-cast for reference. Thank You!
,
Dec 11
|
|||
►
Sign in to add a comment |
|||
Comment 1 by johntlee@chromium.org
, Dec 332.9 KB
32.9 KB View Download
37.3 KB
37.3 KB View Download