New issue
Advanced search Search tips

Issue 911005 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile actions_model_unittest

Project Member Reported by noel@google.com, Dec 3

Issue description

 - remove the current html unittest
 - closure compile the code and the test


 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ad9e35016f9acc0d4cb0c5e4c1e3b1b95a8ccc4

commit 0ad9e35016f9acc0d4cb0c5e4c1e3b1b95a8ccc4
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 03 08:51:05 2018

Closure compile actions_model_unittest

 - remove actions_model_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - make mock_drive_sync_handler visible to foreground unittests
 - Add Closure @type defines to unittest variables (OMG).
 - fix Closure compile errors

Bug:  911005 
Change-Id: Ia29ca0e11ee984f00daf66271ff65e5fcb52b1c7
Reviewed-on: https://chromium-review.googlesource.com/c/1356732
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613024}
[modify] https://crrev.com/0ad9e35016f9acc0d4cb0c5e4c1e3b1b95a8ccc4/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/0ad9e35016f9acc0d4cb0c5e4c1e3b1b95a8ccc4/ui/file_manager/file_manager/background/js/BUILD.gn
[modify] https://crrev.com/0ad9e35016f9acc0d4cb0c5e4c1e3b1b95a8ccc4/ui/file_manager/file_manager/foreground/js/BUILD.gn
[delete] https://crrev.com/7755d2865c95f9c6468090b12139745a355fd8a6/ui/file_manager/file_manager/foreground/js/actions_model_unittest.html
[modify] https://crrev.com/0ad9e35016f9acc0d4cb0c5e4c1e3b1b95a8ccc4/ui/file_manager/file_manager/foreground/js/actions_model_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment