Feature description: Brings clank's compact Translate Infobar to Bling. Eng owner: mahmadi@ Product owner: yyushkina@
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4 commit 3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Dec 04 23:13:49 2018 [iOS][Translate] Moves LanguageSelectionCoordinator to InfobarCoordinator Bug: 910994 Change-Id: I7f59a65fed447d2ffb960fbc901f92ea35c84c35 Reviewed-on: https://chromium-review.googlesource.com/c/1340533 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#613749} [modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/browser_view_controller_unittest.mm [modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/infobars/BUILD.gn [modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/infobars/infobar_container_mediator.h [modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/infobars/infobar_container_mediator.mm [modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/infobars/infobar_coordinator.h [modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/infobars/infobar_coordinator.mm [modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/translate/language_selection_coordinator.h [modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/translate/language_selection_coordinator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/703eff8e700f96e56470d16d5f0a968860e52ebf commit 703eff8e700f96e56470d16d5f0a968860e52ebf Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Dec 11 13:26:11 2018 [iOS][Translate] Refactors popup menu UI for reuse - Removes dependency of :popup_menu_ui to the tools popup menu and navigation popup menu logic, i.e., PopupMenuCommands, coordinator, and mediator, allowing it to be reused in the new translate infobar for the language selection as well as translate options popup menus. - Moves reusable UI targets to ios/chrome/browser/ui/popup_menu/publicenu. Bug: 910994 Change-Id: I16229bd0d8d64ba4e20498bdb3ea283b780f0678 Reviewed-on: https://chromium-review.googlesource.com/c/1358114 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#615509} [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/BUILD.gn [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/cells/BUILD.gn [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.h [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.mm [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.h [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm [add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_action_handler.h [add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_action_handler.mm [add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_action_handler_commands.h [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm [delete] https://crrev.com/bc7cfa6993305837d194dbcd18350cb3535bdee6/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.h [delete] https://crrev.com/bc7cfa6993305837d194dbcd18350cb3535bdee6/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm [delete] https://crrev.com/bc7cfa6993305837d194dbcd18350cb3535bdee6/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller_commands.h [modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/BUILD.gn [add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/cells/BUILD.gn [rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/cells/popup_menu_footer_item.h [rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/cells/popup_menu_footer_item.mm [rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/cells/popup_menu_item.h [rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_consumer.h [add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_presenter.h [rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_presenter.mm [add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_presenter_delegate.h [rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_table_view_controller.h [add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_table_view_controller.mm [add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_table_view_controller_delegate.h [add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_ui_constants.h [add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_ui_constants.mm [rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_view_controller.h [rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_view_controller.mm [add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_view_controller_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4cce1fefc7e7a5b48e2fb1757c3acb71857dd49 commit e4cce1fefc7e7a5b48e2fb1757c3acb71857dd49 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Dec 18 23:48:01 2018 [iOS][Translate] Adds a feature and chrome://flags entry for compact infobar Bug: 910994 Change-Id: Icd7f498b2916df7e0f89c5c285e50fe64a1c132c Reviewed-on: https://chromium-review.googlesource.com/c/1381875 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#617676} [modify] https://crrev.com/e4cce1fefc7e7a5b48e2fb1757c3acb71857dd49/components/translate/core/browser/translate_prefs.cc [modify] https://crrev.com/e4cce1fefc7e7a5b48e2fb1757c3acb71857dd49/components/translate/core/browser/translate_prefs.h [modify] https://crrev.com/e4cce1fefc7e7a5b48e2fb1757c3acb71857dd49/ios/chrome/browser/about_flags.mm [modify] https://crrev.com/e4cce1fefc7e7a5b48e2fb1757c3acb71857dd49/ios/chrome/browser/ios_chrome_flag_descriptions.cc [modify] https://crrev.com/e4cce1fefc7e7a5b48e2fb1757c3acb71857dd49/ios/chrome/browser/ios_chrome_flag_descriptions.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ffd3855203a6e20876acfdd5d04723cfc6343f7 commit 4ffd3855203a6e20876acfdd5d04723cfc6343f7 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Dec 20 01:10:45 2018 [iOS][Translate] TranslateOptionSelectionHandler/Delegate Adds Obj-C protocols adopted by the object providing an interface for the user to select a translate option and the object receiving user choice of the translate option. Signed-off-by: Moe Ahmadi <mahmadi@chromium.org> Bug: 910994 Change-Id: Icfe13e51703196ebfc9052d8d695964ad095c7c5 Reviewed-on: https://chromium-review.googlesource.com/c/1382713 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#618055} [modify] https://crrev.com/4ffd3855203a6e20876acfdd5d04723cfc6343f7/ios/chrome/browser/translate/BUILD.gn [modify] https://crrev.com/4ffd3855203a6e20876acfdd5d04723cfc6343f7/ios/chrome/browser/translate/chrome_ios_translate_client.h [modify] https://crrev.com/4ffd3855203a6e20876acfdd5d04723cfc6343f7/ios/chrome/browser/translate/chrome_ios_translate_client.mm [modify] https://crrev.com/4ffd3855203a6e20876acfdd5d04723cfc6343f7/ios/chrome/browser/translate/language_selection_handler.h [add] https://crrev.com/4ffd3855203a6e20876acfdd5d04723cfc6343f7/ios/chrome/browser/translate/translate_option_selection_delegate.h [add] https://crrev.com/4ffd3855203a6e20876acfdd5d04723cfc6343f7/ios/chrome/browser/translate/translate_option_selection_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/468a28107f56e2219cb104256ace636cf00ed0fe commit 468a28107f56e2219cb104256ace636cf00ed0fe Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Dec 20 04:53:29 2018 [iOS][Translate] Mark more methods as const in TranslateInfoBarDelegate Marks additional methods as const in TranslateInfoBarDelegate and TranslateUIDelegate as these methods need to be called on a const reference to TranslateInfoBarDelegate Bug: 910994 Change-Id: I749cec000559d6e144c2a1c3009ad82ee292acbd Reviewed-on: https://chromium-review.googlesource.com/c/1385695 Reviewed-by: Michael Martis <martis@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#618113} [modify] https://crrev.com/468a28107f56e2219cb104256ace636cf00ed0fe/components/translate/core/browser/translate_infobar_delegate.cc [modify] https://crrev.com/468a28107f56e2219cb104256ace636cf00ed0fe/components/translate/core/browser/translate_infobar_delegate.h [modify] https://crrev.com/468a28107f56e2219cb104256ace636cf00ed0fe/components/translate/core/browser/translate_ui_delegate.cc [modify] https://crrev.com/468a28107f56e2219cb104256ace636cf00ed0fe/components/translate/core/browser/translate_ui_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e042f17e55af090a5e0ee43611f039d3b676ad32 commit e042f17e55af090a5e0ee43611f039d3b676ad32 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Jan 16 00:27:51 2019 [iOS][Translate] UITableViewCells for compact translate infobar popup menus - Creates UITableViewCells subclasses to be used in the language selection popup menu as well as the translate options popup menu. screenshot1: https://drive.google.com/file/d/1_HXlKczat_eJKxVMZLUKCmpaAtnSam7I/view?usp=sharing screenshot2: https://drive.google.com/file/d/12NPnfmhgjJYR4hSPqOkLuAsXT5x-_bo5/view?usp=sharing Bug: 910994 Change-Id: I87f2f87b536afcd13a7e0172e2ec2f8236c90a86 Reviewed-on: https://chromium-review.googlesource.com/c/1382714 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#622920} [modify] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/popup_menu/public/cells/popup_menu_item.h [modify] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/translate/BUILD.gn [add] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/translate/cells/BUILD.gn [add] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/translate/cells/select_language_popup_menu_item.h [add] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/translate/cells/select_language_popup_menu_item.mm [add] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/translate/cells/translate_popup_menu_item.h [add] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/translate/cells/translate_popup_menu_item.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7d6be9b9bbbefbced75a9176dd6190761e3f07c commit b7d6be9b9bbbefbced75a9176dd6190761e3f07c Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Jan 16 19:53:05 2019 [iOS][Translate] TranslatePopupCoordinator/Mediator - Creates the TranslatePopupCoordinator and TranslatePopupMediator responsible for populating, displaying, and dimissing the language selection as well as the translate options popup menus and relaying the user action to the respective delegates. Bug: 910994 Change-Id: Ibdb6dee29b09b04244513286365a7da3d1922604 Reviewed-on: https://chromium-review.googlesource.com/c/1382717 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#623336} [modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/components/translate_strings.grdp [modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/infobars/BUILD.gn [modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/main/BUILD.gn [modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/main/browser_coordinator.mm [modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/translate/BUILD.gn [add] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/translate/translate_popup_menu_coordinator.h [add] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/translate/translate_popup_menu_coordinator.mm [add] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/translate/translate_popup_menu_mediator.h [add] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/translate/translate_popup_menu_mediator.mm [modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/util/layout_guide_names.h [modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/util/layout_guide_names.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d880cffd9e682e6dbc180d36b57166408e25728 commit 7d880cffd9e682e6dbc180d36b57166408e25728 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Jan 16 21:24:01 2019 [Translate] Keep infobar when toggling setting in TranslateInfoBarDelegate This CL changes the TranslateInfoBarDelegate so that it does not remove the infobar when ToggleTranslatableLanguageByPrefs and ToggleSiteBlacklist are called for the following reasons: 1. These methods are doing more than their names suggest they do. 2. Their logic can be simplified if the call to remove the infobar is made in TranslateCompactInfoBar because these methods are only called in TranslateCompactInfoBar and the infobar always gets removed as a result of those calls. Bug: 910994 Change-Id: Iad4919a69b41980d283cd33804107339f2ad6197 Reviewed-on: https://chromium-review.googlesource.com/c/1412733 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#623373} [modify] https://crrev.com/7d880cffd9e682e6dbc180d36b57166408e25728/chrome/browser/ui/android/infobars/translate_compact_infobar.cc [modify] https://crrev.com/7d880cffd9e682e6dbc180d36b57166408e25728/components/translate/core/browser/translate_infobar_delegate.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2ee77be9ec4f41fc962f872f53e6a3293f633e5 commit c2ee77be9ec4f41fc962f872f53e6a3293f633e5 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Jan 17 16:12:29 2019 [iOS][Translate] ios/chrome/browser/ui/translate/OWNERS adding mahmadi to the OWNERS file as the initial author Bug: 910994 Change-Id: I435ce4e9f770bdb0ee7a6b234ddd23923937a325 Reviewed-on: https://chromium-review.googlesource.com/c/1416010 Reviewed-by: Mark Cogan <marq@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#623704} [add] https://crrev.com/c2ee77be9ec4f41fc962f872f53e6a3293f633e5/ios/chrome/browser/ui/translate/OWNERS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee232ad7a3ac7fb4081541d904899e23cc31079e commit ee232ad7a3ac7fb4081541d904899e23cc31079e Author: Moe Ahmadi <mahmadi@chromium.org> Date: Fri Jan 18 17:28:05 2019 [iOS][Translate] Support multiline labels in translate infobar popup menus - Adds support for multiline labels in the translate infobar popup menus. - Uses a checkmark icon instead of the UITableViewCellAccessoryCheckmark to indicated if a row is selected. Using the cell's accessoryType along with multiline labels has some drabacks including not being able to reserve space for the checkmark accessory as well as the cells being taller than they need to be. Bug: 910994 Change-Id: Iaefa7597011bd50b281a6c0acea17a207134bb4f Reviewed-on: https://chromium-review.googlesource.com/c/1418733 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#624179} [modify] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/BUILD.gn [add] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/resources/checkmark.imageset/Contents.json [add] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/resources/checkmark.imageset/checkmark.png [add] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/resources/checkmark.imageset/checkmark@2x.png [add] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/resources/checkmark.imageset/checkmark@3x.png [modify] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/translate_popup_menu_item.h [modify] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/translate_popup_menu_item.mm [modify] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/translate_popup_menu_mediator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff3f61b8aff422f0fe2135753c2feb78858f99e3 commit ff3f61b8aff422f0fe2135753c2feb78858f99e3 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Fri Jan 18 18:50:51 2019 [iOS][Translate] Translate infobar notifications - Introduces an interface and the implementing class responsible for presenting translate infobar notifications in the form of MDC Snackbars and reporting the dismissal back to via a delegate object. - Adds the strings for the notifications. Bug: 910994 Change-Id: I50112a41d179d2c4a5015d3cac8fb8bbdf8556d3 Reviewed-on: https://chromium-review.googlesource.com/c/1416396 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#624215} [modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/components/translate_strings.grdp [modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/translate/BUILD.gn [modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/translate/chrome_ios_translate_client.h [modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/translate/chrome_ios_translate_client.mm [modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/BUILD.gn [add] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_notification_delegate.h [add] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_notification_handler.h [add] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_notification_presenter.h [add] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_notification_presenter.mm [modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_popup_menu_coordinator.mm [modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_popup_menu_mediator.h [modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_popup_menu_mediator.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbe1350d8c635f3ec4f1845c0b43e23e8bf082ed commit bbe1350d8c635f3ec4f1845c0b43e23e8bf082ed Author: Moe Ahmadi <mahmadi@chromium.org> Date: Mon Jan 21 20:57:50 2019 [iOS][Translate] ObjC TranslateInfobarDelegateObserver TranslateInfobarDelegateObserverBridge for use in ObjC Bug: 910994 Change-Id: I5e001c05b95fe9afb95e8e1718ad0a13a0addc05 Reviewed-on: https://chromium-review.googlesource.com/c/1422117 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#624656} [modify] https://crrev.com/bbe1350d8c635f3ec4f1845c0b43e23e8bf082ed/components/translate/core/browser/translate_infobar_delegate.h [modify] https://crrev.com/bbe1350d8c635f3ec4f1845c0b43e23e8bf082ed/ios/chrome/browser/translate/BUILD.gn [add] https://crrev.com/bbe1350d8c635f3ec4f1845c0b43e23e8bf082ed/ios/chrome/browser/translate/translate_infobar_delegate_observer_bridge.h [add] https://crrev.com/bbe1350d8c635f3ec4f1845c0b43e23e8bf082ed/ios/chrome/browser/translate/translate_infobar_delegate_observer_bridge.mm [add] https://crrev.com/bbe1350d8c635f3ec4f1845c0b43e23e8bf082ed/ios/chrome/browser/translate/translate_infobar_delegate_observer_bridge_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1af9e1935b86d8fba0c751d1ba89810d76d05acc commit 1af9e1935b86d8fba0c751d1ba89810d76d05acc Author: Moe Ahmadi <mahmadi@chromium.org> Date: Mon Jan 21 21:08:09 2019 [iOS][Translate] Do nothing on revertTranslation if script isn't injected Changes the DCHECK in [JsTranslateManager revertTranslation] to an early return if the script hasn't been injected. Since there is no API in iOS to check whether the page has been translated, there is no way to stop the user from attempting to revert the translation by tapping the source language button in the new translate infobar. Bug: 910994 Change-Id: Ie6accd783db2039acdfd95acb968bf8fb52da98b Reviewed-on: https://chromium-review.googlesource.com/c/1425958 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#624674} [modify] https://crrev.com/1af9e1935b86d8fba0c751d1ba89810d76d05acc/components/translate/ios/browser/js_translate_manager.mm
Comment 1 by bugdroid1@chromium.org
, Dec 4