New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Feature



Sign in to add a comment
link

Issue 910994: iOS Translate UI redesign

Reported by mahmadi@chromium.org, Dec 3 Project Member

Issue description

Feature description: Brings clank's compact Translate Infobar to Bling. 
Eng owner: mahmadi@
Product owner: yyushkina@
 

Comment 1 by bugdroid1@chromium.org, Dec 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4

commit 3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Dec 04 23:13:49 2018

[iOS][Translate] Moves LanguageSelectionCoordinator to InfobarCoordinator

Bug: 910994
Change-Id: I7f59a65fed447d2ffb960fbc901f92ea35c84c35
Reviewed-on: https://chromium-review.googlesource.com/c/1340533
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613749}
[modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/infobars/BUILD.gn
[modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/infobars/infobar_container_mediator.h
[modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/infobars/infobar_container_mediator.mm
[modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/infobars/infobar_coordinator.h
[modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/infobars/infobar_coordinator.mm
[modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/translate/language_selection_coordinator.h
[modify] https://crrev.com/3a6cc7004b9bfe1bf8b23dfda95f846c949eaef4/ios/chrome/browser/ui/translate/language_selection_coordinator.mm

Comment 2 by bugdroid1@chromium.org, Dec 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/703eff8e700f96e56470d16d5f0a968860e52ebf

commit 703eff8e700f96e56470d16d5f0a968860e52ebf
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Dec 11 13:26:11 2018

[iOS][Translate] Refactors popup menu UI for reuse

- Removes dependency of :popup_menu_ui to the tools  popup menu and
  navigation popup menu logic, i.e., PopupMenuCommands, coordinator, and
  mediator, allowing it to be reused in the new translate infobar for the
  language selection as well as translate options popup menus.
- Moves reusable UI targets to ios/chrome/browser/ui/popup_menu/publicenu.

Bug: 910994
Change-Id: I16229bd0d8d64ba4e20498bdb3ea283b780f0678
Reviewed-on: https://chromium-review.googlesource.com/c/1358114
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615509}
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/cells/BUILD.gn
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.h
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/cells/popup_menu_navigation_item.mm
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.h
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/cells/popup_menu_tools_item.mm
[add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_action_handler.h
[add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_action_handler.mm
[add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_action_handler_commands.h
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_constants.h
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_constants.mm
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/popup_menu_mediator_unittest.mm
[delete] https://crrev.com/bc7cfa6993305837d194dbcd18350cb3535bdee6/ios/chrome/browser/ui/popup_menu/popup_menu_presenter.h
[delete] https://crrev.com/bc7cfa6993305837d194dbcd18350cb3535bdee6/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
[delete] https://crrev.com/bc7cfa6993305837d194dbcd18350cb3535bdee6/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller_commands.h
[modify] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/BUILD.gn
[add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/cells/BUILD.gn
[rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/cells/popup_menu_footer_item.h
[rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/cells/popup_menu_footer_item.mm
[rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/cells/popup_menu_item.h
[rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_consumer.h
[add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_presenter.h
[rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_presenter.mm
[add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_presenter_delegate.h
[rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_table_view_controller.h
[add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_table_view_controller.mm
[add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_table_view_controller_delegate.h
[add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_ui_constants.h
[add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_ui_constants.mm
[rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_view_controller.h
[rename] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_view_controller.mm
[add] https://crrev.com/703eff8e700f96e56470d16d5f0a968860e52ebf/ios/chrome/browser/ui/popup_menu/public/popup_menu_view_controller_delegate.h

Comment 4 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ffd3855203a6e20876acfdd5d04723cfc6343f7

commit 4ffd3855203a6e20876acfdd5d04723cfc6343f7
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Dec 20 01:10:45 2018

[iOS][Translate] TranslateOptionSelectionHandler/Delegate

Adds Obj-C protocols adopted by the object providing an interface for the
user to select a translate option and the object receiving user choice of
the translate option.

Signed-off-by: Moe Ahmadi <mahmadi@chromium.org>
Bug: 910994
Change-Id: Icfe13e51703196ebfc9052d8d695964ad095c7c5
Reviewed-on: https://chromium-review.googlesource.com/c/1382713
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618055}
[modify] https://crrev.com/4ffd3855203a6e20876acfdd5d04723cfc6343f7/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/4ffd3855203a6e20876acfdd5d04723cfc6343f7/ios/chrome/browser/translate/chrome_ios_translate_client.h
[modify] https://crrev.com/4ffd3855203a6e20876acfdd5d04723cfc6343f7/ios/chrome/browser/translate/chrome_ios_translate_client.mm
[modify] https://crrev.com/4ffd3855203a6e20876acfdd5d04723cfc6343f7/ios/chrome/browser/translate/language_selection_handler.h
[add] https://crrev.com/4ffd3855203a6e20876acfdd5d04723cfc6343f7/ios/chrome/browser/translate/translate_option_selection_delegate.h
[add] https://crrev.com/4ffd3855203a6e20876acfdd5d04723cfc6343f7/ios/chrome/browser/translate/translate_option_selection_handler.h

Comment 5 by bugdroid1@chromium.org, Dec 20

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/468a28107f56e2219cb104256ace636cf00ed0fe

commit 468a28107f56e2219cb104256ace636cf00ed0fe
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Dec 20 04:53:29 2018

[iOS][Translate] Mark more methods as const in TranslateInfoBarDelegate

Marks additional methods as const in TranslateInfoBarDelegate and
TranslateUIDelegate as these methods need to be called on a const
reference to TranslateInfoBarDelegate

Bug: 910994
Change-Id: I749cec000559d6e144c2a1c3009ad82ee292acbd
Reviewed-on: https://chromium-review.googlesource.com/c/1385695
Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618113}
[modify] https://crrev.com/468a28107f56e2219cb104256ace636cf00ed0fe/components/translate/core/browser/translate_infobar_delegate.cc
[modify] https://crrev.com/468a28107f56e2219cb104256ace636cf00ed0fe/components/translate/core/browser/translate_infobar_delegate.h
[modify] https://crrev.com/468a28107f56e2219cb104256ace636cf00ed0fe/components/translate/core/browser/translate_ui_delegate.cc
[modify] https://crrev.com/468a28107f56e2219cb104256ace636cf00ed0fe/components/translate/core/browser/translate_ui_delegate.h

Comment 6 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e042f17e55af090a5e0ee43611f039d3b676ad32

commit e042f17e55af090a5e0ee43611f039d3b676ad32
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed Jan 16 00:27:51 2019

[iOS][Translate] UITableViewCells for compact translate infobar popup menus

- Creates UITableViewCells subclasses to be used in the language selection
  popup menu as well as the translate options popup menu.

screenshot1: https://drive.google.com/file/d/1_HXlKczat_eJKxVMZLUKCmpaAtnSam7I/view?usp=sharing
screenshot2: https://drive.google.com/file/d/12NPnfmhgjJYR4hSPqOkLuAsXT5x-_bo5/view?usp=sharing

Bug: 910994
Change-Id: I87f2f87b536afcd13a7e0172e2ec2f8236c90a86
Reviewed-on: https://chromium-review.googlesource.com/c/1382714
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622920}
[modify] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/popup_menu/public/cells/popup_menu_item.h
[modify] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/translate/BUILD.gn
[add] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/translate/cells/BUILD.gn
[add] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/translate/cells/select_language_popup_menu_item.h
[add] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/translate/cells/select_language_popup_menu_item.mm
[add] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/translate/cells/translate_popup_menu_item.h
[add] https://crrev.com/e042f17e55af090a5e0ee43611f039d3b676ad32/ios/chrome/browser/ui/translate/cells/translate_popup_menu_item.mm

Comment 7 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7d6be9b9bbbefbced75a9176dd6190761e3f07c

commit b7d6be9b9bbbefbced75a9176dd6190761e3f07c
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed Jan 16 19:53:05 2019

[iOS][Translate] TranslatePopupCoordinator/Mediator

- Creates the TranslatePopupCoordinator and TranslatePopupMediator
  responsible for populating, displaying, and dimissing the language
  selection as well as the translate options popup menus and relaying the
  user action to the respective delegates.

Bug: 910994
Change-Id: Ibdb6dee29b09b04244513286365a7da3d1922604
Reviewed-on: https://chromium-review.googlesource.com/c/1382717
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623336}
[modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/components/translate_strings.grdp
[modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/infobars/BUILD.gn
[modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/main/BUILD.gn
[modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/main/browser_coordinator.mm
[modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/translate/BUILD.gn
[add] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/translate/translate_popup_menu_coordinator.h
[add] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/translate/translate_popup_menu_coordinator.mm
[add] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/translate/translate_popup_menu_mediator.h
[add] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/translate/translate_popup_menu_mediator.mm
[modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/util/layout_guide_names.h
[modify] https://crrev.com/b7d6be9b9bbbefbced75a9176dd6190761e3f07c/ios/chrome/browser/ui/util/layout_guide_names.mm

Comment 8 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d880cffd9e682e6dbc180d36b57166408e25728

commit 7d880cffd9e682e6dbc180d36b57166408e25728
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed Jan 16 21:24:01 2019

[Translate] Keep infobar when toggling setting in TranslateInfoBarDelegate

This CL changes the TranslateInfoBarDelegate so that it does not remove
the infobar when ToggleTranslatableLanguageByPrefs and ToggleSiteBlacklist
are called for the following reasons:
1. These methods are doing more than their names suggest they do.
2. Their logic can be simplified if the call to remove the infobar is
   made in TranslateCompactInfoBar because these methods are only called
   in TranslateCompactInfoBar and the infobar always gets removed as a
   result of those calls.

Bug: 910994
Change-Id: Iad4919a69b41980d283cd33804107339f2ad6197
Reviewed-on: https://chromium-review.googlesource.com/c/1412733
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623373}
[modify] https://crrev.com/7d880cffd9e682e6dbc180d36b57166408e25728/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
[modify] https://crrev.com/7d880cffd9e682e6dbc180d36b57166408e25728/components/translate/core/browser/translate_infobar_delegate.cc

Comment 9 by bugdroid1@chromium.org, Jan 17

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2ee77be9ec4f41fc962f872f53e6a3293f633e5

commit c2ee77be9ec4f41fc962f872f53e6a3293f633e5
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Jan 17 16:12:29 2019

[iOS][Translate] ios/chrome/browser/ui/translate/OWNERS

adding mahmadi to the OWNERS file as the initial author

Bug: 910994
Change-Id: I435ce4e9f770bdb0ee7a6b234ddd23923937a325
Reviewed-on: https://chromium-review.googlesource.com/c/1416010
Reviewed-by: Mark Cogan <marq@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623704}
[add] https://crrev.com/c2ee77be9ec4f41fc962f872f53e6a3293f633e5/ios/chrome/browser/ui/translate/OWNERS

Comment 10 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee232ad7a3ac7fb4081541d904899e23cc31079e

commit ee232ad7a3ac7fb4081541d904899e23cc31079e
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Jan 18 17:28:05 2019

[iOS][Translate] Support multiline labels in translate infobar popup menus

- Adds support for multiline labels in the translate infobar popup menus.
- Uses a checkmark icon instead of the UITableViewCellAccessoryCheckmark to
  indicated if a row is selected. Using the cell's accessoryType along with
  multiline labels has some drabacks including not being able to reserve
  space for the checkmark accessory as well as the cells being taller than
  they need to be.

Bug: 910994
Change-Id: Iaefa7597011bd50b281a6c0acea17a207134bb4f
Reviewed-on: https://chromium-review.googlesource.com/c/1418733
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624179}
[modify] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/BUILD.gn
[add] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/resources/checkmark.imageset/Contents.json
[add] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/resources/checkmark.imageset/checkmark.png
[add] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/resources/checkmark.imageset/checkmark@2x.png
[add] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/resources/checkmark.imageset/checkmark@3x.png
[modify] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/translate_popup_menu_item.h
[modify] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/cells/translate_popup_menu_item.mm
[modify] https://crrev.com/ee232ad7a3ac7fb4081541d904899e23cc31079e/ios/chrome/browser/ui/translate/translate_popup_menu_mediator.mm

Comment 11 by bugdroid1@chromium.org, Jan 18

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff3f61b8aff422f0fe2135753c2feb78858f99e3

commit ff3f61b8aff422f0fe2135753c2feb78858f99e3
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Jan 18 18:50:51 2019

[iOS][Translate] Translate infobar notifications

- Introduces an interface and the implementing class responsible for
  presenting translate infobar notifications in the form of MDC Snackbars
  and reporting the dismissal back to via a delegate object.
- Adds the strings for the notifications.

Bug: 910994
Change-Id: I50112a41d179d2c4a5015d3cac8fb8bbdf8556d3
Reviewed-on: https://chromium-review.googlesource.com/c/1416396
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624215}
[modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/components/translate_strings.grdp
[modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/translate/chrome_ios_translate_client.h
[modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/translate/chrome_ios_translate_client.mm
[modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/BUILD.gn
[add] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_notification_delegate.h
[add] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_notification_handler.h
[add] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_notification_presenter.h
[add] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_notification_presenter.mm
[modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_popup_menu_coordinator.mm
[modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_popup_menu_mediator.h
[modify] https://crrev.com/ff3f61b8aff422f0fe2135753c2feb78858f99e3/ios/chrome/browser/ui/translate/translate_popup_menu_mediator.mm

Comment 13 by bugdroid1@chromium.org, Jan 21

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1af9e1935b86d8fba0c751d1ba89810d76d05acc

commit 1af9e1935b86d8fba0c751d1ba89810d76d05acc
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Mon Jan 21 21:08:09 2019

[iOS][Translate] Do nothing on revertTranslation if script isn't injected

Changes the DCHECK in [JsTranslateManager revertTranslation] to an early
return if the script hasn't been injected. Since there is no API in iOS to
check whether the page has been translated, there is no way to stop the
user from attempting to revert the translation by tapping the source
language button in the new translate infobar.

Bug: 910994
Change-Id: Ie6accd783db2039acdfd95acb968bf8fb52da98b
Reviewed-on: https://chromium-review.googlesource.com/c/1425958
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624674}
[modify] https://crrev.com/1af9e1935b86d8fba0c751d1ba89810d76d05acc/components/translate/ios/browser/js_translate_manager.mm

Comment 14 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e5db655262b45932402031922086a5be701c4b

commit 70e5db655262b45932402031922086a5be701c4b
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Jan 24 16:57:40 2019

[iOS][Translate] Compact translate infobar view

video: https://drive.google.com/file/d/1rRJgtGsgFPsFgcoUCwqcYT-dHDKguuhk/view?usp=sharing

Starting from the leading edge, it features an icon followed by the source
and the target languages. Toggling between the languages results in the
page to be translated or the translation to be reverted. At the trailing
edge, the infobar features an options button that opens a popup menu that
allows changing translate preferences followed by a close button to dismiss
the infobar. The view hierarchy is as follows:
TranslateInfobarView ->
TranslateInfobarTabStripView ->
TranslateInfobarTabView

Bug: 910994
Change-Id: Icc9d06f43a4a91ba0ec967ce3e9b372b5e9b9bfb
Reviewed-on: https://chromium-review.googlesource.com/c/1426014
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625681}

Comment 15 by bugdroid, Jan 25

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93f298a47bbaafa0ad6fd49b59493b313dd6a70b

commit 93f298a47bbaafa0ad6fd49b59493b313dd6a70b
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Jan 25 17:31:02 2019

[iOS][Translate] Renames translate_popup_menu_coordinator/mediator

Renames translate_popup_menu_coordinator and translate_popup_menu_mediator
to translate_infobar_coordinator and translate_infobar_mediator as they
have more responsiblities than only displaying/dismissing the translate
infobar popup menus, e.g., handling translate options notifications.

Bug: 910994
Change-Id: Id6e0df35ee8216b3d498ab407f58e08c4314ae40
Reviewed-on: https://chromium-review.googlesource.com/c/1436941
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626110}

Comment 16 by bugdroid, Jan 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b9ee0f5c0dd94b8c5ea6a0838825505fce4ed35

commit 7b9ee0f5c0dd94b8c5ea6a0838825505fce4ed35
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed Jan 30 16:44:59 2019

[iOS][Translate] TranslateInfobarController

Creates the compact translate infobar view and handles user interaction.
video: https://drive.google.com/file/d/1rRJgtGsgFPsFgcoUCwqcYT-dHDKguuhk/view?usp=sharing

Bug: 910994
Change-Id: I0d2f455bea60e6340bacc6d12c62e1d246703f72
Reviewed-on: https://chromium-review.googlesource.com/c/1426016
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627455}
[modify] https://crrev.com/7b9ee0f5c0dd94b8c5ea6a0838825505fce4ed35/components/translate/core/browser/translate_infobar_delegate.cc
[modify] https://crrev.com/7b9ee0f5c0dd94b8c5ea6a0838825505fce4ed35/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/7b9ee0f5c0dd94b8c5ea6a0838825505fce4ed35/ios/chrome/browser/translate/chrome_ios_translate_client.mm
[add] https://crrev.com/7b9ee0f5c0dd94b8c5ea6a0838825505fce4ed35/ios/chrome/browser/translate/translate_infobar_controller.h
[add] https://crrev.com/7b9ee0f5c0dd94b8c5ea6a0838825505fce4ed35/ios/chrome/browser/translate/translate_infobar_controller.mm
[modify] https://crrev.com/7b9ee0f5c0dd94b8c5ea6a0838825505fce4ed35/ios/chrome/browser/translate/translate_infobar_delegate_observer_bridge.h
[modify] https://crrev.com/7b9ee0f5c0dd94b8c5ea6a0838825505fce4ed35/ios/chrome/browser/translate/translate_infobar_delegate_observer_bridge.mm
[modify] https://crrev.com/7b9ee0f5c0dd94b8c5ea6a0838825505fce4ed35/ios/chrome/browser/translate/translate_infobar_delegate_observer_bridge_unittest.mm

Comment 17 by bugdroid, Jan 30

Project Member

Comment 18 by bugdroid, Jan 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efb809c8cf250f1fa83c2c72bd4177517f659aa5

commit efb809c8cf250f1fa83c2c72bd4177517f659aa5
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Jan 31 23:25:13 2019

[iOS][Translate] TranslateInfobarMediator unit tests

Adds unit tests for the TranslateInfobarMediator for:
- whether it installs UI handlers on ChromeIOSTranslateClient as expected.
- whether it returns the expected menu items for the translate infobar.

Bug: 910994
Change-Id: I90b9aa4a466a659afea37f0ca3e5a3e4535df84d
Reviewed-on: https://chromium-review.googlesource.com/c/1436943
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628141}
[modify] https://crrev.com/efb809c8cf250f1fa83c2c72bd4177517f659aa5/components/translate/core/browser/BUILD.gn
[add] https://crrev.com/efb809c8cf250f1fa83c2c72bd4177517f659aa5/components/translate/core/browser/mock_translate_infobar_delegate.cc
[add] https://crrev.com/efb809c8cf250f1fa83c2c72bd4177517f659aa5/components/translate/core/browser/mock_translate_infobar_delegate.h
[modify] https://crrev.com/efb809c8cf250f1fa83c2c72bd4177517f659aa5/components/translate/core/browser/translate_infobar_delegate.cc
[modify] https://crrev.com/efb809c8cf250f1fa83c2c72bd4177517f659aa5/components/translate/core/browser/translate_infobar_delegate.h
[modify] https://crrev.com/efb809c8cf250f1fa83c2c72bd4177517f659aa5/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/efb809c8cf250f1fa83c2c72bd4177517f659aa5/ios/chrome/browser/translate/chrome_ios_translate_client.h
[modify] https://crrev.com/efb809c8cf250f1fa83c2c72bd4177517f659aa5/ios/chrome/browser/translate/translate_infobar_delegate_observer_bridge_unittest.mm
[modify] https://crrev.com/efb809c8cf250f1fa83c2c72bd4177517f659aa5/ios/chrome/browser/ui/translate/BUILD.gn
[add] https://crrev.com/efb809c8cf250f1fa83c2c72bd4177517f659aa5/ios/chrome/browser/ui/translate/translate_infobar_mediator_unittest.mm
[modify] https://crrev.com/efb809c8cf250f1fa83c2c72bd4177517f659aa5/ios/chrome/test/BUILD.gn

Comment 19 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b37426ffe336dc907faecfa599fc4159e9f93b52

commit b37426ffe336dc907faecfa599fc4159e9f93b52
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Feb 01 01:30:36 2019

[iOS][Translate] Fix translate infobar's language tab spinner animation

Use UIView's alpha property instead of hidden to hide the button and show
the spinner on translate infobar's language tab.

As opposed to hidden, alpha is an animatable UIView property:
https://developer.apple.com/library/archive/documentation/WindowsViews/Conceptual/ViewPG_iPhoneOS/AnimatingViews/AnimatingViews.html

Bug: 910994
Change-Id: I35a853f52f4f7291412a51cacbd61a13e3c00087
Reviewed-on: https://chromium-review.googlesource.com/c/1448773
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628187}
[modify] https://crrev.com/b37426ffe336dc907faecfa599fc4159e9f93b52/ios/chrome/browser/ui/translate/translate_infobar_language_tab_view.mm

Comment 20 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b90b42560e05a3ab2c68042e38c15bd76fd0ec9f

commit b90b42560e05a3ab2c68042e38c15bd76fd0ec9f
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Mon Feb 04 21:08:44 2019

[iOS][Translate] Fixes translate infobar crashing in Release builds

Fixes the crash caused by |self.optionsButton| and |self.dismissButton|
being nil in release builds due to compiler optimization.

Bug: 910994
Change-Id: I5f158c1b1f0912d1ab0f33cbe8f0deb66a5b8068
Reviewed-on: https://chromium-review.googlesource.com/c/1452761
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628873}
[modify] https://crrev.com/b90b42560e05a3ab2c68042e38c15bd76fd0ec9f/ios/chrome/browser/ui/translate/translate_infobar_view.mm

Comment 21 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9e03ab8794ebfcdd04928770a8bc675843b7688

commit d9e03ab8794ebfcdd04928770a8bc675843b7688
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Mon Feb 04 23:45:29 2019

[iOS][Translate] Makes translate infobar language tab scroll more smoothly

- Makes it so that touches in content view won't always lead to tracking.
- Allows the scroll view to bounce.

Bug: 910994
Change-Id: I52fed1ce66a138a17feaba6109828bdeffc3d568
Reviewed-on: https://chromium-review.googlesource.com/c/1452772
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628939}
[modify] https://crrev.com/d9e03ab8794ebfcdd04928770a8bc675843b7688/ios/chrome/browser/ui/translate/translate_infobar_language_tab_strip_view.mm

Comment 22 by bugdroid, Feb 5

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7bd66905554acd2f01ba429f598a21e9ceee962

commit b7bd66905554acd2f01ba429f598a21e9ceee962
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Tue Feb 05 00:55:38 2019

[iOS][Translate] Adds auto-always/auto-never translate functionality to iOS

- Moves the logic to determine whether "Always Translate Language" and
  "Never Translate Language" should automatically trigger from Android's
  translate infobar to TranslateInfobarDelegate to share with iOS.
- Adds the logic to trigger Snackbars notifications for these events.

Bug: 910994
Change-Id: Iccfe36387eda6fd2377c35b200178c5e31a26521
Reviewed-on: https://chromium-review.googlesource.com/c/1443312
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628969}
[modify] https://crrev.com/b7bd66905554acd2f01ba429f598a21e9ceee962/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
[modify] https://crrev.com/b7bd66905554acd2f01ba429f598a21e9ceee962/chrome/browser/ui/android/infobars/translate_compact_infobar.h
[modify] https://crrev.com/b7bd66905554acd2f01ba429f598a21e9ceee962/components/translate/core/browser/translate_infobar_delegate.cc
[modify] https://crrev.com/b7bd66905554acd2f01ba429f598a21e9ceee962/components/translate/core/browser/translate_infobar_delegate.h
[modify] https://crrev.com/b7bd66905554acd2f01ba429f598a21e9ceee962/components/translate/core/browser/translate_prefs.cc
[modify] https://crrev.com/b7bd66905554acd2f01ba429f598a21e9ceee962/components/translate/core/browser/translate_prefs.h
[modify] https://crrev.com/b7bd66905554acd2f01ba429f598a21e9ceee962/ios/chrome/browser/translate/translate_infobar_controller.mm

Comment 23 by bugdroid, Feb 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b85d12f602d7ecb310d00d1bd673d1b3de81c65

commit 5b85d12f602d7ecb310d00d1bd673d1b3de81c65
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Thu Feb 07 21:28:54 2019

[iOS][Translate] Fix translate infobar being created in "translating" state


Currently TranslateInforbarView and its subviews assume that the translate
infobar is always created in "before translate" state, i.e., the source
language tab would be selected and the target language tab would be
unselected.

The translate infobar, however, can be created in "translating" or "after
translate" states, i.e., the target language tab would be in loading or
selected states respectively. This CL removes the assumed default state and
instead propagates the default state to the TranslateInforbarView (and its
subviews) after creation.

TBR=droger@

Bug: 910994
Change-Id: Ifdb280a104e61cde81c703a490f7637986b76a72
Reviewed-on: https://chromium-review.googlesource.com/c/1448807
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630049}
[modify] https://crrev.com/5b85d12f602d7ecb310d00d1bd673d1b3de81c65/ios/chrome/browser/translate/translate_infobar_controller.mm
[modify] https://crrev.com/5b85d12f602d7ecb310d00d1bd673d1b3de81c65/ios/chrome/browser/ui/translate/translate_infobar_language_tab_strip_view.mm
[modify] https://crrev.com/5b85d12f602d7ecb310d00d1bd673d1b3de81c65/ios/chrome/browser/ui/translate/translate_infobar_language_tab_view.mm
[modify] https://crrev.com/5b85d12f602d7ecb310d00d1bd673d1b3de81c65/ios/chrome/browser/ui/translate/translate_infobar_view.mm

Comment 24 by bugdroid, Feb 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/912678ffe2b54e8a80253055164a0762c6a4f6f6

commit 912678ffe2b54e8a80253055164a0762c6a4f6f6
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Feb 08 10:27:46 2019

[iOS][Translate] ios/chrome/browser/translate/OWNERS

replacing droger with mahmadi in the OWNERS file as the most recent author.

Bug: 910994
Change-Id: I91bde8f2ad436386155540396f538d179db2109a
Reviewed-on: https://chromium-review.googlesource.com/c/1448808
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630267}
[modify] https://crrev.com/912678ffe2b54e8a80253055164a0762c6a4f6f6/ios/chrome/browser/translate/OWNERS

Comment 25 by bugdroid, Feb 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fff1ec56e6d6908810353cfbaedf014072fa60b

commit 5fff1ec56e6d6908810353cfbaedf014072fa60b
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Fri Feb 08 19:30:42 2019

[iOS][Translate] HighlightButton for translate infobar language tab

- Uses HighlightButton (A button that fades opacity on highlight) instead
  of MDCFlatbutton.
- Uses Chrome blue tint for the title color instead of hardcoded RGB.

Bug: 910994
Change-Id: I076b72777595392add12606d29acd77147452539
Reviewed-on: https://chromium-review.googlesource.com/c/1453537
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630428}
[modify] https://crrev.com/5fff1ec56e6d6908810353cfbaedf014072fa60b/ios/chrome/browser/ui/translate/BUILD.gn
[modify] https://crrev.com/5fff1ec56e6d6908810353cfbaedf014072fa60b/ios/chrome/browser/ui/translate/translate_infobar_language_tab_view.mm

Comment 26 by bugdroid, Feb 18 (4 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee506c5149cb648d1b2eaf47558c0ad4275c3c15

commit ee506c5149cb648d1b2eaf47558c0ad4275c3c15
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Mon Feb 18 18:51:14 2019

[iOS][Translate] Hides the translate infobar in fullscreen mode.

It does so by making the LegacyInfobarContainerViewController a
FullscreenUIElement and have it observe the FullscreenController. The VC
the passes the fullscreen progress to the TranslateInfobarView which is
also a FullscreenUIElement so it can hide/show itself accordingly.

Bug: 910994
Change-Id: I6fc7e28707820b077c7126c2fef9e6637403e3f3
Reviewed-on: https://chromium-review.googlesource.com/c/1471006
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633132}
[modify] https://crrev.com/ee506c5149cb648d1b2eaf47558c0ad4275c3c15/ios/chrome/browser/ui/infobars/BUILD.gn
[modify] https://crrev.com/ee506c5149cb648d1b2eaf47558c0ad4275c3c15/ios/chrome/browser/ui/infobars/infobar_container_coordinator.mm
[modify] https://crrev.com/ee506c5149cb648d1b2eaf47558c0ad4275c3c15/ios/chrome/browser/ui/infobars/legacy_infobar_container_view_controller.h
[modify] https://crrev.com/ee506c5149cb648d1b2eaf47558c0ad4275c3c15/ios/chrome/browser/ui/infobars/legacy_infobar_container_view_controller.mm
[modify] https://crrev.com/ee506c5149cb648d1b2eaf47558c0ad4275c3c15/ios/chrome/browser/ui/translate/BUILD.gn
[modify] https://crrev.com/ee506c5149cb648d1b2eaf47558c0ad4275c3c15/ios/chrome/browser/ui/translate/translate_infobar_view.mm

Comment 27 by bugdroid, Feb 20 (2 days ago)

Project Member

Comment 28 by bugdroid, Feb 20 (2 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dbbed4cc68e89a553b4511fa3687937ba58f5fb

commit 0dbbed4cc68e89a553b4511fa3687937ba58f5fb
Author: Moe Ahmadi <mahmadi@chromium.org>
Date: Wed Feb 20 23:50:43 2019

[iOS][Translate] Fixes hiding the translate infobar in fullscreen mode.

The infobar's bottom padding was not being properly adjusted when entering
and exiting the fullscreen mode rapidly and frequently while it worked fine
when scrolling up/down slowly.

This CL fixes that issue by forcing the parent view of the infobar to lay
out its subviews immediately when the bottom padding is updated. When
updating constraint constants in an animation block, the parent view must
lay out its subviews for the change to properly animate.

Bug: 910994
Change-Id: Ia64307c628bbbdf35c40c926776485f07b4a38cd
Reviewed-on: https://chromium-review.googlesource.com/c/1479932
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#633953}
[modify] https://crrev.com/0dbbed4cc68e89a553b4511fa3687937ba58f5fb/ios/chrome/browser/ui/infobars/legacy_infobar_container_view_controller.mm

Sign in to add a comment