New issue
Advanced search Search tips

Issue 910991 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile navigation_list_model_unittest

Project Member Reported by noel@chromium.org, Dec 3

Issue description

 - remove the current html unittest
 - closure compile the code and the test


 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84b63242663d300f2ced1935301590eaf631ec7a

commit 84b63242663d300f2ced1935301590eaf631ec7a
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 03 07:22:55 2018

Closure compile navigation_list_model_unittest

 - remove navigation_list_model_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - fix MockFolderShortcutDataModel BUILD rule
   - MockFolderShortcutDataModel depends on ui:array_data_model
 - fix FolderShortcutsDataModel BUILD rule
   - FolderShortcutsDataModel depends on cr:event_target
 - add prefix comments to all test cases
   - test cases should describe their intent
 - fix Closure compile errors

Bug:  910991 
Change-Id: I8ba2ad3e917473b83011871d94cf17b80ad64d31
Reviewed-on: https://chromium-review.googlesource.com/c/1356731
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613016}
[modify] https://crrev.com/84b63242663d300f2ced1935301590eaf631ec7a/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/84b63242663d300f2ced1935301590eaf631ec7a/ui/file_manager/file_manager/foreground/js/BUILD.gn
[modify] https://crrev.com/84b63242663d300f2ced1935301590eaf631ec7a/ui/file_manager/file_manager/foreground/js/mock_folder_shortcut_data_model.js
[delete] https://crrev.com/471524edc84684945916953d4fbb32fa29418bbb/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html
[modify] https://crrev.com/84b63242663d300f2ced1935301590eaf631ec7a/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d65763ef346e84e3324087e884ee6241cbb23e06

commit d65763ef346e84e3324087e884ee6241cbb23e06
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 03 15:08:38 2018

'use strict' in mock_folder_shortcut_data_model.js

If we can use ...args @constructor, use strict as well.

Bug:  910991 
Change-Id: I6181423d7df7ab1a376650c657bdb3d8b0636f3c
Reviewed-on: https://chromium-review.googlesource.com/c/1358323
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613085}
[modify] https://crrev.com/d65763ef346e84e3324087e884ee6241cbb23e06/ui/file_manager/file_manager/foreground/js/mock_folder_shortcut_data_model.js

Sign in to add a comment