New issue
Advanced search Search tips

Issue 910989 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile progress_center_item_group_unittest

Project Member Reported by noel@chromium.org, Dec 3

Issue description

 - remove the current html unittest
 - closure compile the code and the test

 
Blocking: 860355
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c213c4f5383da84440632ff35c479cd60f3148f

commit 5c213c4f5383da84440632ff35c479cd60f3148f
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 03 05:03:06 2018

Closure compile progress_center_item_group_unittest

 - remove progress_center_item_group_unittest.html
 - add BUILD rules to auto-generate and compile the unittest
 - fix Closure compile errors

Bug:  910989 
Change-Id: I1fc5c09f6d13026b21eee4717dc303ab8beb8ee5
Reviewed-on: https://chromium-review.googlesource.com/c/1356730
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613005}
[modify] https://crrev.com/5c213c4f5383da84440632ff35c479cd60f3148f/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/5c213c4f5383da84440632ff35c479cd60f3148f/ui/file_manager/file_manager/foreground/js/BUILD.gn
[delete] https://crrev.com/5a79045229527a6ed77d622a55bfdfe5370b5709/ui/file_manager/file_manager/foreground/js/progress_center_item_group_unittest.html
[modify] https://crrev.com/5c213c4f5383da84440632ff35c479cd60f3148f/ui/file_manager/file_manager/foreground/js/progress_center_item_group_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment