Closure compile file_tasks_unittest |
|||
Issue description- add missing foreground/js/ui BUILD externs deps - remove the current html unittest - closure compile the code and the test
,
Dec 4
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b73ca4063532e5241e14123373f715eb9de09980 commit b73ca4063532e5241e14123373f715eb9de09980 Author: Noel Gordon <noel@chromium.org> Date: Tue Dec 04 22:44:58 2018 Closure compile file_tasks_unittest - remove file_tasks_unittest.html - add BUILD rules to auto-generate and compile this unittest - file_tasks depends on naming_controller: add a build dep - add unittest @types and document test cases and helpers - add failWithMessage(): undefined according to the compiler - define mockChrome: install it during unittest Setup() - fix Closure compiler errors and auto-format JS code No change in test behavior. Bug: 910975 Change-Id: I54d68d6a0364e677d74648eee819d2909368b0e2 Reviewed-on: https://chromium-review.googlesource.com/c/1360911 Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#613733} [modify] https://crrev.com/b73ca4063532e5241e14123373f715eb9de09980/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/b73ca4063532e5241e14123373f715eb9de09980/ui/file_manager/file_manager/foreground/js/BUILD.gn [delete] https://crrev.com/3317dddc5108187c00da3eb8637e44c3d455d055/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html [modify] https://crrev.com/b73ca4063532e5241e14123373f715eb9de09980/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfeaf55c4c3400a2557d478cf7c2fd44bfdced2d commit dfeaf55c4c3400a2557d478cf7c2fd44bfdced2d Author: Noel Gordon <noel@chromium.org> Date: Wed Dec 05 02:04:57 2018 file_tasks_unittest: Tweak test comments added in CL:1360911 CL:1360911 added prefix comments to each test case, using what details could be gleaned from re-reading the original CLs that added them. Tweak some of them for clarity. Comment-only change. Bug: 910975 Change-Id: I89eafd3a48083c55b09eb31e7cb2de04e1b452ce Reviewed-on: https://chromium-review.googlesource.com/c/1361751 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#613814} [modify] https://crrev.com/dfeaf55c4c3400a2557d478cf7c2fd44bfdced2d/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js
,
Dec 5
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Dec 3