New issue
Advanced search Search tips

Issue 910975 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile file_tasks_unittest

Project Member Reported by noel@chromium.org, Dec 2

Issue description

 - add missing foreground/js/ui BUILD externs deps
 - remove the current html unittest
 - closure compile the code and the test

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c057542b56106084df770c534fd76994b9025f9f

commit c057542b56106084df770c534fd76994b9025f9f
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 03 00:11:03 2018

Closure compile: add missing ui BUILD.gn extern dependencies

 - banners.js depends on type {chrome.echoPrivate}
   - add externs deps: externs/chrome_echo_private.js
 - combobutton.js and files_menu.js depend on type {PaperRipple}
   - add externs deps: externs/paper_elements.js
 - providers_menu.js depends on type {MenuItemUpdateEvent}
   - add externs deps: externs/menu_item_update_event.js
 - search_box.js depends on type {SearchItem}
   - add externs deps: externs/search_item.js
 - suggest_apps_dialog.js depends on {chrome.webstoreWidgetPrivate}
   - add externs deps: externs/chrome_webstore_widget_private.js

No change in test behavior, no new tests.

Bug:  910975 
Change-Id: Ib38947f6f6717b9767be6ec4472b1bbd16ac384a
Reviewed-on: https://chromium-review.googlesource.com/c/1356734
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612988}
[modify] https://crrev.com/c057542b56106084df770c534fd76994b9025f9f/ui/file_manager/file_manager/foreground/js/ui/BUILD.gn

Summary: Closure compile file_tasks_unittest (was: Closure compile the file_tasks_unittest)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b73ca4063532e5241e14123373f715eb9de09980

commit b73ca4063532e5241e14123373f715eb9de09980
Author: Noel Gordon <noel@chromium.org>
Date: Tue Dec 04 22:44:58 2018

Closure compile file_tasks_unittest

 - remove file_tasks_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - file_tasks depends on naming_controller: add a build dep
 - add unittest @types and document test cases and helpers
 - add failWithMessage(): undefined according to the compiler
 - define mockChrome: install it during unittest Setup()
 - fix Closure compiler errors and auto-format JS code

No change in test behavior.

Bug:  910975 
Change-Id: I54d68d6a0364e677d74648eee819d2909368b0e2
Reviewed-on: https://chromium-review.googlesource.com/c/1360911
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613733}
[modify] https://crrev.com/b73ca4063532e5241e14123373f715eb9de09980/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/b73ca4063532e5241e14123373f715eb9de09980/ui/file_manager/file_manager/foreground/js/BUILD.gn
[delete] https://crrev.com/3317dddc5108187c00da3eb8637e44c3d455d055/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html
[modify] https://crrev.com/b73ca4063532e5241e14123373f715eb9de09980/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfeaf55c4c3400a2557d478cf7c2fd44bfdced2d

commit dfeaf55c4c3400a2557d478cf7c2fd44bfdced2d
Author: Noel Gordon <noel@chromium.org>
Date: Wed Dec 05 02:04:57 2018

file_tasks_unittest: Tweak test comments added in CL:1360911

CL:1360911 added prefix comments to each test case, using what details
could be gleaned from re-reading the original CLs that added them.

Tweak some of them for clarity. Comment-only change.

Bug:  910975 
Change-Id: I89eafd3a48083c55b09eb31e7cb2de04e1b452ce
Reviewed-on: https://chromium-review.googlesource.com/c/1361751
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613814}
[modify] https://crrev.com/dfeaf55c4c3400a2557d478cf7c2fd44bfdced2d/ui/file_manager/file_manager/foreground/js/file_tasks_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment