New issue
Advanced search Search tips

Issue 910965 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Themes ignore Windows 10 accent colour titlebars

Reported by fadil.no...@gmail.com, Dec 2

Issue description

Chrome Version       : 73.0.3628.0
OS Version: 10.0


What steps will reproduce the problem?
1. Enable accent colour titlebars in Windows 10.
2. Install a theme that does not override titlebar colours, for example a theme with the below manifest.json :

{
    "manifest_version": 2,

    "name": "Blank Theme",
    "description": "Blank",
    "version": "0.1.0",

    "theme": {
    }
}


What is the expected result?
The theme should show an accent coloured titlebar. Here is a picture of Chrome without a theme installed; this is what Chrome should now look like. https://i.imgur.com/BaRfat9.png


What happens instead of that?
The titlebar colour is instead set to the default grey, as if Windows 10 accent colour titlebars were disabled: https://i.imgur.com/2yJZCuO.png


Please provide any additional information below. Attach a screenshot if
possible.
If you set the "Custom-drawn Windows 10 titlebar" flag to Disabled, then the accent-coloured titlebar will appear - though this is less than ideal for obvious reasons.


UserAgentString: Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3628.0 Safari/537.36



 
Components: UI>Browser>Themes
Owner: rameier@chromium.org
Status: Assigned (was: Unconfirmed)
I think we shouldn't actually override the frame color unless the theme sets a color/image.
Labels: Hotlist-DesktopUIConsider
Labels: Group-Themes
Labels: M-73 Target-73
Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged
Cc: phanindra.mandapaka@chromium.org
 Issue 915494  has been merged into this issue.
I reported essentially the same issue in  Bug 915494  yesterday. I noted there the following points:

If a frame colour is not defined in the theme, and if an accent coloured title bar is enabled in the Windows Settings panel, then Chrome ought to use the Windows accent colour from the Settings panel for the frame/title bar.

That way, theme designers can allow the user the flexibility to chose their own frame colour via the Windows Settings if they wish to. Alternatively, if the theme designer does not wish the user to chose their own frame colour, then the theme designer can easily override this by specifying a frame colour in the theme, which would take priority.

In short: if Chrome allows the user to specify the frame colour (via Settings panel) when *no* theme is applied, then it ought to also be possible to do this when a theme *is* applied, as long as the theme itself is not specifying any frame colour.
Owner: ----
Status: Available (was: Assigned)
Mass-unassigning bugs from rameier@.

Sign in to add a comment