New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 910936 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in content::WebContentsImpl::DidFinishNavigation

Project Member Reported by ClusterFuzz, Dec 2

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5708548782424064

Fuzzer: noel-image-surku
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000078
Crash State:
  content::WebContentsImpl::DidFinishNavigation
  content::NavigationHandleImpl::~NavigationHandleImpl
  content::NavigationHandleImpl::~NavigationHandleImpl
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_chromeos&range=612813:612825

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5708548782424064

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 2

Components: Internals>Core Internals>Sandbox>SiteIsolation
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: nasko@chromium.org
Owner: beccahughes@chromium.org
Based on the blame range, it looks that a likely candidate is r612820 by beccahughes, which introduced AudioFocusWebContentsObserver (appearing on the stack).
Status: Started (was: Untriaged)
I have a CL out to fix
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32fd6188bc344a693d19370069e919e96607e38d

commit 32fd6188bc344a693d19370069e919e96607e38d
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Dec 05 18:30:27 2018

[Audio Focus] Fix crash in AFWCO

Fix crash in AudioFocusWebContentsObserver.

BUG=911006, 910936 

Change-Id: I6789413b0356ab867f7e88b0815023f296603a96
Reviewed-on: https://chromium-review.googlesource.com/c/1361446
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614035}
[modify] https://crrev.com/32fd6188bc344a693d19370069e919e96607e38d/chrome/browser/apps/platform_apps/audio_focus_web_contents_observer.cc

Status: Fixed (was: Started)
Project Member

Comment 6 by ClusterFuzz, Dec 6

ClusterFuzz has detected this issue as fixed in range 614034:614040.

Detailed report: https://clusterfuzz.com/testcase?key=5708548782424064

Fuzzer: noel-image-surku
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000078
Crash State:
  content::WebContentsImpl::DidFinishNavigation
  content::NavigationHandleImpl::~NavigationHandleImpl
  content::NavigationHandleImpl::~NavigationHandleImpl
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_chromeos&range=612813:612825
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_chromeos&range=614034:614040

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5708548782424064

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Dec 6

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5708548782424064 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment