New issue
Advanced search Search tips

Issue 910896 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Indirect-leak in av_buffer_realloc

Project Member Reported by ClusterFuzz, Dec 2

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4785498314506240

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Indirect-leak
Crash Address: 
Crash State:
  av_buffer_realloc
  packet_alloc
  av_packet_make_refcounted
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=612912:612913

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4785498314506240

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 2

Components: Internals>Media>FFmpeg
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 2

Cc: xhw...@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Dec 2

Labels: Test-Predator-Auto-Owner
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/5caab9db3e50cc9259e88e88dbb6bdcc5574e894 (Fix spammy empty packets from slowing down demuxing.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fca7e34b0e457e3fc3b15cfb78290840f768df62

commit fca7e34b0e457e3fc3b15cfb78290840f768df62
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Mon Dec 03 22:12:05 2018

Fix leaks encountered while skipping packets.

Apparently zero byte, nullptr packets can still be attached to memory,
who knew!

BUG= 852093 , 910896 , 910898 , 910928 
TEST=local run shows no leaks.
R=tmathmeyer

Change-Id: Iff90057b02e37cb67b9d443ffeb92695e6e5c7f8
Reviewed-on: https://chromium-review.googlesource.com/c/1359060
Reviewed-by: Ted Meyer <tmathmeyer@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613282}
[modify] https://crrev.com/fca7e34b0e457e3fc3b15cfb78290840f768df62/media/filters/ffmpeg_demuxer.cc

Status: Fixed (was: Assigned)
Project Member

Comment 6 by ClusterFuzz, Dec 4

ClusterFuzz has detected this issue as fixed in range 613277:613293.

Detailed report: https://clusterfuzz.com/testcase?key=4785498314506240

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Fuzz target binary: media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Indirect-leak
Crash Address: 
Crash State:
  av_buffer_realloc
  packet_alloc
  av_packet_make_refcounted
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=612912:612913
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=613277:613293

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4785498314506240

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Dec 4

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4785498314506240 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment