New issue
Advanced search Search tips

Issue 910891 link

Starred by 1 user
Status: Fixed
Owner:
jam@chromium.org
Closed: Dec 3
Cc:
msramek@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: ConditionalCacheDeletionHelperBrowserTest.TimeAndURL



Sign in to add a comment

ConditionalCacheDeletionHelperBrowserTest.TimeAndURL is flaky

Project Member Reported by Findit, Dec 1 

Flaky test: ConditionalCacheDeletionHelperBrowserTest.TimeAndURL
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/45771
Test output log: https://chromium-swarm.appspot.com/task?id=4184697bd50e4610
Culprit (70.0% confidence): r612858
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyywELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKUAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQ1NzcxL25ldHdvcmtfc2VydmljZV9jb250ZW50X2Jyb3dzZXJ0ZXN0cy9RMjl1WkdsMGFXOXVZV3hEWVdOb1pVUmxiR1YwYVc5dVNHVnNjR1Z5UW5KdmQzTmxjbFJsYzNRdVZHbHRaVUZ1WkZWU1RBPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20ConditionalCacheDeletionHelperBrowserTest.TimeAndURL&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyywELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKUAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzQ1NzcxL25ldHdvcmtfc2VydmljZV9jb250ZW50X2Jyb3dzZXJ0ZXN0cy9RMjl1WkdsMGFXOXVZV3hEWVdOb1pVUmxiR1YwYVc5dVNHVnNjR1Z5UW5KdmQzTmxjbFJsYzNRdVZHbHRaVUZ1WkZWU1RBPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).

Comment 1 by guidou@chromium.org, Dec 3

Components: Tests>Flaky
Labels: -Sheriff-Chromium
Owner: jam@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by guidou@chromium.org, Dec 3 

Reverted r612858.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce8869d8fe1fdcd92a729e9de386c85c10fa0332

commit ce8869d8fe1fdcd92a729e9de386c85c10fa0332
Author: Guido Urdaneta <guidou@chromium.org>
Date: Mon Dec 03 16:35:40 2018

Revert "Convert ConditionalCacheDeletionHelperBrowserTest to not depend on URLRequestContext when network service is enabled."

This reverts commit 56a58d7d63a1aac6e1ada54979b2b730a5d0be53.

Reason for revert: FindIt determined that this CL makes ConditionalCacheDeletionHelperBrowserTest.TimeAndURL flaky.
FindIt's analysis looks correct.

Sample failed run:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%207%20Tests%20x64%20%281%29/45771

Sample logs:
../../content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc(107): error: Value of: TestCacheEntry(url)
  Actual: true
Expected: false
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00000001409F75B7+87]
	testing::internal::AssertHelper::operator= [0x00000001409F713E+78]
	content::ConditionalCacheDeletionHelperBrowserTest::CompareRemainingKeys [0x000000013FD458FE+510]
	content::ConditionalCacheDeletionHelperBrowserTest_TimeAndURL_Test::RunTestOnMainThread [0x000000013FD4634A+2410]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x0000000141C5413D+445]
	content::ShellBrowserMainParts::PreMainMessageLoopRun [0x0000000142564E24+68]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x0000000140CD4D3E+62]
	content::StartupTaskRunner::RunAllTasksNow [0x00000001410129BB+43]
	content::BrowserMainLoop::CreateStartupTasks [0x0000000140CD3B67+599]
	content::BrowserMainRunnerImpl::Initialize [0x0000000140CD6EDB+107]
	ShellBrowserMain [0x00000001447B04B5+21]
	content::ShellMainDelegate::RunProcess [0x00000001447AED2C+188]
	content::RunBrowserProcessMain [0x0000000140C020E9+89]
	content::ContentMainRunnerImpl::RunServiceManager [0x0000000140C02A1B+219]
	content::ContentMainRunnerImpl::Run [0x0000000140C0290E+238]
	service_manager::Main [0x00000001421C591A+554]
	content::ContentMain [0x0000000140C0202E+62]
	content::BrowserTestBase::SetUp [0x0000000141C53E44+1796]



Original change's description:
> Convert ConditionalCacheDeletionHelperBrowserTest to not depend on URLRequestContext when network service is enabled.
>
> Bug:  837753 
> Change-Id: I35b75299bcea1cc2b93a3c47dcbea036cc4e2d03
> Reviewed-on: https://chromium-review.googlesource.com/c/1357567
> Reviewed-by: Clark DuVall <cduvall@chromium.org>
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612858}

TBR=jam@chromium.org,cduvall@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  910891 
Change-Id: I541e21663a02cdedae6aa4991d5e8633890ffbbd
Reviewed-on: https://chromium-review.googlesource.com/c/1356946
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613119}
[modify] https://crrev.com/ce8869d8fe1fdcd92a729e9de386c85c10fa0332/content/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc

Comment 4 by jam@chromium.org, Dec 3

Cc: msramek@chromium.org
Status: Fixed (was: Assigned)
Filed bug 911171 to track making it not flaky when cache timing changes.
►

Sign in to add a comment