First item is automatically mouse selected when opening a menu from the default search engine page.
Reported by
mi...@mikelward.com,
Dec 1
|
|||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Steps to reproduce the problem: 1. Settings > Manage search engines 2. Try to delete a website I never use What is the expected behavior? When I click on the overflow menu, the actions are either all equally prominent, or Make Default is less prominent. What went wrong? If I click on the overflow menu then accidentally click in the same location a second time, some random search engine becomes the default search engine?? Did this work before? N/A Chrome version: 70.0.3538.102 Channel: n/a OS Version: Flash Version:
,
Dec 2
,
Dec 3
Able to reproduce the issue on chrome reported version# 70.0.3538.102, # 70.0.3538.110 and on latest chrome# 73.0.3678.0 with steps mentioned in comment# 0 using Linux 14.04, Windows-10 and Mac 10.12.6. As this issue is seen from M-60(60.0.3112.0), hence considering this issue as Non-Regression and marking it as Untriaged.
,
Dec 6
,
Dec 11
,
Dec 11
Routing to dpapad@ for WebUI The issue here is that the menu is opening right underneath the mouse cursor. The menu should be moved lower or to the right to avoid this issue (see existing 3-dot menu or context menu behavior, which avoids this).
,
Dec 11
,
Dec 11
@robliao: I will discuss this change in behavior with WebUIs UX and update this thread accordingly.
,
Dec 11
Assigning to johntlee: Per discussion with UX, we will try this for chrome://settings/searchEngines on Canary, and go from there. @johntlee: See [1] where we configure the placement of the action menu. [1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js?l=348
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb4dc3b7c7d5e3fc218a81266144cc45e194e5bd commit fb4dc3b7c7d5e3fc218a81266144cc45e194e5bd Author: John Lee <johntlee@chromium.org> Date: Wed Dec 12 04:09:13 2018 Settings WebUI: Show action menu below the trigger button on the Search Engines page Bug: 910890 Change-Id: I794b1574ed19b4e16391abe6035ffe16aa905452 Reviewed-on: https://chromium-review.googlesource.com/c/1372712 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#615812} [modify] https://crrev.com/fb4dc3b7c7d5e3fc218a81266144cc45e194e5bd/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js [modify] https://crrev.com/fb4dc3b7c7d5e3fc218a81266144cc45e194e5bd/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
,
Dec 13
Able to reproduce the issue on chrome reported version 70.0.3538.102 Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 17.10 on Chrome version #73.0.3639.0 as per the comment#0 Attaching screencast for reference. Observed "Action menu is seen below the trigger button in search engine page" Hence, the fix is working as expected. Adding the verified label. Thanks!
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/987d70e12ae59e27d95f21d081b4cdb77f055c48 commit 987d70e12ae59e27d95f21d081b4cdb77f055c48 Author: John Lee <johntlee@chromium.org> Date: Wed Jan 16 04:30:10 2019 Settings WebUI: Add offsets to the action menus that appear below an anchor Bug: 910890 Change-Id: I9ebcb291dc8b5730b397b1a07451c6078c7c6fbc Reviewed-on: https://chromium-review.googlesource.com/c/1405719 Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#623104} [modify] https://crrev.com/987d70e12ae59e27d95f21d081b4cdb77f055c48/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js
,
Jan 16
(6 days ago)
,
Jan 17
(5 days ago)
Able to reproduce the issue on chrome reported version 70.0.3538.102 Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #73.0.3674.0 as per the comment#0 Attaching screenshot for reference. Observed "Action menu is seen below three dot button in search engine page" Hence, the fix is working as expected. Adding the verified label. Thanks! |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by daneri...@gmail.com
, Dec 2