New issue
Advanced search Search tips
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 910890: First item is automatically mouse selected when opening a menu from the default search engine page.

Reported by mi...@mikelward.com, Dec 1

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36

Steps to reproduce the problem:
1. Settings > Manage search engines
2. Try to delete a website I never use

What is the expected behavior?
When I click on the overflow menu, the actions are either all equally prominent, or Make Default is less prominent.

What went wrong?
If I click on the overflow menu then accidentally click in the same location a second time, some random search engine becomes the default search engine??

Did this work before? N/A 

Chrome version: 70.0.3538.102  Channel: n/a
OS Version: 
Flash Version:
 

Comment 1 by daneri...@gmail.com, Dec 2

Each comment triggers notification emails. So, please do not post "+1 Me too!".

ű
Labels: Needs-Triage-M70

Comment 3 by viswa.karala@chromium.org, Dec 3

Cc: viswa.karala@chromium.org
Labels: Triaged-ET Target-73 M-73 FoundIn-71 FoundIn-70 FoundIn-73 FoundIn-72 OS-Mac OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on chrome reported version# 70.0.3538.102, # 70.0.3538.110 and on latest chrome# 73.0.3678.0 with steps mentioned in comment# 0 using Linux 14.04, Windows-10 and Mac 10.12.6. As this issue is seen from M-60(60.0.3112.0), hence considering this issue as Non-Regression and marking it as Untriaged.

Comment 4 by robliao@chromium.org, Dec 6

Labels: Hotlist-DesktopUIConsider

Comment 5 by robliao@chromium.org, Dec 11

Labels: Group-Windows_OS_Integration

Comment 6 by robliao@chromium.org, Dec 11

Components: -UI UI>Browser>WebUI
Labels: -Group-Windows_OS_Integration Group-WebUI
Owner: dpa...@chromium.org
Status: Assigned (was: Untriaged)
Summary: First item is automatically mouse selected when opening a menu from the default search engine page. (was: don't make "Make Default" so promenint)
Routing to dpapad@ for WebUI

The issue here is that the menu is opening right underneath the mouse cursor.
The menu should be moved lower or to the right to avoid this issue (see existing 3-dot menu or context menu behavior, which avoids this).

Comment 7 by robliao@chromium.org, Dec 11

Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged

Comment 8 by dpa...@chromium.org, Dec 11

@robliao: I will discuss this change in behavior with WebUIs UX and update this thread accordingly.

Comment 9 by dpa...@chromium.org, Dec 11

Cc: dpa...@chromium.org
Owner: johntlee@chromium.org
Assigning to johntlee: Per discussion with UX, we will try this for chrome://settings/searchEngines on Canary, and go from there.

@johntlee: See [1] where we configure the placement of the action menu.

[1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js?l=348

Comment 10 by johntlee@chromium.org, Dec 11

Tried it on the chrome://settings/searchEngines page. Screenshot attached.
Screenshot from 2018-12-11 13-14-09.png
19.2 KB View Download

Comment 11 by bugdroid1@chromium.org, Dec 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb4dc3b7c7d5e3fc218a81266144cc45e194e5bd

commit fb4dc3b7c7d5e3fc218a81266144cc45e194e5bd
Author: John Lee <johntlee@chromium.org>
Date: Wed Dec 12 04:09:13 2018

Settings WebUI: Show action menu below the trigger button on the Search Engines page

Bug:  910890 
Change-Id: I794b1574ed19b4e16391abe6035ffe16aa905452
Reviewed-on: https://chromium-review.googlesource.com/c/1372712
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615812}
[modify] https://crrev.com/fb4dc3b7c7d5e3fc218a81266144cc45e194e5bd/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js
[modify] https://crrev.com/fb4dc3b7c7d5e3fc218a81266144cc45e194e5bd/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js

Comment 12 by viswa.karala@chromium.org, Dec 13

Labels: TE-Verified-M73 TE-Verified-73.0.3639.0
Able to reproduce the issue on chrome reported version 70.0.3538.102
Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 17.10 on Chrome version #73.0.3639.0 as per the comment#0
Attaching screencast for reference.
Observed "Action menu is seen below the trigger button in search engine page"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!
910890.mp4
1.6 MB View Download

Comment 13 by johntlee@chromium.org, Jan 3

The menu has been moved up slightly closer to the three dots.
Screenshot from 2019-01-03 13-05-27.png
61.1 KB View Download

Comment 14 by bugdroid1@chromium.org, Jan 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/987d70e12ae59e27d95f21d081b4cdb77f055c48

commit 987d70e12ae59e27d95f21d081b4cdb77f055c48
Author: John Lee <johntlee@chromium.org>
Date: Wed Jan 16 04:30:10 2019

Settings WebUI: Add offsets to the action menus that appear below an anchor

Bug:  910890 
Change-Id: I9ebcb291dc8b5730b397b1a07451c6078c7c6fbc
Reviewed-on: https://chromium-review.googlesource.com/c/1405719
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623104}
[modify] https://crrev.com/987d70e12ae59e27d95f21d081b4cdb77f055c48/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

Comment 15 by johntlee@chromium.org, Jan 16

Status: Fixed (was: Assigned)

Comment 16 by viswa.karala@chromium.org, Jan 17

Labels: TE-Verified-73.0.3674.0
Able to reproduce the issue on chrome reported version 70.0.3538.102
Verified the fix on Mac 10.12.6, Windows-10 & Ubuntu 14.04 on Chrome version #73.0.3674.0 as per the comment#0
Attaching screenshot for reference.
Observed "Action menu is seen below three dot button in search engine page"
Hence, the fix is working as expected.
Adding the verified label.

Thanks!
910890.PNG
76.3 KB View Download

Sign in to add a comment