New issue
Advanced search Search tips

Issue 910877 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Download auto-resumptions : Remove auto-resumption handling logic from the Java

Project Member Reported by shaktisahu@chromium.org, Dec 1

Issue description

After we have implemented the auto-resumptions in native using task scheduler, we should clean it up from java from 
1 - DownloadManagerService
2 - DownloadResumptionScheduler and its clients
3 - Shared prefs 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ce691848ab9dfc73d60c62b0a4878db2c5a2001

commit 3ce691848ab9dfc73d60c62b0a4878db2c5a2001
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Thu Jan 17 21:26:04 2019

Disable auto-resumption in Java

This CL removes the auto-resumption logic from Java since the functionality
is now handled in native using AutoResumptionHandler.
1 - Added a feature DownloadAutoResumptionInNative
2 - Disabled the network observer and auto-resumption logic in DownloadMangerService
3 - Disabled resumption task scheduling through DownloadResumptionScheduler

Bug: 910877
Change-Id: I3feab14409be8037ce2230481cf223937c64248b
Reviewed-on: https://chromium-review.googlesource.com/c/1378854
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623851}
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadResumptionScheduler.java
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/chrome/android/junit/src/org/chromium/chrome/browser/download/DownloadResumptionSchedulerTest.java
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/chrome/browser/android/download/download_manager_service.cc
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/chrome/browser/android/feature_utilities.cc
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/chrome/browser/android/feature_utilities.h
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/components/download/public/common/auto_resumption_handler.cc
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/components/download/public/common/auto_resumption_handler.h
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/components/download/public/common/auto_resumption_handler_unittest.cc
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/components/download/public/common/download_features.cc
[modify] https://crrev.com/3ce691848ab9dfc73d60c62b0a4878db2c5a2001/components/download/public/common/download_features.h

Sign in to add a comment