New issue
Advanced search Search tips

Issue 910874 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 15
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Download auto-resumptions : Implement network listeners in native

Project Member Reported by shaktisahu@chromium.org, Dec 1

Issue description

For auto-resumptions, we need to observe the network connection events and record the connection types in native. We can probably reuse the network listeners used by download service for this purpose.
Design doc : http://go/download-auto-resumptions

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/335749d00e5cc0512d9e2bb25caba04f4841c60f

commit 335749d00e5cc0512d9e2bb25caba04f4841c60f
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Wed Dec 05 01:13:36 2018

Download auto-resumptions : Moved network listeners to a separate target

Since we are planning to reuse the network change listeners in regular
download auto-resumptions, it makes sense to move them to a separate target
outside of background service.

Bug:  910874 
Change-Id: Ie85b0c3bbc23b765b9b3a0cc8a21b4bebe86a877
Reviewed-on: https://chromium-review.googlesource.com/c/1353957
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613794}
[modify] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/chrome/android/BUILD.gn
[modify] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchFeedFlowTest.java
[modify] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchFlowTest.java
[modify] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/content/factory/BUILD.gn
[modify] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/content/factory/download_service_factory.cc
[modify] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/internal/background_service/BUILD.gn
[modify] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/internal/background_service/scheduler/device_status_listener.h
[modify] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/internal/background_service/scheduler/device_status_listener_unittest.cc
[modify] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/internal/background_service/test/BUILD.gn
[modify] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/internal/background_service/test/test_device_status_listener.cc
[add] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/network/BUILD.gn
[add] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/network/DEPS
[rename] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/network/android/java/src/org/chromium/components/download/NetworkStatusListenerAndroid.java
[rename] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/network/android/network_status_listener_android.cc
[rename] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/network/android/network_status_listener_android.h
[rename] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/network/network_status_listener.cc
[rename] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/network/network_status_listener.h
[rename] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/network/network_status_listener_impl.cc
[rename] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/network/network_status_listener_impl.h
[rename] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/network/network_status_listener_mac.cc
[rename] https://crrev.com/335749d00e5cc0512d9e2bb25caba04f4841c60f/components/download/network/network_status_listener_mac.h

Status: Fixed (was: Started)

Sign in to add a comment