New issue
Advanced search Search tips

Issue 910859 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Dec 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

luci.chromium.try/linux-blink-gen-property-trees is failing for "infra failure"

Project Member Reported by pdr@chromium.org, Dec 1

Issue description

This bot is failing:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-blink-gen-property-trees

Here's an example:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-blink-gen-property-trees/691

There was a recent change that could be related where I changed the test directory name:
https://crrev.com/612683

But I found an infra failure on the preceding run of the bot which did not include my rename patch:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-blink-gen-property-trees/684

I've gone through the logs and cannot determine what's actually causing the failure :(
 
Status: Closed (was: Untriaged)
This just ran without an infra failure so maybe this can be closed.
Owner: pdr@chromium.org
Status: Untriaged (was: Closed)
This is still failing on every run (except one run that just failed) so I'm reopening.

I have two guesses about the cause:
1) My patch to rename --enable-blink-gen-property-trees to --enable-blink-features=BlinkGenPropertyTrees (https://crrev.com/612683) broke the bot.
2) A typo in my patch (https://crrev.com/612683, patch to fix at https://chromium-review.googlesource.com/c/chromium/src/+/1356964) caused the bot to break.

I can't explain the failure that occurred before the patch landed. I'm going to land https://chromium-review.googlesource.com/c/chromium/src/+/1356964 and see if it helps.

I think I may need infra assistance to change the bot config to run blink web tests with --enable-blink-features=BlinkGenPropertyTrees instead of --enable-blink-gen-property-trees.
Cc: jbudorick@chromium.org
Labels: -Pri-3 Pri-2
Unfortunately the bot is still failing with my fix landed:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-blink-gen-property-trees/702
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be7e715b04fe968f75696cc937862debfacac022

commit be7e715b04fe968f75696cc937862debfacac022
Author: Philip Rogers <pdr@chromium.org>
Date: Mon Dec 03 21:24:17 2018

Update blink-gen-property-trees bot configuration to use new flag

In https://crrev.com/612683 the blink-gen-property-trees flag was
changed from --enable-blink-gen-property-trees to
--enable-blink-features=BlinkGenPropertyTrees. This patch updates the
bot configuration to use the new flag.

Bug:  910859 
Change-Id: I75bd3b947cf6fe5e8ec43a34a60e9cb7d61152c5
Reviewed-on: https://chromium-review.googlesource.com/c/1359131
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613250}
[modify] https://crrev.com/be7e715b04fe968f75696cc937862debfacac022/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/be7e715b04fe968f75696cc937862debfacac022/testing/buildbot/test_suite_exceptions.pyl

Mergedinto: 897673
Status: Duplicate (was: Untriaged)
I think this is actually 897673.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9119c242d042c8b17866d0500d7846044be887dd

commit 9119c242d042c8b17866d0500d7846044be887dd
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Dec 04 00:07:27 2018

Deduplicate layout test suite configurations.

webkit_layout_tests_isolated_scripts was identical to
chromium_webkit_isolated_scripts except for the configured shard
count.

Bug:  910859 
Change-Id: Ie014793403154978e08e47cebaf04631a45a1e24
Reviewed-on: https://chromium-review.googlesource.com/c/1359032
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613339}
[modify] https://crrev.com/9119c242d042c8b17866d0500d7846044be887dd/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/9119c242d042c8b17866d0500d7846044be887dd/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/9119c242d042c8b17866d0500d7846044be887dd/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/9119c242d042c8b17866d0500d7846044be887dd/testing/buildbot/waterfalls.pyl

Sign in to add a comment