[Tab loading animation] The new drop-in animation fails when a page is loading in another tab |
||||
Issue descriptionChrome Version: Canary Version 73.0.3627.0 OS: macOS 10.14.1 What steps will reproduce the problem? (1) Open a new tab and search for something e.g. "test" in the Omnibox. (2) Close the tab (3) Open a new tab and visit a page with a long loading time e.g. youtube.com or macrumors.com (4) Now search again for "test" in the same tab or in a second tab during the loading time of the visited page in step 3 What is the expected result? To see the drop-in animation in step 4. What happens instead? There is no drop-in animation. The blank favicon (the one with the fold in the right corner) and then the expected favicon appear without the animation. I mentioned this issue in issue 903806 . Maybe this is also caused by the blank favicon that I mentioned in issue 910847 ? Thanks for looking into it.
,
Dec 3
I wonder if this is related to Google and YouTube running on the same connection, there might not be a connecting state between these pages, so we might've kept the loading progress and fade in state from the earlier connection.
,
Dec 3
earlier *page*
,
Dec 4
Looks like this happens when you go from loading -> waiting, which currently does not reset the animation even though it should. CL up for review.
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5964e2682f6d392d82752c0760deb30633059a47 commit 5964e2682f6d392d82752c0760deb30633059a47 Author: Peter Boström <pbos@chromium.org> Date: Tue Dec 04 19:19:49 2018 Reset tab-icon animations for loading -> waiting Prevents showing earlier favicon from the earlier page load that did not finish (was still at loading). Also allows the favicon of the new page load to fade in. Bug: chromium:907642 , chromium:910848 Change-Id: I65fb44b7f432d5a0f4cd484f5a497f9b8a327c62 Reviewed-on: https://chromium-review.googlesource.com/c/1361282 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#613631} [modify] https://crrev.com/5964e2682f6d392d82752c0760deb30633059a47/chrome/browser/ui/views/tabs/tab_icon.cc
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72709886da48858f030a966bb286c00782029fb3 commit 72709886da48858f030a966bb286c00782029fb3 Author: Peter Boström <pbos@chromium.org> Date: Thu Dec 06 17:50:19 2018 Reset tab-icon animations for loading -> waiting Prevents showing earlier favicon from the earlier page load that did not finish (was still at loading). Also allows the favicon of the new page load to fade in. Bug: chromium:907642 , chromium:910848 Change-Id: I65fb44b7f432d5a0f4cd484f5a497f9b8a327c62 Reviewed-on: https://chromium-review.googlesource.com/c/1361282 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613631}(cherry picked from commit 5964e2682f6d392d82752c0760deb30633059a47) Reviewed-on: https://chromium-review.googlesource.com/c/1365975 Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#115} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/72709886da48858f030a966bb286c00782029fb3/chrome/browser/ui/views/tabs/tab_icon.cc
,
Dec 6
I believe this is fixed, but the flag is turned off. Reopen if you see it again once we start turning the flag on.
,
Dec 6
Many thanks. |
||||
►
Sign in to add a comment |
||||
Comment 1 by edwardjung@chromium.org
, Dec 3Owner: pbos@chromium.org
Status: Assigned (was: Untriaged)