New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 910826 link

Starred by 1 user
Status: Fixed
Owner:
█ updowndota@chromium.org
Last visit 26 days ago
Closed: Dec 2
Cc:
joelhockey@chromium.org
xiaoh...@chromium.org
█ ortuno@chromium.org
sa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

chromeos-chrome failing to build due to broken //chromeos/assistant/internal/action dependency

Project Member Reported by derat@chromium.org, Dec 1 
The Chrome OS PFQ builders are failing while trying to build Chrome 73.0.3627.0:

chromeos-chrome-73.0.3627.0_rc-r1: ERROR at //chromeos/services/assistant/BUILD.gn:80:7: Can't load input file.
chromeos-chrome-73.0.3627.0_rc-r1:       "//chromeos/assistant/internal/action",
chromeos-chrome-73.0.3627.0_rc-r1:       ^-------------------------------------
chromeos-chrome-73.0.3627.0_rc-r1: Unable to load:
chromeos-chrome-73.0.3627.0_rc-r1:   /home/chrome-bot/chrome_root/src/chromeos/assistant/internal/action/BUILD.gn
chromeos-chrome-73.0.3627.0_rc-r1: I also checked in the secondary tree for:
chromeos-chrome-73.0.3627.0_rc-r1:   /home/chrome-bot/chrome_root/src/build/secondary/chromeos/assistant/internal/action/BUILD.gn

See e.g. http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8928371302869465584.

This line in //chromeos/services/assistant/BUILD.gn looks like it was deleted by the relanded change at https://crrev.com/c/1356326. That reland looks like it was committed after the 3627 branch was cut.

Comment 1 by updowndota@chromium.org, Dec 2 

This failure is caused by this internal cl: https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/723309

Either the following internal cl: https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/723369
Or the reland cl: https://crrev.com/c/1356326
should be able to fix the failure. But it seems both of the cls missed the branch.

Comment 2 by derat@chromium.org, Dec 2

Status: Fixed (was: Assigned)
Thanks for the explanation. The PFQ passed with Saturday's nightly Chrome branch.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/270a6b263efd17f0a4baa8f31d7d7d3b3515df27

commit 270a6b263efd17f0a4baa8f31d7d7d3b3515df27
Author: Alexander Hendrich <hendrich@chromium.org>
Date: Fri Jan 04 19:41:02 2019

[M72] Revert changes to chromeos/services/assistant/BUILD.gn

This resets the branch to the state where CL:1352341 was reverted
(CL:1356164), but before the reland (CL:1356326).

Bug:  910826 
Change-Id: I95691821b4efad27850ee363b366351a8477c330
Reviewed-on: https://chromium-review.googlesource.com/c/1396151
Reviewed-by: David McMahon <djmm@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#566}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/270a6b263efd17f0a4baa8f31d7d7d3b3515df27/chromeos/services/assistant/BUILD.gn
Project Member

Comment 4 by cr-audit...@appspot.gserviceaccount.com, Jan 4

Labels: CommitLog-Audit-Violation Merge-Without-Approval M-72
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 270a6b263efd17f0a4baa8f31d7d7d3b3515df27 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required --
Project Member

Comment 5 by cr-audit...@appspot.gserviceaccount.com, Jan 4

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/270a6b263efd17f0a4baa8f31d7d7d3b3515df27

Commit: 270a6b263efd17f0a4baa8f31d7d7d3b3515df27
Author: hendrich@chromium.org
Commiter: hendrich@chromium.org
Date: 2019-01-04 19:41:02 +0000 UTC

[M72] Revert changes to chromeos/services/assistant/BUILD.gn

This resets the branch to the state where CL:1352341 was reverted
(CL:1356164), but before the reland (CL:1356326).

Bug:  910826 
Change-Id: I95691821b4efad27850ee363b366351a8477c330
Reviewed-on: https://chromium-review.googlesource.com/c/1396151
Reviewed-by: David McMahon <djmm@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#566}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
►

Sign in to add a comment