New issue
Advanced search Search tips

Issue 910814 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 828135



Sign in to add a comment

Non-blocking readback warnings should be counted in WebGL "too many errors" limit

Project Member Reported by kainino@chromium.org, Dec 1

Issue description

For most WebGL errors/messages, if there are "too many", they will no longer be printed to the console.
This doesn't seem to be true of the non-blocking readback performance warnings I added recently ( issue 828135 ):
https://cs.chromium.org/chromium/src/gpu/command_buffer/client/gles2_implementation.cc?l=5211&rcl=e13e548536440ee7c9104ccaa0f6190438a01605
https://cs.chromium.org/chromium/src/gpu/command_buffer/client/gles2_implementation.cc?l=5775&rcl=e13e548536440ee7c9104ccaa0f6190438a01605

But they should be limited by the same mechanism (WebGLRenderingContextBase::PrintWarningToConsole does this).

I'm not sure how gles2_cmd_decoder's performance warnings are wired up, or whether they are also limited, but they might help find the way to implement this.
https://cs.chromium.org/chromium/src/gpu/command_buffer/service/gles2_cmd_decoder.cc?l=234&rcl=ffeff6a71e41c4088e8f8b898ab381c54a41ef02
 
I'm actually not sure why these seem to be unlimited. They should through SetErrorMessageCallback, registered here:
https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc?l=1206&rcl=6dc55357255b5eb6b6195ba1a615447d54ae0f42
which seems to be subject to the error limit.

Sign in to add a comment