--disable-gl-error-limit no longer works, because service_utils: https://cs.chromium.org/chromium/src/gpu/command_buffer/service/service_utils.cc?l=125&rcl=38387d163c88ae4755028d85ce58a7b3c887883d checks the command line, but it should be checking the GpuPreferences: https://cs.chromium.org/chromium/src/gpu/config/gpu_preferences.h?l=111&rcl=e13e548536440ee7c9104ccaa0f6190438a01605 It seems possible that some of the other checks in service_utils.cc are also wrong now.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/104af6fb98cba827d7eab8783b5bc1ecfdbe4397 commit 104af6fb98cba827d7eab8783b5bc1ecfdbe4397 Author: James Darpinian <jdarpinian@chromium.org> Date: Thu Dec 06 03:24:55 2018 Fix --disable-gl-error-limit flag Respect GpuPreferences rather than checking the command line in the logger. Bug: 910812 Change-Id: I79e044d9a0e791a2603c36712755c759f1d04f1c Reviewed-on: https://chromium-review.googlesource.com/c/1364154 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#614258} [modify] https://crrev.com/104af6fb98cba827d7eab8783b5bc1ecfdbe4397/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/104af6fb98cba827d7eab8783b5bc1ecfdbe4397/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc [modify] https://crrev.com/104af6fb98cba827d7eab8783b5bc1ecfdbe4397/gpu/command_buffer/service/logger.cc [modify] https://crrev.com/104af6fb98cba827d7eab8783b5bc1ecfdbe4397/gpu/command_buffer/service/logger.h [modify] https://crrev.com/104af6fb98cba827d7eab8783b5bc1ecfdbe4397/gpu/command_buffer/service/raster_decoder.cc
Comment 1 by jdarpinian@chromium.org
, Dec 5Status: Started (was: Available)