New issue
Advanced search Search tips

Issue 910806 link

Starred by 4 users
Status: Started
Owner:
smbar...@chromium.org
Cc:
chirantan@chromium.org
smbar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 912189

Show other hotlists

Hotlists containing this issue:
LXD


Sign in to add a comment

uprev lxc/lxd to 3.0.3

Project Member Reported by smbar...@chromium.org, Dec 1 
LXC and LXD 3.0.3 are available. We should update.

Comment 1 by stgra...@stgraber.org, Dec 2 

Worth noting that one of the fixes in LXD 3.0.3 should very very significantly reduce the number of CPU wakeups coming from the LXD daemon.

I've seen reduction in wakeups up to 1/1000 of what they were before.
On my system, this has resulted in an extra 2 hours of battery life or so (20% increase), though unlike on chromebooks, I'm not running it inside a VM, so it's unclear what the VM layer's impact is on that.

Comment 4 by stgra...@stgraber.org, Dec 4 

Looking at the diff, you're dropping the EC384 change even though LXD 3.0.3 still ships with RSA for its certificates, so I think you want to keep that cherry-pick from master on top of your build of 3.0.3.

We didn't want to switch the default algorithm in 3.0.3 as that change only very recently happened in the feature branch and may have side-effects for some of our users that we wanted to better understand before looking at pushing that into the LTS branch.

If all goes well, we may be pushing it into 3.0.4 in a few months.

Comment 5 by smbar...@chromium.org, Dec 4

Owner: smbar...@chromium.org
Status: Started (was: Available)
Thanks for catching that! I checked for the other patches but I missed that one. I've added it back in https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1359780

Comment 6 by smbar...@chromium.org, Dec 4

Cc: chirantan@chromium.org
Looks like we're failing to start the container consistently on 3.0.3. I'm going to revert for now until I can find the cause.

lxc penguin 20181204225815.889 WARN     initutils - initutils.c:setproctitle:324 - Invalid argument - Failed to set cmdline
lxc penguin 20181204225816.210 WARN     conf - conf.c:lxc_map_ids:2919 - newuidmap is lacking necessary privileges
lxc penguin 20181204225816.210 WARN     conf - conf.c:lxc_map_ids:2925 - newgidmap is lacking necessary privileges
lxc penguin 20181204225816.229 WARN     conf - conf.c:lxc_map_ids:2919 - newuidmap is lacking necessary privileges
lxc penguin 20181204225816.229 WARN     conf - conf.c:lxc_map_ids:2925 - newgidmap is lacking necessary privileges
lxc penguin 20181204225816.253 ERROR    dir - storage/dir.c:dir_mount:198 - No such file or directory - Failed to mount "/mnt/stateful/lxd/containers/penguin/rootfs" on "/var/lib/lxc/rootfs"
lxc penguin 20181204225816.253 ERROR    conf - conf.c:lxc_mount_rootfs:1326 - Failed to mount rootfs "/mnt/stateful/lxd/containers/penguin/rootfs" onto "/var/lib/lxc/rootfs" with options "(null)"
lxc penguin 20181204225816.253 ERROR    conf - conf.c:lxc_setup_rootfs_prepare_root:3445 - Failed to setup rootfs for
lxc penguin 20181204225816.253 ERROR    conf - conf.c:lxc_setup:3498 - Failed to setup rootfs
lxc penguin 20181204225816.253 ERROR    start - start.c:do_start:1263 - Failed to setup container "penguin"
lxc penguin 20181204225816.254 ERROR    sync - sync.c:__sync_wait:62 - An error occurred in another process (expected sequence number 5)
lxc penguin 20181204225816.254 WARN     network - network.c:lxc_delete_network_priv:2589 - Operation not permitted - Failed to remove interface "eth0" with index 4
lxc penguin 20181204225816.254 ERROR    lxccontainer - lxccontainer.c:wait_on_daemonized_start:842 - Received container state "ABORTING" instead of "RUNNING"
lxc penguin 20181204225816.256 ERROR    start - start.c:__lxc_start:1939 - Failed to spawn container "penguin"
lxc penguin 20181204225816.257 WARN     conf - conf.c:lxc_map_ids:2919 - newuidmap is lacking necessary privileges
lxc penguin 20181204225816.257 WARN     conf - conf.c:lxc_map_ids:2925 - newgidmap is lacking necessary privileges
lxc 20181204225816.278 WARN     commands - commands.c:lxc_cmd_rsp_recv:132 - Connection reset by peer - Failed to receive response for command "get_state"

Comment 7 by stgra...@stgraber.org, Dec 4 

Hmm, that's odd, any chance you can check whether both /mnt/stateful/lxd/containers/penguin/rootfs and /var/lib/lxc/rootfs both exist?

I believe you're running on btrfs, so I'd expect the source path to always be mounted (with /mnt/stateful/lxd/containers/penguin being a symlink to /mnt/stateful/lxd/storage-pools/default/containers/penguin) and /var/lib/lxc/rootfs to be used as temporary mount paths prior to pivot.

That path needs to exist but shouldn't contain anything as it's only used for mount namespace setup.

I'm unsure why upgrading from 3.0.1 to 3.0.3 would change that. That /var/lib/lxc/rootfs path is non-standard so is probably specified directly as an argument to lxc's configure in your build scripts.

Comment 9 by smbar...@chromium.org, Dec 12

Blockedon: 912189
re #7 I didn't keep the disk image around from that failure :(

The main failure we keep on hitting is issue 912189 with op.Wait() hanging forever. I haven't dug into that yet; for now we should revert.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8469e98c6ac89bda5a85e74842f485e4847fb48d

commit 8469e98c6ac89bda5a85e74842f485e4847fb48d
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Dec 13 04:10:04 2018

Revert "app-emulation/lxd: add back ec384 patch"

This reverts commit 8609a91aabd60880c6db3383f81e4b4dceff78d1.

Reason for revert: We are failing tests with LXD 3.0.3

BUG=chromium:912189,chromium:910806
TEST=emerge-tatl lxd

Change-Id: I1ebcda7f82dd7fa55fdd843681d53e305e4ddbc4
Reviewed-on: https://chromium-review.googlesource.com/1373924
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[rename] https://crrev.com/8469e98c6ac89bda5a85e74842f485e4847fb48d/app-emulation/lxd/lxd-3.0.3-r3.ebuild
[modify] https://crrev.com/8469e98c6ac89bda5a85e74842f485e4847fb48d/app-emulation/lxd/lxd-3.0.3.ebuild
[delete] https://crrev.com/41d9bfb0500e8a0437f0d8d673d5dbf77efe6b40/app-emulation/lxd/files/lxd-3.0.3-cert-ec384.patch
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3693113b01774e6bf2dc26bfefe511f045df25f6

commit 3693113b01774e6bf2dc26bfefe511f045df25f6
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Dec 13 04:10:05 2018

Revert "app-emulation/lxd: uprev to 3.0.3"

This reverts commit 9591c468995a86c316b8ce7eaf9a4516a53ae88b.

Reason for revert: We are failing tests with LXD 3.0.3

BUG=chromium:912189,chromium:910806
TEST=emerge-tatl lxd

Change-Id: I43421193015d7d690cbf3d53188875b94293e6e5
Reviewed-on: https://chromium-review.googlesource.com/1373925
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/3693113b01774e6bf2dc26bfefe511f045df25f6/app-emulation/lxd/files/lxd-3.0.2-dqlite-timeout.patch
[add] https://crrev.com/3693113b01774e6bf2dc26bfefe511f045df25f6/app-emulation/lxd/lxd-3.0.2-r5.ebuild
[delete] https://crrev.com/8469e98c6ac89bda5a85e74842f485e4847fb48d/app-emulation/lxd/lxd-3.0.3-r3.ebuild
[rename] https://crrev.com/3693113b01774e6bf2dc26bfefe511f045df25f6/app-emulation/lxd/lxd-3.0.2.ebuild
[modify] https://crrev.com/3693113b01774e6bf2dc26bfefe511f045df25f6/app-emulation/lxd/Manifest
[add] https://crrev.com/3693113b01774e6bf2dc26bfefe511f045df25f6/app-emulation/lxd/files/lxd-3.0.2-cert-ec384.patch
[add] https://crrev.com/3693113b01774e6bf2dc26bfefe511f045df25f6/app-emulation/lxd/files/lxd-3.0.2-pass-all-usb.patch
►

Sign in to add a comment