Safe Browsing main frame interstitials should be committed error pages instead of overlays.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ec822d31671f6941cc60159fd576c52a61dce04 commit 2ec822d31671f6941cc60159fd576c52a61dce04 Author: Carlos IL <carlosil@chromium.org> Date: Wed Dec 12 02:08:51 2018 Added SB committed interstitials flag. Added SB committed interstitials flag, and changed the cancellation error code to ERR_BLOCKED_BY_CLIENT if the flag is set. Bug: 910794 Change-Id: I43853600bee91f7fdeea78409248994372fd7091 Reviewed-on: https://chromium-review.googlesource.com/c/1364330 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615782} [modify] https://crrev.com/2ec822d31671f6941cc60159fd576c52a61dce04/components/safe_browsing/browser/browser_url_loader_throttle.cc [modify] https://crrev.com/2ec822d31671f6941cc60159fd576c52a61dce04/components/safe_browsing/features.cc [modify] https://crrev.com/2ec822d31671f6941cc60159fd576c52a61dce04/components/safe_browsing/features.h [modify] https://crrev.com/2ec822d31671f6941cc60159fd576c52a61dce04/components/safe_browsing/renderer/BUILD.gn [modify] https://crrev.com/2ec822d31671f6941cc60159fd576c52a61dce04/components/safe_browsing/renderer/renderer_url_loader_throttle.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c3ded82e0afa54c4cbd574b5904edd0f8ef8996e commit c3ded82e0afa54c4cbd574b5904edd0f8ef8996e Author: Carlos IL <carlosil@chromium.org> Date: Thu Dec 13 21:44:59 2018 Cancel resource load if SB committed interstitials are enabled With committed interstitials, SB-flagged navigations should be cancelled so they trigger the WillFailRequest path in navigation throttles. In a future CL, a navigation throttle will be added that will create the interstitial (and display it). Bug: 910794 Change-Id: If661d17a09cb6892bf5e5493c6bc2df1b2325525 Reviewed-on: https://chromium-review.googlesource.com/c/1371065 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#616443} [modify] https://crrev.com/c3ded82e0afa54c4cbd574b5904edd0f8ef8996e/chrome/browser/safe_browsing/url_checker_delegate_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ee307efbbf52bf86b95561819679bd733d5dcd2 commit 4ee307efbbf52bf86b95561819679bd733d5dcd2 Author: Carlos IL <carlosil@chromium.org> Date: Sat Dec 22 03:19:00 2018 Add safe browsing navigation throttle As part of Safe Browsing committed interstitials, this CL adds a navigation throttle that checks if a failed navigation was due to a SB hit, and if so creates and shows an interstitial. Bindings for commands will be added in a separate CL. Bug: 910794 Change-Id: I28053de0252a005ff2896b9b17ac83c02d5d2d6f Reviewed-on: https://chromium-review.googlesource.com/c/1370502 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#618721} [modify] https://crrev.com/4ee307efbbf52bf86b95561819679bd733d5dcd2/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/4ee307efbbf52bf86b95561819679bd733d5dcd2/chrome/browser/safe_browsing/BUILD.gn [modify] https://crrev.com/4ee307efbbf52bf86b95561819679bd733d5dcd2/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc [add] https://crrev.com/4ee307efbbf52bf86b95561819679bd733d5dcd2/chrome/browser/safe_browsing/safe_browsing_navigation_throttle.cc [add] https://crrev.com/4ee307efbbf52bf86b95561819679bd733d5dcd2/chrome/browser/safe_browsing/safe_browsing_navigation_throttle.h [modify] https://crrev.com/4ee307efbbf52bf86b95561819679bd733d5dcd2/chrome/browser/safe_browsing/ui_manager.cc [modify] https://crrev.com/4ee307efbbf52bf86b95561819679bd733d5dcd2/chrome/browser/safe_browsing/ui_manager.h [modify] https://crrev.com/4ee307efbbf52bf86b95561819679bd733d5dcd2/chrome/browser/safe_browsing/url_checker_delegate_impl.cc [modify] https://crrev.com/4ee307efbbf52bf86b95561819679bd733d5dcd2/components/safe_browsing/base_ui_manager.h
Comment 1 by vakh@chromium.org
, Dec 7