vmc share is broken |
||||||
Issue descriptionhttps://chromium-review.googlesource.com/c/chromiumos/platform2/+/1317278 changed the default storage location used by seneschal_client to "My Files" instead of "Downloads". This broke the `vmc share` command, which expects the storage location to default to downloads. I have a CL out for review to fix this.
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/ae64d476b0126e23d7e2d61c0f20ae337114d29f commit ae64d476b0126e23d7e2d61c0f20ae337114d29f Author: Chirantan Ekbote <chirantan@chromium.org> Date: Sat Dec 01 09:08:44 2018 crosh: Fix vmc share CL:1317278 changed the default storage location used by seneschal_client to be "My Files" instead of "Downloads". This broke the `vmc share` command. Fix it by specifying downloads as the storage location on the command line. BUG= chromium:910786 TEST=`vmc share` completes successfully Change-Id: Ia418e568e79634b23cd5e68b43391929040af345 Signed-off-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1357649 Reviewed-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/ae64d476b0126e23d7e2d61c0f20ae337114d29f/crosh/crosh
,
Dec 2
,
Dec 3
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 3
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/68887beff4cc98c3d5d33577a46f9e3cb8a69c69 commit 68887beff4cc98c3d5d33577a46f9e3cb8a69c69 Author: Chirantan Ekbote <chirantan@chromium.org> Date: Mon Dec 03 05:34:08 2018 crosh: Fix vmc share CL:1317278 changed the default storage location used by seneschal_client to be "My Files" instead of "Downloads". This broke the `vmc share` command. Fix it by specifying downloads as the storage location on the command line. BUG= chromium:910786 TEST=`vmc share` completes successfully Change-Id: Ia418e568e79634b23cd5e68b43391929040af345 Signed-off-by: Chirantan Ekbote <chirantan@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1357649 Reviewed-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit ae64d476b0126e23d7e2d61c0f20ae337114d29f) Reviewed-on: https://chromium-review.googlesource.com/c/1358083 [modify] https://crrev.com/68887beff4cc98c3d5d33577a46f9e3cb8a69c69/crosh/crosh
,
Dec 3
,
Dec 6
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 6
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/af780cfa3ee34663a2b5e71d8fa7886feae4660c commit af780cfa3ee34663a2b5e71d8fa7886feae4660c Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Dec 07 06:06:41 2018 crosh: vmc share: use myfiles storage_location MyFilesVolume flag is now turned on in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1295692 BUG= chromium:910786 TEST=`vmc share` completes successfully Change-Id: Ia4829833459156625225d990fa04c8c42f6bc33a Reviewed-on: https://chromium-review.googlesource.com/1359632 Commit-Ready: Joel Hockey <joelhockey@chromium.org> Tested-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/af780cfa3ee34663a2b5e71d8fa7886feae4660c/crosh/crosh |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by chirantan@chromium.org
, Dec 1