New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 910783 link

Starred by 1 user
Status: Fixed
Owner:
█ kbr@chromium.org
OOO until 2019-01-24
Closed: Dec 3
Cc:
kainino@chromium.org
vmi...@chromium.org
piman@chromium.org
dsinclair@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue v8:8536
issue 905008



Sign in to add a comment

Allow --enable-gpu-client-logging in Release builds without dcheck_always_on=true

Project Member Reported by kbr@chromium.org, Dec 1 
In order to track down some kinds of bugs affecting users' applications it's sometimes necessary to use --enable-gpu-client-logging in a Release build where dcheck_always_on isn't set. A new GN argument enable_gpu_client_logging should be added to support this.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dca586f615933b3ca3cbfe25f681dcdae72eb2f8

commit dca586f615933b3ca3cbfe25f681dcdae72eb2f8
Author: Kenneth Russell <kbr@chromium.org>
Date: Sat Dec 01 01:53:19 2018

Add and document enable_gpu_client_logging GN argument.

This can be used in Release builds without dcheck_always_on=true, and
allows the --enable-gpu-client-logging command line argument to work.

Bug:  910783 
Change-Id: I0720b7eb0c735de4d08ba50d69b41060eb387d63
Reviewed-on: https://chromium-review.googlesource.com/c/1357623
Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612900}
[modify] https://crrev.com/dca586f615933b3ca3cbfe25f681dcdae72eb2f8/docs/gpu/debugging_gpu_related_code.md
[modify] https://crrev.com/dca586f615933b3ca3cbfe25f681dcdae72eb2f8/gpu/command_buffer/client/BUILD.gn
[modify] https://crrev.com/dca586f615933b3ca3cbfe25f681dcdae72eb2f8/gpu/command_buffer/client/logging.h

Comment 2 by kbr@chromium.org, Dec 3

Status: Fixed (was: Started)
►

Sign in to add a comment