New issue
Advanced search Search tips

Issue 910774 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 3
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile the file_operation_handler_unittest

Project Member Reported by noel@chromium.org, Nov 30

Issue description

 - remove the current html unittest
 - closure compile the code and the test
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bb6b2a84fd9726d2f2aecb49a75ee906e6a97dd

commit 0bb6b2a84fd9726d2f2aecb49a75ee906e6a97dd
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 03 03:39:41 2018

Closure compile file_operation_handler_unittest

 - remove file_operation_handler_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - document, add Closure @type's, and auto-format the unittest
 - fix Closure compile errors

No change in test behavior, no new tests.

Bug:  910774 
Change-Id: Ie91e8ac6951821af05cd5c8482b7be7ae2c3b04f
Reviewed-on: https://chromium-review.googlesource.com/c/1356726
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612990}
[modify] https://crrev.com/0bb6b2a84fd9726d2f2aecb49a75ee906e6a97dd/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/0bb6b2a84fd9726d2f2aecb49a75ee906e6a97dd/ui/file_manager/file_manager/background/js/BUILD.gn
[delete] https://crrev.com/5b3c3ff0a2b5b3f8410fbc95b98de29627d4aed6/ui/file_manager/file_manager/background/js/file_operation_handler_unittest.html
[modify] https://crrev.com/0bb6b2a84fd9726d2f2aecb49a75ee906e6a97dd/ui/file_manager/file_manager/background/js/file_operation_handler_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment