PaintOpReader dump without crashing failing on paths |
||||||||||
Issue descriptionFrom https://bugs.chromium.org/p/chromium/issues/detail?id=906510#c30 https://goto.google.com/myvco is a list of crashes failing due to the DumpWithoutCrashing added in https://chromium-review.googlesource.com/c/chromium/src/+/1351386 These are extremely noisy and all look like they are coming from paths and all on mac only, which is quite curious. This should be investigated before launching on Mac.
,
Nov 30
I can step through the code in the report until, "helper.Read(&op->path);" but it doesn't tell me at which line exactly in that function the SetInvalid happens at. Maybe we can try repro-ing with one of the URLs on the crashes. The most common one is "chrome://gpu/VizProcessTransportFactory::CreateContextProvider", does that mean its the browser's raster worker?
,
Dec 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a841a18c3fe2b741d0a6a8a0791949c58dc265f0 commit a841a18c3fe2b741d0a6a8a0791949c58dc265f0 Author: Adrienne Walker <enne@chromium.org> Date: Sat Dec 01 18:40:15 2018 cc: Remove PaintOpReader DumpWithoutCrashing This has turned up some bugs, but is being incredibly noisy on the bots. Remove the crash report until this is solved. Bug: 910772 Change-Id: I9f2a7f7a1a758abe20a2304ad10da4a12fb4b9db Reviewed-on: https://chromium-review.googlesource.com/c/1357619 Reviewed-by: Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#612935} [modify] https://crrev.com/a841a18c3fe2b741d0a6a8a0791949c58dc265f0/cc/paint/paint_op_reader.cc
,
Dec 3
CL from C#3 first landed in 73.0.3628.0 and there have been no Dump without crashes reported in M-72 since 73.0.3627.0 on Mac. Need the CL to be merged to M-72 branch as well.(see Issue 906510 C#28, C#30 for context). enne@: Could you please get the CL merged to M-72. Thank you!
,
Dec 6
,
Dec 7
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99592c8fdabd5c5a79fb853eae3e39dde9d19d84 commit 99592c8fdabd5c5a79fb853eae3e39dde9d19d84 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Dec 07 18:23:47 2018 cc: Remove PaintOpReader DumpWithoutCrashing This has turned up some bugs, but is being incredibly noisy on the bots. Remove the crash report until this is solved. TBR=enne@chromium.org (cherry picked from commit a841a18c3fe2b741d0a6a8a0791949c58dc265f0) Bug: 910772 Change-Id: I9f2a7f7a1a758abe20a2304ad10da4a12fb4b9db Reviewed-on: https://chromium-review.googlesource.com/c/1357619 Reviewed-by: Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612935} Reviewed-on: https://chromium-review.googlesource.com/c/1368127 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#139} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/99592c8fdabd5c5a79fb853eae3e39dde9d19d84/cc/paint/paint_op_reader.cc
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99592c8fdabd5c5a79fb853eae3e39dde9d19d84 Commit: 99592c8fdabd5c5a79fb853eae3e39dde9d19d84 Author: wangxianzhu@chromium.org Commiter: wangxianzhu@chromium.org Date: 2018-12-07 18:23:47 +0000 UTC cc: Remove PaintOpReader DumpWithoutCrashing This has turned up some bugs, but is being incredibly noisy on the bots. Remove the crash report until this is solved. TBR=enne@chromium.org (cherry picked from commit a841a18c3fe2b741d0a6a8a0791949c58dc265f0) Bug: 910772 Change-Id: I9f2a7f7a1a758abe20a2304ad10da4a12fb4b9db Reviewed-on: https://chromium-review.googlesource.com/c/1357619 Reviewed-by: Khushal <khushalsagar@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612935} Reviewed-on: https://chromium-review.googlesource.com/c/1368127 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#139} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 2
More mac oopr issues
,
Jan 3
I'm guessing this is related to the bug in issue 912282 . I'm going to wait for the fix for that bug to land and stick and then reland the DumpWithoutCrashing.
,
Jan 3
Out of curiosity, if it was issue 912282 , why would it only be happening on mac?
,
Jan 3
Re #11, good point. It would be odd if this was mac only. I just checked and the crash dumps were reported from all platforms: https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BDump+without+crash%5D+cc%3A%3APaintOpReader%3A%3ARead%27
,
Jan 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64f874d0c46cc1d1ae915656e1b41469f5445493 commit 64f874d0c46cc1d1ae915656e1b41469f5445493 Author: Khushal Sagar <khushalsagar@chromium.org> Date: Thu Jan 10 19:31:42 2019 cc: Reinstate crash dumps for paint de-serialization failures. Reinstate crash dumps for deserialiation failures during RasterCHROMIUM in the GPU process. This was previously disabled due to a paint caching bug which has now been fixed (see crbug.com/912282 ). Also rate limit the crash dumps to 10%. Generating the dump is an expensive operation which holds the GPU main thread. Its good practice to limit the instances where we do it. R=enne@chromium.org Bug: 910772 Change-Id: Ie52ac3023b126570d097e19b9f7c7e95cc85d062 Reviewed-on: https://chromium-review.googlesource.com/c/1401884 Commit-Queue: enne <enne@chromium.org> Reviewed-by: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#621705} [modify] https://crrev.com/64f874d0c46cc1d1ae915656e1b41469f5445493/cc/paint/paint_op_reader.cc
,
Jan 14
There has been no spike since the change in #13 to reland the crash dumps for paint serialization failures landed. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by enne@chromium.org
, Nov 30