New issue
Advanced search Search tips

Issue 910758 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocking:
issue 875046



Sign in to add a comment

Remove TokenBinding code in AW layer

Project Member Reported by ntfschr@chromium.org, Nov 30

Issue description

See http://b/119576150

Tokenbinding never fully launched, and is no longer supported in chromium.
 
Blockedon: 875046
Cc: nhar...@chromium.org
Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OkdLUyYmY1E/discussion

I have a WIP patch to remove WebView support (trying to strip away as much as possible from glue/ as well): http://crrev/c/1353924 (FYI nharper@)
Is this actually blocked on 875046, or should that relationship be the other way around?
Blockedon: -875046
Blocking: 875046
Was blocked on changing the cookie API (http://crrev/c/1325942), but now we can remove everything. Inverting the relationship seems fine now.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03f011b451f7d4d9b879d0403a6c3446b5831c7a

commit 03f011b451f7d4d9b879d0403a6c3446b5831c7a
Author: Nate Fischer <ntfschr@chromium.org>
Date: Tue Dec 04 22:52:07 2018

AW: remove token binding code

This removes WebView's token binding code, since this is no longer
supported by chromium. This removes everything in the AW-layer, and
most of the glue layer (we're limited in that we must implement the
getTokenBindingService() method.

Bug:  910758 
Test: it compiles
Test: install Google WebView on P device, it starts up OK
Change-Id: Id5a1335a67b2224148b9280c48032b7f5f658685
Reviewed-on: https://chromium-review.googlesource.com/c/1357762
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613735}
[modify] https://crrev.com/03f011b451f7d4d9b879d0403a6c3446b5831c7a/android_webview/BUILD.gn
[modify] https://crrev.com/03f011b451f7d4d9b879d0403a6c3446b5831c7a/android_webview/browser/net/aw_url_request_context_getter.cc
[delete] https://crrev.com/887503b35719e338455c55f513d0168230f727d0/android_webview/browser/net/token_binding_manager.cc
[delete] https://crrev.com/887503b35719e338455c55f513d0168230f727d0/android_webview/browser/net/token_binding_manager.h
[delete] https://crrev.com/887503b35719e338455c55f513d0168230f727d0/android_webview/browser/token_binding_manager_bridge.cc
[modify] https://crrev.com/03f011b451f7d4d9b879d0403a6c3446b5831c7a/android_webview/glue/BUILD.gn
[modify] https://crrev.com/03f011b451f7d4d9b879d0403a6c3446b5831c7a/android_webview/glue/java/src/com/android/webview/chromium/GlueApiHelperForN.java
[delete] https://crrev.com/887503b35719e338455c55f513d0168230f727d0/android_webview/glue/java/src/com/android/webview/chromium/TokenBindingManagerAdapter.java
[modify] https://crrev.com/03f011b451f7d4d9b879d0403a6c3446b5831c7a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumAwInit.java
[modify] https://crrev.com/03f011b451f7d4d9b879d0403a6c3446b5831c7a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[delete] https://crrev.com/887503b35719e338455c55f513d0168230f727d0/android_webview/java/src/org/chromium/android_webview/AwTokenBindingManager.java

Status: Verified (was: Started)
I think this as much as we can remove. We still have an override of WebViewFactoryProvider#getTokenBindingService(), but I don't see how we can remove that override while still supporting older API levels.

Given that WebView must always override that method, I don't see any reason to remove it from the WebViewFactoryProvider abstract class either (so we can keep the @Override annotation too).

Sign in to add a comment