Tracking bug for go/chrome-tab-hover-cards-design
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e121c2b33bb798adfdc83199ea3a033dc8ad223d commit e121c2b33bb798adfdc83199ea3a033dc8ad223d Author: Caroline Rising <corising@chromium.org> Date: Mon Dec 03 20:19:29 2018 Add flag for tab hover cards feature. Bug: 910739 Change-Id: Ic708c771665e70979cf6011c482dd050ce749fe5 Reviewed-on: https://chromium-review.googlesource.com/c/1357539 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#613213} [modify] https://crrev.com/e121c2b33bb798adfdc83199ea3a033dc8ad223d/chrome/browser/about_flags.cc [modify] https://crrev.com/e121c2b33bb798adfdc83199ea3a033dc8ad223d/chrome/browser/browser_features.cc [modify] https://crrev.com/e121c2b33bb798adfdc83199ea3a033dc8ad223d/chrome/browser/browser_features.h [modify] https://crrev.com/e121c2b33bb798adfdc83199ea3a033dc8ad223d/chrome/browser/flag-metadata.json [modify] https://crrev.com/e121c2b33bb798adfdc83199ea3a033dc8ad223d/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/e121c2b33bb798adfdc83199ea3a033dc8ad223d/chrome/browser/flag_descriptions.h [modify] https://crrev.com/e121c2b33bb798adfdc83199ea3a033dc8ad223d/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/358311a36ab9c3fd0799d90ec9c1682e78146358 commit 358311a36ab9c3fd0799d90ec9c1682e78146358 Author: Caroline Rising <corising@chromium.org> Date: Wed Jan 02 20:15:13 2019 Add tab hover card prototype behind flag. Add tab hover cards containing page title and domain triggered when hovering over a tab. Triggering behavior is hidden behind TabHoverCards flag. Bug: 910739 Change-Id: I82b4b0573a8cdce407696acef8c2ed91c081b8b5 Reviewed-on: https://chromium-review.googlesource.com/c/1363631 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#619478} [modify] https://crrev.com/358311a36ab9c3fd0799d90ec9c1682e78146358/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/358311a36ab9c3fd0799d90ec9c1682e78146358/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/358311a36ab9c3fd0799d90ec9c1682e78146358/chrome/browser/ui/views/tabs/tab_controller.h [add] https://crrev.com/358311a36ab9c3fd0799d90ec9c1682e78146358/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.cc [add] https://crrev.com/358311a36ab9c3fd0799d90ec9c1682e78146358/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.h [add] https://crrev.com/358311a36ab9c3fd0799d90ec9c1682e78146358/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc [modify] https://crrev.com/358311a36ab9c3fd0799d90ec9c1682e78146358/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/358311a36ab9c3fd0799d90ec9c1682e78146358/chrome/browser/ui/views/tabs/tab_strip.h [modify] https://crrev.com/358311a36ab9c3fd0799d90ec9c1682e78146358/chrome/browser/ui/views/tabs/tab_unittest.cc [modify] https://crrev.com/358311a36ab9c3fd0799d90ec9c1682e78146358/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78e4998126d8b665d2464452d7a3a5c7b18fed8a commit 78e4998126d8b665d2464452d7a3a5c7b18fed8a Author: Caroline Rising <corising@chromium.org> Date: Fri Jan 04 22:23:38 2019 Fix flaky tab hover card test. Change test to use two windows to prevent another window from becoming active when calling BrowserView::Deactivate(). Add helper class to wait for a window to become deactive. Bug: 910739 Change-Id: I412a87bbc5de891f67697410e3848694f3c9a893 Reviewed-on: https://chromium-review.googlesource.com/c/1394874 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#620085} [modify] https://crrev.com/78e4998126d8b665d2464452d7a3a5c7b18fed8a/chrome/browser/ui/views/tabs/tab_hover_card_bubble_view_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22310601bf95e8fdaa4f3707ae5c35c00058fac9 commit 22310601bf95e8fdaa4f3707ae5c35c00058fac9 Author: Caroline Rising <corising@chromium.org> Date: Fri Jan 04 23:39:09 2019 Suppress tab tooltips when tab hover cards are enabled. Bug: 910739 Change-Id: I3ab7dd42d8f74806f427acea15257879c810787a Reviewed-on: https://chromium-review.googlesource.com/c/1394439 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#620106} [modify] https://crrev.com/22310601bf95e8fdaa4f3707ae5c35c00058fac9/chrome/browser/ui/views/tabs/tab.cc
Comment 1 by bugdroid1@chromium.org
, Dec 3