New issue
Advanced search Search tips

Issue 910738 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Remove Chevron from Recent Tabs "Show Full History >"

Project Member Reported by sczs@chromium.org, Nov 30

Issue description

History is presented modally and not pushed into the NavigationController. This makes the Chevron confusing and should be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27648386b3f35fcd8f618d291429fd65e854d3f9

commit 27648386b3f35fcd8f618d291429fd65e854d3f9
Author: sczs <sczs@chromium.org>
Date: Mon Dec 03 21:32:14 2018

[ios] Hides chevron for Recent Tabs “Show History” Cell.

- Renames TableViewAccessoryItem/Cell to TableViewImageItem/Cell, and
adds a property that makes the chevron optional.
- Adds tests for the new behavior.
- Uses this new property to hide the chevron on Show Full History in
Recent Tabs.

Bug: 910738
Change-Id: I9aeee17ebab52cbfcedb1c56b5e54221a5d7b2dd
Reviewed-on: https://chromium-review.googlesource.com/c/1358967
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613256}
[modify] https://crrev.com/27648386b3f35fcd8f618d291429fd65e854d3f9/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/27648386b3f35fcd8f618d291429fd65e854d3f9/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm
[modify] https://crrev.com/27648386b3f35fcd8f618d291429fd65e854d3f9/ios/chrome/browser/ui/table_view/cells/BUILD.gn
[delete] https://crrev.com/d8cd79b95de322c7174868f46a937b12f284207c/ios/chrome/browser/ui/table_view/cells/table_view_accessory_item.h
[delete] https://crrev.com/d8cd79b95de322c7174868f46a937b12f284207c/ios/chrome/browser/ui/table_view/cells/table_view_accessory_item_unittest.mm
[add] https://crrev.com/27648386b3f35fcd8f618d291429fd65e854d3f9/ios/chrome/browser/ui/table_view/cells/table_view_image_item.h
[rename] https://crrev.com/27648386b3f35fcd8f618d291429fd65e854d3f9/ios/chrome/browser/ui/table_view/cells/table_view_image_item.mm
[add] https://crrev.com/27648386b3f35fcd8f618d291429fd65e854d3f9/ios/chrome/browser/ui/table_view/cells/table_view_image_item_unittest.mm

Sign in to add a comment