Window invisible but still working after close with cmd+q
Reported by
nicolas....@gmail.com,
Nov 30
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36 Steps to reproduce the problem: 1. open music.google.com, login and start playing some music (so that exit prompt will appear) 2. press cmd+q and quickly release and press q again (keep cmd pressed the whole time) What is the expected behavior? Chrome should have quitted. What went wrong? Instead it's still running, the window still appears in the window list (window menu) and the music is still playing. Also, clicking anywhere on where the window was will still activate the buttons/widgets, as if the window was still there. Did this work before? N/A Chrome version: 70.0.3538.110 Channel: stable OS Version: OS X 10.14.1 Flash Version: See this video: https://www.youtube.com/watch?v=wyXcLSBDBis&feature=youtu.be
,
Dec 1
,
Dec 3
Able to reproduce the issue on reported chrome version #70.0.3538.110 and latest chrome #73.0.3629.0 using Mac 10.14 by following steps as per comment#0 and comment#1.When tested the issue on M-65(#65.0.3325.181) found a bit different behavior that after the clicking cancel neither the window closed nor the music stopped. Note: Prior to M-65 builds, the popup shows the options as "stay" and "leave". Attached screencast for reference. @reporter: Could you please review the attached screencast and help us by confirming whether it can be considered as bad behavior or not. So that it would be really helpful in triaging the issue further. Thanks.!
,
Dec 3
The behavior seen on the screencast looks good to me: since it's displayed on the "beforeunload" event (which can prevent the page from unloading), music should not stop playing and window should not be closed. Also, this is what happens on latest versions of Safari and Firefox (only difference is that Safari closes other tabs and only keep opens (and running) the Google Music one).
,
Dec 3
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7
Ha, that's a neat bug! Thanks for filing it. Over to avi@ - something's odd about how we handle the cmd-q prompt versus beforeunloads...
,
Dec 13
,
Dec 13
,
Dec 13
Oh boy. The confirm quit window is weird.
What's happening here is "magic" in -[ConfirmQuitPanelController runModalLoopForApplication:]. Let me quote the comment:
// The panel tells users to Hold Cmd+Q. However, we also want to have a
// double-tap shortcut that allows for a quick quit path. For the users who
// tap Cmd+Q and then hold it with the window still open, this double-tap
// logic will run and cause the quit to get committed. If the key
// combination held down, the system will start sending the Cmd+Q event to
// the next key application, and so on. This is bad, so instead we hide all
// the windows (without animation) to look like we've "quit" and then wait
// for the KeyUp event to commit the quit.
So the user taps Q, and then holds it. This code then hides all the windows to fake a quit, so that it can wait for the release and really quit. Then the user releases the Q.
Then Chrome *really* tries to close all the windows and hits the beforeunload.
Wheeeeeeee.....
,
Dec 13
I made a change in f19bb479a965dc882d5fd4debf24aaad76878930 to move the confirmation dialog much much earlier in the quit flow. I wonder if the problem about tap-and-hold quitting still is present with the new location of the code.
,
Dec 13
That behavior was added in https://codereview.chromium.org/6625025 to fix bug 74976 on 10.6. Lemme poke on my MacBook as I can't really afford to be randomly quitting apps on my work Mac Pro.
,
Dec 13
This also bites us with a normal hold-to-quit. Even on that branch we explicitly fade out the windows to convince the user to let go of Q before we quit, and we hit the same problem.
,
Dec 18
,
Jan 7
Issue 918971 has been merged into this issue.
,
Jan 8
cc elly; this is the confirm-to-quit bug we discussed.
,
Jan 8
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by nicolas....@gmail.com
, Nov 30